Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <ff03c08047e0cdc79471d7bc35e48fa70efc1215.camel@gmail.com>
Subject: Re: [PATCH v4 07/11] powerpc/pseries/iommu: Reorganize
 iommu_table_setparms*() with new helper
From:   Leonardo =?ISO-8859-1?Q?Br=E1s?= <leobras.c@gmail.com>
To:     Alexey Kardashevskiy <aik@ozlabs.ru>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        Joel Stanley <joel@jms.id.au>,
        Christophe Leroy <christophe.leroy@c-s.fr>,
        Nicolin Chen <nicoleotsuka@gmail.com>,
        Niklas Schnelle <schnelle@linux.ibm.com>
Cc:     linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Date:   Wed, 14 Jul 2021 16:02:00 -0300
In-Reply-To: <88e3b97e-201d-0782-0e95-8e3d2d850a38@ozlabs.ru>
References: <20210430163145.146984-1-leobras.c@gmail.com>
         <20210430163145.146984-8-leobras.c@gmail.com>
         <e4984fa0-2afe-a987-4fb8-61b878431b1f@ozlabs.ru>
         <97626d3883ed207b818760a8239babb08a6b5c59.camel@gmail.com>
         <b25dff0f130b9ab721b8b524e55a3cd4c244a8f3.camel@gmail.com>
         <88e3b97e-201d-0782-0e95-8e3d2d850a38@ozlabs.ru>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.40.3 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, 2021-07-14 at 18:32 +1000, Alexey Kardashevskiy wrote:
> 
> 
> On 13/07/2021 14:47, Leonardo Brás wrote:
> > Hello Alexey,
> > 
> > On Fri, 2021-06-18 at 19:26 -0300, Leonardo Brás wrote:
> > > > 
> > > > > +                                        unsigned long liobn,
> > > > > unsigned long win_addr,
> > > > > +                                        unsigned long
> > > > > window_size,
> > > > > unsigned long page_shift,
> > > > > +                                        unsigned long base,
> > > > > struct
> > > > > iommu_table_ops *table_ops)
> > > > 
> > > > 
> > > > iommu_table_setparms() rather than passing 0 around.
> > > > 
> > > > The same comment about "liobn" - set it in
> > > > iommu_table_setparms_lpar().
> > > > The reviewer will see what field atters in what situation imho.
> > > > 
> > > 
> > > The idea here was to keep all tbl parameters setting in
> > > _iommu_table_setparms (or iommu_table_setparms_common).
> > > 
> > > I understand the idea that each one of those is optional in the
> > > other
> > > case, but should we keep whatever value is present in the other
> > > variable (not zeroing the other variable), or do someting like:
> > > 
> > > tbl->it_index = 0;
> > > tbl->it_base = basep;
> > > (in iommu_table_setparms)
> > > 
> > > tbl->it_index = liobn;
> > > tbl->it_base = 0;
> > > (in iommu_table_setparms_lpar)
> > > 
> > 
> > This one is supposed to be a question, but I missed the question
> > mark.
> > Sorry about that.
> 
> Ah ok :)
> 
> > I would like to get your opinion in this :)
> 
> Besides making the "base" parameter a pointer, I really do not have 
> strong preference, just make it not hurting eyes of a reader, that's
> all :)

Ok, done :)

> imho in general, rather than answering 5 weeks later, it is more 
> productive to address whatever comments were made, add comments (in
> the 
> code or commit logs) why you are sticking to your initial approach, 
> rebase and repost the whole thing. Thanks,

Thanks for the tip, and for the reviewing :)

Best regards,
Leonardo Bras