Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210714001127.GA994@raspberrypi>
In-Reply-To: <20210714001127.GA994@raspberrypi>
From:   Paul Moore <paul@paul-moore.com>
Date:   Wed, 14 Jul 2021 15:26:37 -0400
Message-ID: <CAHC9VhSd7hTXUyeYB1=icx+W40f4E=1fzp4AC3B2gHFeubArRg@mail.gmail.com>
Subject: Re: [PATCH v2] lsm_audit,selinux: return early for possible NULL
 audit buffers
To:     Austin Kim <austindh.kim@gmail.com>
Cc:     Stephen Smalley <stephen.smalley.work@gmail.com>,
        Eric Paris <eparis@parisplace.org>,
        Ondrej Mosnacek <omosnace@redhat.com>, selinux@vger.kernel.org,
        linux-kernel@vger.kernel.org, austin.kim@lge.com,
        kernel-team@lge.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jul 13, 2021 at 8:11 PM Austin Kim <austindh.kim@gmail.com> wrote:
>
> From: Austin Kim <austin.kim@lge.com>
>
> audit_log_start() may return NULL in below cases:
>
>   - when audit is not initialized.
>   - when audit backlog limit exceeds.
>
> After the call to audit_log_start() is made and then possible NULL audit
> buffer argument is passed to audit_log_*() functions,
> audit_log_*() functions return immediately in case of a NULL audit buffer
> argument.
>
> But it is optimal to return early when audit_log_start() returns NULL,
> because it is not necessary for audit_log_*() functions to be called with
> NULL audit buffer argument.
>
> So add exception handling for possible NULL audit buffers where
> return value can be handled from callers.
>
> Signed-off-by: Austin Kim <austin.kim@lge.com>
> ---
>  security/selinux/hooks.c       | 4 ++++
>  security/selinux/ss/services.c | 2 ++
>  2 files changed, 6 insertions(+)

Merged into selinux/next, thank you!

-- 
paul moore
www.paul-moore.com