Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp674598pxv; Wed, 14 Jul 2021 12:44:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZLlBL78vWZs4Be5lWukcKS6ZFH9Ne59Y3/kUCiTNqtpUdSEeUqjt48GKpRxKG0LelAair X-Received: by 2002:a05:6e02:1c88:: with SMTP id w8mr7680518ill.154.1626291893531; Wed, 14 Jul 2021 12:44:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626291893; cv=none; d=google.com; s=arc-20160816; b=HbXPntin7iVryFKM188f4VbXg9GohIsEoHY2aGZ9esWi/DggCqcBbYZeOhRyykSB10 +RGAvC2DOSCREbsm56qjc+R7jYf4XEtYodUm1nNjM1qdT/ubiUyPaXQD9QE/B5dxQURn cm+ecQn5kVZE/WpdPzKjQVGu5y9l9uGQ3vhpY85oFOlnnKQSzVFACCgJuidqW2FsSDaN VdOZ1XfISO+ZDjNBLPNhef8zNww8IgyVZbpiUSXqb/Hq3In1LnQrr1W5FHZX/Xswxafg x0x3cAs8+DGfbf7efSG7QqyXue5cN7Z9JOF5R4euhyd9dgJBFskigsvnGhcKxFnhj+xc 825A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vguY6dzp6Gff2NUMaiEzSX9abI3RSrIdptyKBaoG7SQ=; b=LeVNcJ/ynyaMvGnxVaki1j6loTWtKUdR+56GYD8DwXjM/y3Fze8wq7NOyPMhXONvg6 G4K5o/uhQWpYr6NcMArPDuHhkNZwUudwtMSYl06YZa0tBB9O9Nn560FkR9zcBwPlx4Sn JIO28EG0cnzOR2QgJuHE3k4e6CMnendCM/gJt0NesNZ/MijliWyqLwJVpSeYRNtrW2m2 A7uF2OBSeidaO7EoV1AOd+4vZTSSluW0u0PPzs+YxpdaQDZQN2Mf19wX6Bb/p2gkl/tA aEESX7JH+IG3ZRzDZejQ3xNULOvPY88Xs6pOgAwoB/vI7rRDAtsfLgzhW85l4lriI9hI ZJnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ocQp8UBR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e3si3630134iow.52.2021.07.14.12.44.40; Wed, 14 Jul 2021 12:44:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ocQp8UBR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234834AbhGNTq7 (ORCPT + 99 others); Wed, 14 Jul 2021 15:46:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:37944 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235026AbhGNTmd (ORCPT ); Wed, 14 Jul 2021 15:42:33 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C196C600D4; Wed, 14 Jul 2021 19:39:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626291581; bh=Z4P5MoOI1A3rTntoZ5jca6mUwSxAZ6VYmqDO5ThiPEs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ocQp8UBRXyl2gqOujrqSHruJdIEQfC9tMdsLOnzAQYfEPo1HHm+ATAkVvPPmLzHr6 vIhQChm+ZXetnJES2hLJQ57qWx4EL6L+YtVuV8SDoQavJNHTR7sRdmmKKgp/3QNfqD snHoiOJdZhCNTi+tg4d/vZQPemczGysAkH0FnDFwpbj0bBhV+bj3vzfMH1C9KmuUM3 bEFg4VI5+QnBXblW84ySkPtfcunrMYa42kaL96+qZIjQbec84fJpZghXg28R/XJtCn QAly/qskA/XKAWD63sCYpmN/mTLMrTsP0YpG9YriIRzSSAE3+zo8FZ1aEMZsrET1wk SnubSPsX/SgLA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yang Yingliang , Hulk Robot , Miquel Raynal , Alexandre Belloni , Sasha Levin , linux-i3c@lists.infradead.org Subject: [PATCH AUTOSEL 5.13 069/108] i3c: master: svc: drop free_irq of devm_request_irq allocated irq Date: Wed, 14 Jul 2021 15:37:21 -0400 Message-Id: <20210714193800.52097-69-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210714193800.52097-1-sashal@kernel.org> References: <20210714193800.52097-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Yingliang [ Upstream commit 59a61e69c4252b4e8ecd15e752b0d2337f0121b7 ] irq allocated with devm_request_irq() will be freed in devm_irq_release(), using free_irq() in ->remove() will causes a dangling pointer, and a subsequent double free. So remove the free_irq() in svc_i3c_master_remove(). Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Reviewed-by: Miquel Raynal Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20210602084935.3977636-1-yangyingliang@huawei.com Signed-off-by: Sasha Levin --- drivers/i3c/master/svc-i3c-master.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c index 1f6ba4221817..eeb49b5d90ef 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -1448,7 +1448,6 @@ static int svc_i3c_master_remove(struct platform_device *pdev) if (ret) return ret; - free_irq(master->irq, master); clk_disable_unprepare(master->pclk); clk_disable_unprepare(master->fclk); clk_disable_unprepare(master->sclk); -- 2.30.2