Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 14 Jul 2021 15:27:41 -0600
From:   Rob Herring <robh@kernel.org>
To:     Adam Ford <aford173@gmail.com>
Cc:     linux-usb@vger.kernel.org, aford@beaconembedded.com,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Magnus Damm <magnus.damm@gmail.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: usb: renesas,usbhs: Support external
 ref clock
Message-ID: <20210714212741.GA3554282@robh.at.kernel.org>
References: <20210630173042.186394-1-aford173@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210630173042.186394-1-aford173@gmail.com>
Precedence: bulk

On Wed, Jun 30, 2021 at 12:30:40PM -0500, Adam Ford wrote:
> The usbhs driver expects a fixed external reference clock, but it
> could be sourced from a programmable clock instead of a fixed clock.
> Add support for an optional 4th reference clock.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> 
> diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> index e67223d90bb7..2372d8c42979 100644
> --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> @@ -53,11 +53,12 @@ properties:
>  
>    clocks:
>      minItems: 1
> -    maxItems: 3
> +    maxItems: 4

You won't need this in v5.14-rc1. These are implied by 'items' length if 
not specified.

>      items:
>        - description: USB 2.0 host
>        - description: USB 2.0 peripheral
>        - description: USB 2.0 clock selector
> +      - description: Optional external reference clock
>  
>    interrupts:
>      maxItems: 1
> -- 
> 2.25.1
> 
>