Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210714001127.GA994@raspberrypi> <CAHC9VhSd7hTXUyeYB1=icx+W40f4E=1fzp4AC3B2gHFeubArRg@mail.gmail.com>
In-Reply-To: <CAHC9VhSd7hTXUyeYB1=icx+W40f4E=1fzp4AC3B2gHFeubArRg@mail.gmail.com>
From:   Austin Kim <austindh.kim@gmail.com>
Date:   Thu, 15 Jul 2021 06:45:37 +0900
Message-ID: <CADLLry7E+THeMSPLR7kxu-hzA21NHh=tLms0UJ1Wru4NFJ5jRA@mail.gmail.com>
Subject: Re: [PATCH v2] lsm_audit,selinux: return early for possible NULL
 audit buffers
To:     Paul Moore <paul@paul-moore.com>
Cc:     Stephen Smalley <stephen.smalley.work@gmail.com>,
        Eric Paris <eparis@parisplace.org>,
        Ondrej Mosnacek <omosnace@redhat.com>, selinux@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        =?UTF-8?B?6rmA64+Z7ZiE?= <austin.kim@lge.com>,
        kernel-team@lge.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

2021=EB=85=84 7=EC=9B=94 15=EC=9D=BC (=EB=AA=A9) =EC=98=A4=EC=A0=84 4:26, P=
aul Moore <paul@paul-moore.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
>
> On Tue, Jul 13, 2021 at 8:11 PM Austin Kim <austindh.kim@gmail.com> wrote=
:
> >
> > From: Austin Kim <austin.kim@lge.com>
> >
> > audit_log_start() may return NULL in below cases:
> >
> >   - when audit is not initialized.
> >   - when audit backlog limit exceeds.
> >
> > After the call to audit_log_start() is made and then possible NULL audi=
t
> > buffer argument is passed to audit_log_*() functions,
> > audit_log_*() functions return immediately in case of a NULL audit buff=
er
> > argument.
> >
> > But it is optimal to return early when audit_log_start() returns NULL,
> > because it is not necessary for audit_log_*() functions to be called wi=
th
> > NULL audit buffer argument.
> >
> > So add exception handling for possible NULL audit buffers where
> > return value can be handled from callers.
> >
> > Signed-off-by: Austin Kim <austin.kim@lge.com>
> > ---
> >  security/selinux/hooks.c       | 4 ++++
> >  security/selinux/ss/services.c | 2 ++
> >  2 files changed, 6 insertions(+)
>
> Merged into selinux/next, thank you!

Great, thanks for review and feedback.

Thanks,
Austin Kim

>
> --
> paul moore
> www.paul-moore.com