Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 14 Jul 2021 17:10:00 -0600
From:   Rob Herring <robh@kernel.org>
To:     Dmitry Osipenko <digetx@gmail.com>
Cc:     Thierry Reding <treding@nvidia.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Mark Brown <broonie@kernel.org>,
        Sebastian Reichel <sre@kernel.org>,
        Peter Chen <peter.chen@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Felipe Balbi <balbi@kernel.org>,
        David Heidelberg <david@ixit.cz>, devicetree@vger.kernel.org,
        linux-pm@vger.kernel.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v3 02/12] dt-bindings: phy: tegra20-usb-phy: Document
 properties needed for OTG mode
Message-ID: <20210714231000.GB3697673@robh.at.kernel.org>
References: <20210704225433.32029-1-digetx@gmail.com>
 <20210704225433.32029-3-digetx@gmail.com>
 <20210712154139.GB1980362@robh.at.kernel.org>
 <8fe56e89-9e1e-f5e2-5a47-242b5b3d085a@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8fe56e89-9e1e-f5e2-5a47-242b5b3d085a@gmail.com>
Precedence: bulk

On Tue, Jul 13, 2021 at 02:33:11AM +0300, Dmitry Osipenko wrote:
> 12.07.2021 18:41, Rob Herring пишет:
> >> +  nvidia,pmc:
> >> +    $ref: /schemas/types.yaml#/definitions/phandle
> >> +    description:
> >> +      Phandle to Power Management controller.
> >> +
> > Add a cell to this for the PHY reg offset and then get rid of the index:
> > 
> >> +  nvidia,phy-instance:
> >> +    $ref: /schemas/types.yaml#/definitions/uint32
> >> +    minimum: 0
> >> +    maximum: 2
> >> +    description: Unique hardware ID.
> 
> The instance ID belongs to the USB h/w and not to PMC. It may look like
> I added the ID just to get offsets within PMC, but it's not like that.
> The Tegra documentation explicitly assigns unique IDs to the USB
> controllers and PHYs. Hence this ID should be the property of the PHY
> hardware, IMO.

It looks like the use is calculating register offsets in a PMC register. 
That's quite common and including that with the phandle is the preferred 
way to describe it.

Lots of docs have UART1, UART2, UART3, etc. module numbering. We don't 
copy that into DT.

Rob