Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] sched: Dec __cfs_bandwith_used in
 destroy_cfs_bandwidth()
To:     Daniel Jordan <daniel.m.jordan@oracle.com>
References: <3b2eb2c6-20d5-9f13-09f9-77f87f333b8d@huawei.com>
 <20210714132233.o4zvgdiiugxf6yxk@oracle.com>
In-Reply-To: <20210714132233.o4zvgdiiugxf6yxk@oracle.com>
From:   Zhang Qiao <zhangqiao22@huawei.com>
CC:     <mingo@redhat.com>, <peterz@infradead.org>,
        <juri.lelli@redhat.com>, <vincent.guittot@linaro.org>,
        <dietmar.eggemann@arm.com>, <rostedt@goodmis.org>,
        <bsegall@google.com>, <mgorman@suse.de>, <bristot@redhat.com>,
        <pjt@google.com>, <linux-kernel@vger.kernel.org>
Message-ID: <821cf5ad-4633-0005-63b3-14618891aeed@huawei.com>
Date:   Thu, 15 Jul 2021 10:07:25 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
Content-Type: text/plain; charset="gbk"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2021/7/14 21:22, Daniel Jordan wrote:
> On Wed, Jul 14, 2021 at 07:20:39PM +0800, Zhang Qiao wrote:
>> And i have another thought is that we can hold the
>> hotplug lock before calling cfs_bandwidth_usage_dec().
>> This way, fewer modifications are involved.
>> What do you think about it?
> 
> It is fewer lines, but then hotplug lock is taken pointlessly for
> !JUMP_LABEL.  Not a huge deal in a slow path like this, just a bit lame.
> Adding a new variant seems cleaner if more verbose.
make sense. And I will modify in next version.
thanks.
> .
>