Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp112591pxv; Wed, 14 Jul 2021 20:16:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzVyroLVidwqOiDjKL/Qc0VnU9YgEpZlJBBYNthlFUDLy7N6Peet/i6FDKUQmYP8+XBqprc X-Received: by 2002:a17:906:5d0b:: with SMTP id g11mr2247283ejt.437.1626318978624; Wed, 14 Jul 2021 20:16:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626318978; cv=none; d=google.com; s=arc-20160816; b=kaY9+0t3RcjF0Ke+s9P2uzXekLSJ7N/V9GMsgqC8m6+dupfBiWHjizGDH1rSq7k8Wx pgGddNluUNgkzA1t0eDXONG65Snmu0RvcGq1SP1TRZ0Wh7/kvORFyxV/LpBO11wqQHcq 2jsWp9mnCrik7UF8h/we6Afy4EyUEyU3L2iFQMevV5bjXOGTMdpZ7YWThysrgGK5n5kV TfliaydhKe7sAENDTYpS0ZuxZD4NLjCl0FMAYTiUQBe6NyyeaH1macxybPWasFDdu/51 zN2bRQYQfH1OpY25lVusZuzZ0tWLcMU1fW+0aUIxkuCnE/1GZGl5O9xoOrF0gHYfVC8Z 5V6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=h175uYknUPyIZW14PglDKHbBYWBDImpCLC3RsvNVW78=; b=lQaLX8JTdbwpO9cJWjvJNSQgdUVAh6yl95K1ijQwAnZ4f5Y2/7EeSBt0mMeMlt/pS5 XKNv0Awwo+0Dcsf2K0cKR1nwTGI9vONBLvDGDxKoZlSqRSuK/e8rMPJZLaK41Hu4Ftvb ElL4v2TwqLXKe+jdGuiazfYTIoP6ZrnvQKJGKmhtlYvhwaIPp1BmQFtI9o6H12UZOgf9 wHlUApGcPNtgFng16OYFf/dOvQknQSDaGMXWhf9tVSJfsG757BkdfZ6vjI9Pq5BUpNLS JBKFJ3edvkE1sKlnzGdXEQeACNZ3+dPC3FfiYU3W2lcgwwHLY7YKmWrl3MGFe0rmZz92 vLbw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nb19si2518842ejc.197.2021.07.14.20.15.55; Wed, 14 Jul 2021 20:16:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232728AbhGODMH (ORCPT + 99 others); Wed, 14 Jul 2021 23:12:07 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:11308 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230433AbhGODMG (ORCPT ); Wed, 14 Jul 2021 23:12:06 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.56]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4GQK3Z6mlJz7tFq; Thu, 15 Jul 2021 11:04:42 +0800 (CST) Received: from dggema764-chm.china.huawei.com (10.1.198.206) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Thu, 15 Jul 2021 11:09:12 +0800 Received: from DESKTOP-8RFUVS3.china.huawei.com (10.174.185.179) by dggema764-chm.china.huawei.com (10.1.198.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Thu, 15 Jul 2021 11:09:11 +0800 From: Zenghui Yu To: , , , , CC: , , Zenghui Yu Subject: [PATCH] locking/qspinlock: Fix typo of lock word transition in the uncontended case Date: Thu, 15 Jul 2021 11:08:47 +0800 Message-ID: <20210715030847.2038-1-yuzenghui@huawei.com> X-Mailer: git-send-email 2.23.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.174.185.179] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggema764-chm.china.huawei.com (10.1.198.206) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If the queue head is the only one in the queue and nobody is concurrently setting PENDING bit, the uncontended transition should be n,0,0 -> 0,0,1. Fix the typo. Signed-off-by: Zenghui Yu --- kernel/locking/qspinlock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/locking/qspinlock.c b/kernel/locking/qspinlock.c index cbff6ba53d56..591835415698 100644 --- a/kernel/locking/qspinlock.c +++ b/kernel/locking/qspinlock.c @@ -355,7 +355,7 @@ void queued_spin_lock_slowpath(struct qspinlock *lock, u32 val) * If we observe contention, there is a concurrent locker. * * Undo and queue; our setting of PENDING might have made the - * n,0,0 -> 0,0,0 transition fail and it will now be waiting + * n,0,0 -> 0,0,1 transition fail and it will now be waiting * on @next to become !NULL. */ if (unlikely(val & ~_Q_LOCKED_MASK)) { -- 2.19.1