Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp146231pxv; Thu, 15 Jul 2021 00:50:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJycguuOqJZYmmI8nSCAR6tE5XbKp62x2f78XV5dvXGV/gOKZjIg+adyOyrXMp97YlE5GL/+ X-Received: by 2002:a05:6402:3192:: with SMTP id di18mr5112584edb.186.1626335450740; Thu, 15 Jul 2021 00:50:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626335450; cv=none; d=google.com; s=arc-20160816; b=PzBONmMyL1vp+dL55PZzHx+TzVuFgrE9rO9Z4HhP+Cy6gxZi1t45n4861n0RX1/FSr 3Xg7RtugSPZN4psWkALsGRVHnMqTCkqjnnKdJEFqDY3c7ROOmmp8RuvhzKByz0DUAt+9 bLrM44gMiGRuyqZMg+fJRMphPWBgr3g5Getaa/AYNpm8EwEN0svyUb+swe5u+CYSk7mT 7YpfmvuUV5rpf4WYZTi+IsJyTfF31KTBT4cImRVXBCHpJ/xtRmlkqs9IRECwOeeFzjcu ju72VUuFJJF+/6aezv+C/X5zUi1Y/PGIwrIXxt1SJ61+Nw0H58lZxpcrWMKggOmWGfaZ yNEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=E4o291CiEkirXhlNU9qhgU1unG2pTpkpRkPYhVT13Jw=; b=lzdtt9UEI9E4q6k5HjOuaIijqBra89wS9lxaCQ8SoKCCb1mk2yhKzCGXRlxGPEPfeQ WLfvPJTASYp/qbqDFrYQahhfJtHBszyNzykNhH+f2jThde4U7H6JypCl+P66nCdTnULM 0pnLE5BvP5AYtiOEifwK/aoSDmbCytuK+OnL0XvNmIYw0UF9XwhWwaJXdW/A8Qi5R+fR SDkG9oAO58W12rdfdmVAVdWgvbKpM0SYNjS9jLFpK1JRT3DsCZ3Vb058N46V65g7Mu3z xMg93d6eLIuxVGV7X6YCIaA5oSryrlXBkoSAd/alf18N40Q8Zh+NWie2ysLkU0NcKSrB M1lQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=hMx7mTzB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u11si6743148edy.569.2021.07.15.00.50.28; Thu, 15 Jul 2021 00:50:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=hMx7mTzB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238355AbhGOFT0 (ORCPT + 99 others); Thu, 15 Jul 2021 01:19:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238195AbhGOFTZ (ORCPT ); Thu, 15 Jul 2021 01:19:25 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FD61C061760; Wed, 14 Jul 2021 22:16:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=E4o291CiEkirXhlNU9qhgU1unG2pTpkpRkPYhVT13Jw=; b=hMx7mTzBw8NvkBPVXiIoTms9Np Qcbuveu5Ui3/uJEgMl4C+IRrRd67cr8V6ditJNZYTAOqUujZvcxpXVXdVAdxePjvHr26aIw4zpRii IYN5LwhWPvr//u/j3SxRVl3QKX08bhslxEspnQay0FmtMHwzth3Nk/LQ8j21yrY5jooR0/mmE0UoG lFQvxptbMLAI/wlzy6LZ/zrzVueYVz862OpRj0e7Iz1CRfBIoJKr+ciR4SYWE4oRcDb7Jk9Pj4jgP zSAKaQhC3SVtizLdl9vWsDwRyvrHR3f0kYlvI/mrxrzhGE6RBK9BTtsVPIM8ToPFD6faCzIVGpBKA KQ34HDkw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3thq-0030QK-2N; Thu, 15 Jul 2021 05:14:51 +0000 From: "Matthew Wilcox (Oracle)" To: linux-kernel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: [PATCH v14 121/138] mm/filemap: Remove PageHWPoison check from next_uptodate_page() Date: Thu, 15 Jul 2021 04:36:47 +0100 Message-Id: <20210715033704.692967-122-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210715033704.692967-1-willy@infradead.org> References: <20210715033704.692967-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pages are individually marked as suffering from hardware poisoning. Checking that the head page is not hardware poisoned doesn't make sense; we might be after a subpage. We check each page individually before we use it, so this was an optimisation gone wrong. Signed-off-by: Matthew Wilcox (Oracle) --- mm/filemap.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/mm/filemap.c b/mm/filemap.c index 8510f67dc749..717b0d262306 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -3127,8 +3127,6 @@ static struct page *next_uptodate_page(struct page *page, goto skip; if (!PageUptodate(page) || PageReadahead(page)) goto skip; - if (PageHWPoison(page)) - goto skip; if (!trylock_page(page)) goto skip; if (page->mapping != mapping) -- 2.30.2