Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 15 Jul 2021 08:48:44 +0200
Message-ID: <s5hy2a8xeb7.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Salah Triki <salah.triki@gmail.com>
Cc:     perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sound: usb: line6: free allocated urbs on failure
In-Reply-To: <20210715005625.GA1997259@pc>
References: <20210715005625.GA1997259@pc>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 15 Jul 2021 02:56:25 +0200,
Salah Triki wrote:
> 
> Free allocated urbs on failure in order to prevent memory leaks.
> 
> Signed-off-by: Salah Triki <salah.triki@gmail.com>

This will lead to double-free.  The resources are freed in the
destructor of PCM component, line6_cleanup_pcm().


Takashi


> ---
>  sound/usb/line6/capture.c | 22 ++++++++++++++++++----
>  1 file changed, 18 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/usb/line6/capture.c b/sound/usb/line6/capture.c
> index 970c9bdce0b2..345b75ede5d5 100644
> --- a/sound/usb/line6/capture.c
> +++ b/sound/usb/line6/capture.c
> @@ -258,6 +258,7 @@ int line6_create_audio_in_urbs(struct snd_line6_pcm *line6pcm)
>  {
>  	struct usb_line6 *line6 = line6pcm->line6;
>  	int i;
> +	int ret;
>  
>  	line6pcm->in.urbs = kcalloc(line6->iso_buffers, sizeof(struct urb *),
>  				    GFP_KERNEL);
> @@ -272,8 +273,10 @@ int line6_create_audio_in_urbs(struct snd_line6_pcm *line6pcm)
>  		urb = line6pcm->in.urbs[i] =
>  		    usb_alloc_urb(LINE6_ISO_PACKETS, GFP_KERNEL);
>  
> -		if (urb == NULL)
> -			return -ENOMEM;
> +		if (urb == NULL) {
> +			ret = -ENOMEM;
> +			goto enomem;
> +		}
>  
>  		urb->dev = line6->usbdev;
>  		urb->pipe =
> @@ -286,9 +289,20 @@ int line6_create_audio_in_urbs(struct snd_line6_pcm *line6pcm)
>  		urb->interval = LINE6_ISO_INTERVAL;
>  		urb->error_count = 0;
>  		urb->complete = audio_in_callback;
> -		if (usb_urb_ep_type_check(urb))
> -			return -EINVAL;
> +		if (usb_urb_ep_type_check(urb)) {
> +			ret = -EINVAL;
> +			goto einval;
> +		}
>  	}
>  
>  	return 0;
> +
> +enomem:
> +	i--;
> +
> +einval:
> +	while (i >= 0)
> +		usb_free_urb(line6pcm->in.urbs[i--]);
> +
> +	return ret;
>  }
> -- 
> 2.25.1
>