Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 15 Jul 2021 09:34:55 +0200
From:   Joerg Roedel <jroedel@suse.de>
To:     "Rafael J. Wysocki" <rafael@kernel.org>
Cc:     Joerg Roedel <joro@8bytes.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Rafael J . Wysocki" <rjw@rjwysocki.net>,
        Len Brown <lenb@kernel.org>,
        Linux PCI <linux-pci@vger.kernel.org>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] PCI/APCI: Move acpi_pci_osc_support() check to
 negotiation phase
Message-ID: <YO/lH2fEwTNeQso1@suse.de>
References: <20210714085512.2176-1-joro@8bytes.org>
 <20210714085512.2176-2-joro@8bytes.org>
 <CAJZ5v0if-5A0vZSTeDvqLtqE2jZrKjCFcRouR2uFgycZ7CdWkg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJZ5v0if-5A0vZSTeDvqLtqE2jZrKjCFcRouR2uFgycZ7CdWkg@mail.gmail.com>
Precedence: bulk

Hi Rafael,

On Wed, Jul 14, 2021 at 02:04:17PM +0200, Rafael J. Wysocki wrote:
> >         decode_osc_support(root, "OS supports", support);
> > -       status = acpi_pci_osc_support(root, support);
> > -       if (ACPI_FAILURE(status)) {
> > -               *no_aspm = 1;
> >
> > -               /* _OSC is optional for PCI host bridges */
> > -               if ((status == AE_NOT_FOUND) && !is_pcie)
> > +       if (!pcie_ports_disabled) {
> 
> If pcie_ports_disabled is set, we don't want to request any control
> from the platform firmware at all and, specifically, we don't want to
> evaluate _OSC with the OSC_QUERY_ENABLE clear in
> capbuf[OSC_QUERY_DWORD].
> 
> I'm not sure how this is achieved after your changes.

Yeah, it isn't. The acpi_pci_osc_control_set() function will always do
an _OSC call with OSC_QUERY_ENABLE clear. I will come up with a new
approach.

Thanks,

	Joerg