Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 15 Jul 2021 10:07:38 +0200
From:   Christian Brauner <christian.brauner@ubuntu.com>
To:     Carlos Llamas <cmllamas@google.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Arve =?utf-8?B?SGrDuG5uZXbDpWc=?= <arve@android.com>,
        Todd Kjos <tkjos@android.com>,
        Martijn Coenen <maco@android.com>,
        Christian Brauner <christian@brauner.io>,
        Joel Fernandes <joel@joelfernandes.org>,
        Steven Moreland <smoreland@google.com>,
        kernel-team@android.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] binderfs: add support for feature files
Message-ID: <20210715080738.oumkwhbcz7lxej65@wittgenstein>
References: <20210707162419.15510-1-cmllamas@google.com>
 <20210715031805.1725878-1-cmllamas@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210715031805.1725878-1-cmllamas@google.com>
Precedence: bulk

On Thu, Jul 15, 2021 at 03:18:03AM +0000, Carlos Llamas wrote:
> Provide userspace with a mechanism to discover features supported by
> the binder driver to refrain from using any unsupported ones in the
> first place. Starting with "oneway_spam_detection" only new features
> are to be listed under binderfs and all previous ones are assumed to
> be supported.
> 
> Assuming an instance of binderfs has been mounted at /dev/binderfs,
> binder feature files can be found under /dev/binderfs/features/.
> Usage example:
> 
>   $ mkdir /dev/binderfs
>   $ mount -t binder binder /dev/binderfs
>   $ cat /dev/binderfs/features/oneway_spam_detection
>   1
> 
> Signed-off-by: Carlos Llamas <cmllamas@google.com>
> ---

Looks good,
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>