Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp410430pxv; Thu, 15 Jul 2021 07:08:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwEG2SngMVCTv4CpEmcqRWTwqihJ3SsQMwa/4iNMvoKJuAbQlhgz1nr/uq/aFBNcDWcz5Rj X-Received: by 2002:a17:907:7296:: with SMTP id dt22mr5867269ejc.86.1626358092884; Thu, 15 Jul 2021 07:08:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626358092; cv=none; d=google.com; s=arc-20160816; b=BRVhZT1avu1eRzp677zSz+yfDEVCBAB7NwzOA0PK3kdOFGtuX6jqPawCuoMM59Y+qe XoIOrVcmyIWLiZY3lu2OiT89nJvc7W7l32ndzk5H4204JZZOyYOBwESt1o0zAF+aj42A j9hMVDQaBFqn/58YA9JJ8wRZXT8UqpGyltjNK0oGYP+bG33q58g25R0PT/6WbCjJkrI0 cS1xlhHyEcMIhOfSa+wYkgY23VHpOmtICBy20UcmK7w9kiuhPPTch3iI0jeEU/8Sg7GP cqYUypQ5dESZVX91wqnbD4HLLzJtvO67PsB0tYH9r6COmAXslbeYH5KDAk6tf124KdNR rMtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Ec6gsEASutNX9hKmZXXi7eaIRCz2rB2aGUNI46zbQ0E=; b=cxa/METapTYK30zYM8XIP34uF/e1afP09jjV/oYr6bK2RlOiw5YIQcvOb2Iknr3wSt LG12hz5xNwt7RWhuIKcR+5AzAIkv6FjdWNUKP/XLmRQR8KQS2ryxkpXHkSmLsmvjFjXH HkCfOac1lE8t6wl4S05ZElX7+f8Ig1MaXvL1aVv2WxjmgPR7KiizZdMm2/CuMCxycc9v 2FYQW0uZ3/Lb94/MggH0aqNnxusbkp+wjPb1oGUDALRG5Kyx2sntyq3a9z5fK75E8ITs EjpdauQ4jlFKkQWWfIqZvMyMfVyzvTsTC8YoWWZJrhtWdvUQvKd41/wc5fest9uSGMkR xeTw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v5si8728327edi.582.2021.07.15.07.07.44; Thu, 15 Jul 2021 07:08:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232308AbhGOMKf (ORCPT + 99 others); Thu, 15 Jul 2021 08:10:35 -0400 Received: from mga14.intel.com ([192.55.52.115]:50191 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231689AbhGOMKe (ORCPT ); Thu, 15 Jul 2021 08:10:34 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10045"; a="210344050" X-IronPort-AV: E=Sophos;i="5.84,240,1620716400"; d="scan'208";a="210344050" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2021 05:07:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,240,1620716400"; d="scan'208";a="460371672" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga008.jf.intel.com with ESMTP; 15 Jul 2021 05:07:39 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 52CD32CB; Thu, 15 Jul 2021 15:08:06 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , Heiko Stuebner , Elaine Zhang , Stephen Boyd , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Cc: Michael Turquette , Liu Ying Subject: [PATCH v1 2/3] clk: fractional-divider: Introduce NO_PRESCALER flag Date: Thu, 15 Jul 2021 15:07:51 +0300 Message-Id: <20210715120752.29174-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210715120752.29174-1-andriy.shevchenko@linux.intel.com> References: <20210715120752.29174-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The newly introduced flag, when set, makes the flow to skip the assumption that the caller will use an additional 2^scale prescaler to get the desired clock rate. Reported-by: Liu Ying Signed-off-by: Andy Shevchenko --- drivers/clk/clk-fractional-divider.c | 2 +- include/linux/clk-provider.h | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/clk/clk-fractional-divider.c b/drivers/clk/clk-fractional-divider.c index 535d299af646..b2f9aae9f172 100644 --- a/drivers/clk/clk-fractional-divider.c +++ b/drivers/clk/clk-fractional-divider.c @@ -84,7 +84,7 @@ void clk_fractional_divider_general_approximation(struct clk_hw *hw, * by (scale - fd->nwidth) bits. */ scale = fls_long(*parent_rate / rate - 1); - if (scale > fd->nwidth) + if (scale > fd->nwidth && !(fd->flags & CLK_FRAC_DIVIDER_NO_PRESCALER)) rate <<= scale - fd->nwidth; rational_best_approximation(rate, *parent_rate, diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h index d83b829305c0..f74d0afe275f 100644 --- a/include/linux/clk-provider.h +++ b/include/linux/clk-provider.h @@ -1001,6 +1001,10 @@ struct clk_hw *devm_clk_hw_register_fixed_factor(struct device *dev, * CLK_FRAC_DIVIDER_BIG_ENDIAN - By default little endian register accesses are * used for the divider register. Setting this flag makes the register * accesses big endian. + * CLK_FRAC_DIVIDER_NO_PRESCALER - By default the resulting rate may be shifted + * left by a few bits in case when the asked one is quite small to satisfy + * the desired range of denominator. If the caller wants to get the best + * rate without using an additional prescaler, this flag may be set. */ struct clk_fractional_divider { struct clk_hw hw; @@ -1022,6 +1026,7 @@ struct clk_fractional_divider { #define CLK_FRAC_DIVIDER_ZERO_BASED BIT(0) #define CLK_FRAC_DIVIDER_BIG_ENDIAN BIT(1) +#define CLK_FRAC_DIVIDER_NO_PRESCALER BIT(2) extern const struct clk_ops clk_fractional_divider_ops; struct clk *clk_register_fractional_divider(struct device *dev, -- 2.30.2