Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp411950pxv; Thu, 15 Jul 2021 07:09:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyEdv2MIlR4kUX8QThSW/MKo/2atbk48JMoVTE0QtGkk0JASVISSxGcg3lDXFzKy/AF84sw X-Received: by 2002:a05:6638:3452:: with SMTP id q18mr2013843jav.111.1626358189016; Thu, 15 Jul 2021 07:09:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626358189; cv=none; d=google.com; s=arc-20160816; b=qdl1Z9F21clx+aWfcNmgEFjqjBQoamEVIdfDrtArZfTEnpR5HdPXJmYJlwjbR3R5zs sh2cozaAphkgiTTW8C/2VZx0z7TzvqvQa9AyGAGfg17y4vgOfkYylGd8drhJLF6P282y 35wMP4KimmpCurRuCGFxGy1BDse0lPcm8vSlOWUrsRHjPTk8LRZFaXPr8ZjwesllOhVH O9ZZuTsQD/kegpeEwV9UbPPja0PDgaAMuHFs1XlyWjWC8Y+PmL9YQfXkBiBYGJtU44Ez hmCFAxZc/3rxhBe8SEZt4lczOA83B+XguZe/rrzIdJ8qfUiPKWmGRr0LZ7mt+nmaz90s KBTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=aVtPOhNHIc6Jjl6BWHFCqvLfKfow/AUHn83JrZyLZbM=; b=wEnyZOZ84m51S0XryrK4mzKE3c+2QLHaeEhJfiROhIk53fUzIfhtUQq+sWRETuyNXt wKEi8GLug45nqJ9W9itdi+XJ81zzaKtT2i0ULtwJM1rGq535KQ0t/wTn68Snesl8AQwf Q54K9Tin5CQzBCYMa5nRG8x3xksMZnxDOqaFP5jcufyXqTkde/OwXyAqxYc2sQMzbMkP WTzTbJCDZxnSZu9upePw4Q53CljDG9cnoGSk2G7DI0NE2xdUN6ANqWLm/x3FF8flGAAO iAa+Udb6e4fBDBMFQogBrD6esuZMd2CxHyw6BMF5j878uNAb6EuUwax0/nxjkiYKufeu LFWQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n14si7408896ilk.78.2021.07.15.07.09.35; Thu, 15 Jul 2021 07:09:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237316AbhGOMgr (ORCPT + 99 others); Thu, 15 Jul 2021 08:36:47 -0400 Received: from foss.arm.com ([217.140.110.172]:52184 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229595AbhGOMgr (ORCPT ); Thu, 15 Jul 2021 08:36:47 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 49BD131B; Thu, 15 Jul 2021 05:33:54 -0700 (PDT) Received: from [192.168.178.6] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6B59C3F694; Thu, 15 Jul 2021 05:33:53 -0700 (PDT) Subject: Re: [PATCH] sched/fair: Update nohz.next_balance for newly NOHZ-idle CPUs To: Valentin Schneider , linux-kernel@vger.kernel.org Cc: Peter Zijlstra , Ingo Molnar , Vincent Guittot References: <20210714113928.2795632-1-valentin.schneider@arm.com> From: Dietmar Eggemann Message-ID: <21fda84b-3d66-e8c1-f384-026adbc28ac4@arm.com> Date: Thu, 15 Jul 2021 14:33:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210714113928.2795632-1-valentin.schneider@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/07/2021 13:39, Valentin Schneider wrote: [...] > @@ -8942,6 +8946,10 @@ void __init sched_init(void) > cpumask_size(), GFP_KERNEL, cpu_to_node(i)); > per_cpu(select_idle_mask, i) = (cpumask_var_t)kzalloc_node( > cpumask_size(), GFP_KERNEL, cpu_to_node(i)); > +#ifdef CONFIG_NOHZ_COMMON > + per_cpu(nohz_balance_mask, i) = (cpumask_var_t)kzalloc_node( > + cpumask_size(), GFP_KERNEL, cpu_to_node(i)); > +#endif /* CONFIG_NOHZ_COMMON */ > } > #endif /* CONFIG_CPUMASK_OFFSTACK */ s/CONFIG_NOHZ_COMMON/CONFIG_NO_HZ_COMMON Otherwise CONFIG_CPUMASK_OFFSTACK system will have issues. [...]