Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp509930pxv; Thu, 15 Jul 2021 09:09:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw9o7f/dLmmYGOyKvOpDEAprj++7mP26d0D9SGMs+EEKBJgRbky7IDOA1z8NWDGrJRn0fqK X-Received: by 2002:a92:cbc8:: with SMTP id s8mr2975191ilq.193.1626365395819; Thu, 15 Jul 2021 09:09:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626365395; cv=none; d=google.com; s=arc-20160816; b=TwZ+Xj7ke9+md5IuUUKixPfO361A1QuQ0la6+1G5M5q48bYd6sS44KqbaMmPkvkYaD AI6QCNc5qcvAliZL8ew77NycXG09K0Kf3NRsJg7ICM+da4ueYu4mkDtR7Vj7xltwTpfV DM1QKZ1iBwAtir9Ei3kWRn179IV9LVxQnF5F+uS/dmn/SotDJQsK12YGsdViLVvQkfd0 ALTWd2wN8NXhEHqdmKHvEPZyx4u95+5LQftii9d7voVX/EPOR9s4cRiSVW8839p6oXsO ze6ybx8I+QF3wlVXWuRiET04THZYk70nuOvkukXj784QOHwOjLitoQ/f1OQXatSpjexG ohAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=QcJkplKDoAcFgDG77fof1PVCDu7YIZdl5GdZK+aXiLQ=; b=o6w1UNCxn9tqH1IYRG9ZG3MC5S5rFk7k6rq1OGOoblvlRFlZBr3Q+L60/rUlcAUVqE aXrOWOsaBuDKR6Ul2X03sORCYLBBpsVUUVxm037GlU6auAE5yp18xsvrvofTuAQTtyNP Y3YnG91WxCExeGSRgQJ1AmB7/kVWZesF/OBU3ytrvu9E6GZM2DXqZf7xQlPIifWmLbhr dqrn/gVHE9pgFILwDo3IJ0FDgQueIfM6KAu7HTGXpaf6vIYA/q5ZRsLf0JQLpavZ+fHk cbNkQ46MwaEKzlt4/9OKmpRTNSSyyeyBcFiAWYX/bn365v8ApwUQsrMdh9Ly0/C7ydIT 0R0A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x6si7115516iol.30.2021.07.15.09.09.41; Thu, 15 Jul 2021 09:09:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237446AbhGONSx (ORCPT + 99 others); Thu, 15 Jul 2021 09:18:53 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:11319 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232518AbhGONSw (ORCPT ); Thu, 15 Jul 2021 09:18:52 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4GQZWd6lPsz7tfB; Thu, 15 Jul 2021 21:11:25 +0800 (CST) Received: from dggpeml500017.china.huawei.com (7.185.36.243) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 15 Jul 2021 21:15:55 +0800 Received: from huawei.com (10.175.103.91) by dggpeml500017.china.huawei.com (7.185.36.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 15 Jul 2021 21:15:55 +0800 From: Yang Yingliang To: , CC: , Subject: [PATCH stable-5.10] io_uring: fix clear IORING_SETUP_R_DISABLED in wrong function Date: Thu, 15 Jul 2021 21:18:25 +0800 Message-ID: <20210715131825.2410912-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpeml500017.china.huawei.com (7.185.36.243) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In commit 3ebba796fa25 ("io_uring: ensure that SQPOLL thread is started for exit"), the IORING_SETUP_R_DISABLED is cleared in io_sq_offload_start(), but when backport it to stable-5.10, IORING_SETUP_R_DISABLED is cleared in __io_req_task_submit(), move clearing IORING_SETUP_R_DISABLED to io_sq_offload_start() to fix this. Fixes: 6cae8095490ca ("io_uring: ensure that SQPOLL thread is started for exit") Signed-off-by: Yang Yingliang --- fs/io_uring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/io_uring.c b/fs/io_uring.c index fdbaaf579cc60..57db1dfc35829 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -2086,7 +2086,6 @@ static void __io_req_task_submit(struct io_kiocb *req) __io_req_task_cancel(req, -EFAULT); mutex_unlock(&ctx->uring_lock); - ctx->flags &= ~IORING_SETUP_R_DISABLED; if (ctx->flags & IORING_SETUP_SQPOLL) io_sq_thread_drop_mm(); } @@ -7998,6 +7997,7 @@ static void io_sq_offload_start(struct io_ring_ctx *ctx) { struct io_sq_data *sqd = ctx->sq_data; + ctx->flags &= ~IORING_SETUP_R_DISABLED; if ((ctx->flags & IORING_SETUP_SQPOLL) && sqd->thread) wake_up_process(sqd->thread); } -- 2.25.1