Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp536272pxv; Thu, 15 Jul 2021 09:43:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxpBvD/P7MgMa2UMyZsKi7IEGDLApIK578MBG2MifMVPb7BB/gzpsZNy30TrLTFK8orqdy3 X-Received: by 2002:a17:906:2813:: with SMTP id r19mr6503186ejc.150.1626367380557; Thu, 15 Jul 2021 09:43:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626367380; cv=none; d=google.com; s=arc-20160816; b=OxhaLISse/ijvKq+ueulyT1ZU2sLzbh1dhlFHI0CNc85i2vjLuWgK+lmmAKaDsZ54/ 0rEZWiJNRjTHbtzzCKjytWcukm2FCEMTjkCSyjhAOaDzCZXYT6PdBKLS9DNQAElnHIpY NhJfYVeMDDuNUIun/gkt8Ttm3C+QccmViHvY+xS//5zxL9B/5uFi2GZ1tRaPP2OddpgM isgjrmMOrdgyvGL2fg9qVaszUWn7Fo0jCfUoHtc+D32kiMnDCwx8hbJjHOEM9bOxhd/r XOwNn+KEbZscXpHKc+YuRS5Ixf3Gy7c+iu42XQbSBkY1/x+EkrTgEIXwVBov/hPVkEsz D+Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-signature; bh=gyZhxHZioQnjZVdJUow5Mw2QUXHysMd4yxvDdw4DGwc=; b=QICa2T7Zh13ZMLi8bg8H1VLERQVm+0x60aay4i0g0vFQDrpKYTl7GO/u4bbYWW/Fzn fxGgFMXFriwW6KQiWZPUsq5V3ykEjvCf3/8NcGHiilKEGKsWPtXsc49MCvlAz/QRAzWf HNZ+qGWDyJClSe/qY+NeIBfEBhgZatwhDT8hzLfeNUcBisvZg6x1IbDJs6V19YEbqJs7 TvWj9tRzDvh4RnIpjZWCoQ8aBhJALOBhRxddTLPaFuhIBcNCx/J9MF6rXvKPRdXaZB++ z28+oQYr1l7ULN6qZCKoFKHC9zkIDUZmlTlIgvrrK6CIZ4qH+diOKL6dwarijh6MTr76 JWlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=0furoNcu; dkim=neutral (no key) header.i=@suse.de header.b=xKnyqSKJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ho12si7972502ejc.30.2021.07.15.09.42.36; Thu, 15 Jul 2021 09:43:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=0furoNcu; dkim=neutral (no key) header.i=@suse.de header.b=xKnyqSKJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237959AbhGONnp (ORCPT + 99 others); Thu, 15 Jul 2021 09:43:45 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:59748 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237823AbhGONng (ORCPT ); Thu, 15 Jul 2021 09:43:36 -0400 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A356220305; Thu, 15 Jul 2021 13:40:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1626356442; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=gyZhxHZioQnjZVdJUow5Mw2QUXHysMd4yxvDdw4DGwc=; b=0furoNcuZP5rAqEkjRYeMbZlOvha/jXVBqe3WnohXwO61ArjIXlszycv/AirHzRdvBxBFC lEtQkGiy50HntVcFKQ7JZqIyVTWeEP1qvcSenLoJ4TlfCnEsqn1dSFynzrB5PqKsa93JLY Al6YjAG8kBHvAYpNBNFbmAfVMbO8Ogs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1626356442; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=gyZhxHZioQnjZVdJUow5Mw2QUXHysMd4yxvDdw4DGwc=; b=xKnyqSKJPZuDSl+zTIK1Gz+oDgi+gVCnrNaJscHgH4ZbSX2CHhE5WN/RaVVt5lqMMincJD 2GMZVMbbRWJTrsDA== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 3848213D89; Thu, 15 Jul 2021 13:40:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id /sSiCto68GCUVwAAGKfGzw (envelope-from ); Thu, 15 Jul 2021 13:40:42 +0000 Received: from localhost (brahms [local]) by brahms (OpenSMTPD) with ESMTPA id aad06e43; Thu, 15 Jul 2021 13:40:41 +0000 (UTC) From: Luis Henriques To: Jeff Layton , Ilya Dryomov , Xiubo Li Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Henriques Subject: [PATCH] ceph: don't WARN if we're still opening a session to an MDS Date: Thu, 15 Jul 2021 14:40:39 +0100 Message-Id: <20210715134039.10466-1-lhenriques@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If MDSs aren't available while mounting a filesystem, the session state will transition from SESSION_OPENING to SESSION_CLOSING. And in that scenario check_session_state() will be called from delayed_work() and trigger this WARN. Avoid this by only WARNing after a session has already been established (i.e., the s_ttl will be different from 0). Fixes: 62575e270f66 ("ceph: check session state after bumping session->s_seq") Signed-off-by: Luis Henriques --- fs/ceph/mds_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c index e5af591d3bd4..86f09b1110a2 100644 --- a/fs/ceph/mds_client.c +++ b/fs/ceph/mds_client.c @@ -4468,7 +4468,7 @@ bool check_session_state(struct ceph_mds_session *s) break; case CEPH_MDS_SESSION_CLOSING: /* Should never reach this when we're unmounting */ - WARN_ON_ONCE(true); + WARN_ON_ONCE(s->s_ttl); fallthrough; case CEPH_MDS_SESSION_NEW: case CEPH_MDS_SESSION_RESTARTING: