Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <959c58526c5388eb891fd8a5927b5abc08c46a58.camel@gmail.com>
Subject: Re: [RFC PATCH 02/10] perf tests: add test for workqueue
From:   Riccardo Mancini <rickyman7@gmail.com>
To:     Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc:     Ian Rogers <irogers@google.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Jiri Olsa <jolsa@redhat.com>, linux-kernel@vger.kernel.org,
        linux-perf-users@vger.kernel.org
Date:   Thu, 15 Jul 2021 18:33:29 +0200
In-Reply-To: <YO7+g3wvtvJ+Zm5o@kernel.org>
References: <cover.1626177381.git.rickyman7@gmail.com>
         <333e2e3986d32cf8894105f149abb543a84ec91c.1626177381.git.rickyman7@gmail.com>
         <YO7+g3wvtvJ+Zm5o@kernel.org>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.40.2 (3.40.2-1.fc34) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Arnaldo,

On Wed, 2021-07-14 at 12:10 -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Jul 13, 2021 at 02:11:13PM +0200, Riccardo Mancini escreveu:
> > It will have subtests testing threadpool and workqueue separately.
> > This patch only introduces the first subtest, checking that the
> > threadpool is correctly created and destructed.
> > This test will be expanded when new functions are added in next
> > patches.
> > 
> > Signed-off-by: Riccardo Mancini <rickyman7@gmail.com>
<SNIP>
> > +
> > +
> > +static int __test__threadpool(void *_args)
> > +{
> > +       struct threadpool_test_args_t *args = _args;
> > +       struct threadpool_struct *pool;
> > +       int ret;
> > +
> > +       ret = __threadpool__prepare(&pool, args->pool_size);
> 
> Turn the last three lines into one;

ok

> 
>         int ret = __threadpool__prepare(&pool, args->pool_size);
> 
> > +       if (ret)
> > +               return ret;
> > +
> > +       ret = __threadpool__teardown(pool);
> > +       if (ret)
> > +               return ret;
> > +
> > +       return 0;
> 
> Humm, will you add something here in the following csets? Otherwise turn
> these 5 lines into one:
> 
>         return __threadpool__teardown(pool);

ok, it was just copy-paste from above.

Thanks,
Riccardo

> 
> > +}
> > +
> > +static const struct threadpool_test_args_t threadpool_test_args[] = {
> > +       {
> > +               .pool_size = 1
> > +       },
> > +       {
> > +               .pool_size = 2
> > +       },
> > +       {
> > +               .pool_size = 4
> > +       },
> > +       {
> > +               .pool_size = 8
> > +       },
> > +       {
> > +               .pool_size = 16
> > +       }
> > +};
> > +
> > +struct test_case {
> > +       const char *desc;
> > +       int (*func)(void *args);
> > +       void *args;
> > +       int n_args;
> > +       int arg_size;
> > +};
> > +
> > +static struct test_case workqueue_testcase_table[] = {
> > +       {
> > +               .desc = "Threadpool",
> > +               .func = __test__threadpool,
> > +               .args = (void *) threadpool_test_args,
> > +               .n_args = (int)ARRAY_SIZE(threadpool_test_args),
> > +               .arg_size = sizeof(struct threadpool_test_args_t)
> > +       }
> > +};
> > +
> > +
> > +int test__workqueue(struct test *test __maybe_unused, int i)
> > +{
> > +       int j, ret = 0;
> > +       struct test_case *tc;
> > +
> > +       if (i < 0 || i >= (int)ARRAY_SIZE(workqueue_testcase_table))
> > +               return -1;
> > +
> > +       tc = &workqueue_testcase_table[i];
> > +
> > +       for (j = 0; j < tc->n_args; j++) {
> > +               ret = tc->func(tc->args + (j*tc->arg_size));
> > +               if (ret)
> > +                       return ret;
> > +       }
> > +
> > +       return 0;
> > +}
> > +
> > +
> > +int test__workqueue_subtest_get_nr(void)
> > +{
> > +       return (int)ARRAY_SIZE(workqueue_testcase_table);
> > +}
> > +
> > +const char *test__workqueue_subtest_get_desc(int i)
> > +{
> > +       if (i < 0 || i >= (int)ARRAY_SIZE(workqueue_testcase_table))
> > +               return NULL;
> > +       return workqueue_testcase_table[i].desc;
> > +}
> > -- 
> > 2.31.1
> > 
>