Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp569017pxv; Thu, 15 Jul 2021 10:25:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyqJEktL4E1vnt4lfzbfMOjDVFGOVMxdy0ch6vtY14ktwCWjj7wEaPV36xI143EUekwpEsE X-Received: by 2002:a92:c60c:: with SMTP id p12mr3370194ilm.7.1626369942277; Thu, 15 Jul 2021 10:25:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626369942; cv=none; d=google.com; s=arc-20160816; b=tWpVwbFGe7R9dCOayI4hUGn6LZAE3UHr/C2theDdXWKkMT18LqX3XFeiHsUKI939Tr kEPIqPl55h+O0uauyABmXkCG5zwfavHUFAyKdLbJceNyNF++Ckqvfx9emwRYHAUac2Mp JodljXcTamVgyaWtJfUV0dGMfUr6ZIbAuHyvBofr2G02JprOmjukjEhPBAuTWrdIi/Kd 2RWDaliGyg4w6pbzyIYh5eWQIV3H1KrjRJwL8LgGyM9OvR25MBm/2JvEVV4wy+HVGRiT +q0hxf5ZaCU1DIdDa7XPAv7LNXxZ6ow6zPqOn6dx2yF61G7+qqcRjBCry2VPrvlchgil b1Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from; bh=IvCOHI73DT9osgb52hPZRfa8JBIkQB+Opa7lIUNjPkA=; b=vQ77t0I4OlL5Hi6+jof+kHRADLVdxoQOnvT3SK1+0z6Q9sv+aUJeW3Bi9D9Jz9lffG fNw5GreuL75lky/nL6BSaPYiVww9J64X6e5qccPtdFNn8R6JjIk/YHJ0LxA1eRglhVZp dQORDQLZQlbqZAg/NCCbpsZSZL6oe/cjN6lQEhOYVmSaPNc27RZOZcFpVfmjTnqxFbUS 4pNw+1GzAgndZHDdPp5y7fNz/iVLYegcOLguHEqydey6TEnsdUfVihE1TRMRf3wUUi5J 09FErceeLanBpy3ENExEJ6NDzCciOSYF7AqRXv73wRMHqaJQyvWDdRa7HIwWQvcYZaHB mvaQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s1si7284366jar.29.2021.07.15.10.25.30; Thu, 15 Jul 2021 10:25:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235967AbhGOQ4g (ORCPT + 99 others); Thu, 15 Jul 2021 12:56:36 -0400 Received: from foss.arm.com ([217.140.110.172]:55170 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229695AbhGOQ4f (ORCPT ); Thu, 15 Jul 2021 12:56:35 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 60D286D; Thu, 15 Jul 2021 09:53:41 -0700 (PDT) Received: from e113632-lin (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 93E883F7D8; Thu, 15 Jul 2021 09:53:40 -0700 (PDT) From: Valentin Schneider To: Colin King , Peter Zijlstra , Ingo Molnar Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] smpboot: remove inline from __always_inline'd function idle_init In-Reply-To: <20210715164018.62712-1-colin.king@canonical.com> References: <20210715164018.62712-1-colin.king@canonical.com> Date: Thu, 15 Jul 2021 17:53:34 +0100 Message-ID: <87czrjmsc1.mognet@arm.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/07/21 17:40, Colin King wrote: > From: Colin Ian King > > Declaring a idle_init as inline when it is __always_inline is redundant > so this can be removed. Also swap the order of __always_inline and void > to match the more usual coding style. > > Signed-off-by: Colin Ian King Reviewed-by: Valentin Schneider