Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp575391pxv; Thu, 15 Jul 2021 10:35:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBRrA/3rIQA8gIKfQlwj4S7o7Tig09Jatby5lD0FPMUUQMAjqEuMp9phmdp2By2oyB1PQj X-Received: by 2002:a05:6638:218:: with SMTP id e24mr5102320jaq.38.1626370501308; Thu, 15 Jul 2021 10:35:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626370501; cv=none; d=google.com; s=arc-20160816; b=Awf9b+fi7tnlp+LICO0Ia7ltf1vVJo9/v09Dux84qmN0ONiCUvSseIqFifYZaKh78m fl4tw78Dm+NiQRyPyrRaA9EPXgP1PXAYD2Qsde2osAyqixduPOanNRu3yyyguOhvNd8E kwuwEpRgy/XuKZLnFGjqwnfupf/aSoPLkQLbFSG6SaNPvNrQBLy692GLJ8A87KXHS+Zj n4n0h2C1+YAk6+I3dsgAPLlIkneQvAWa7pL0rRTyrnirE1a+j3K+/axhUYKyfF+poplr N0h8v2nq7ET4LioJ0iZvofIIXvQt0BTwHZSCJRrbgn4NKdQEKbKWtPQcpo+BgnAfRyQW RDgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=QVooNe8eOL1LdoDGZMNp8ewxwDk4TUrAiD+/2Sk66jQ=; b=bcoD7pXAUFYiQjxdXAIHhrXQlRB8Pl4/jq/pO4A3K4T1JB/jSpTRqk35Y7gNzKMcZy vHDC/L6POA86YuTEo4F3NxG82QjDxmJpeyx472bNi2QcfTAtoGRwCcN8trnq5Js7bn94 tzaxa7qx87CaMuMUYR/hs4LpCjeMDthGwXszHptZbjYAXueVLQLEtBeRykiz4HSCq4sB v2oFF0ZseRSwodHt1RCK+HDFZddW4KVWEQ0mk23V01kvxt16jvMhILGl0+EjaUJiqWRm GDB/FpuOfn2Fz3y0lbXjyhCb5X1U19+w58xKvdHrzrDP/btEYG1nbXhJ3k8SZvgYW+Vw 8Jjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=dDCAiTXJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b6si8184975ilv.22.2021.07.15.10.34.48; Thu, 15 Jul 2021 10:35:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=dDCAiTXJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232948AbhGORfp (ORCPT + 99 others); Thu, 15 Jul 2021 13:35:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:57714 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229832AbhGORfn (ORCPT ); Thu, 15 Jul 2021 13:35:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 81F9261357; Thu, 15 Jul 2021 17:32:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626370370; bh=TspSQrdYsvKt5G7QcaVoQ0OF/C4arsn9rMRe1c/kxyM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dDCAiTXJG4zAADbDB2J1ySxzdNnRW27h0jNcySNLpkzYbZ93gpsuku0T3b2y1SlaF uLoTTvqABrxpbHXPq+idioHuJF6aHCDEVErVy3mhwdIelvp+1pe+ovuUMcu8Z1pMZ0 b2jtsmqQkjxTBPo9XGCUR73zBkawS4WdchelHsNI= Date: Thu, 15 Jul 2021 19:32:47 +0200 From: Greg KH To: Jens Axboe Cc: Yang Yingliang , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH stable-5.10] io_uring: fix clear IORING_SETUP_R_DISABLED in wrong function Message-ID: References: <20210715131825.2410912-1-yangyingliang@huawei.com> <2d9aa268-fd78-17ec-df0f-00daa1138a72@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2d9aa268-fd78-17ec-df0f-00daa1138a72@kernel.dk> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 15, 2021 at 09:27:53AM -0600, Jens Axboe wrote: > On 7/15/21 7:22 AM, Greg KH wrote: > > On Thu, Jul 15, 2021 at 09:18:25PM +0800, Yang Yingliang wrote: > >> In commit 3ebba796fa25 ("io_uring: ensure that SQPOLL thread is started for exit"), > >> the IORING_SETUP_R_DISABLED is cleared in io_sq_offload_start(), but when backport > >> it to stable-5.10, IORING_SETUP_R_DISABLED is cleared in __io_req_task_submit(), > >> move clearing IORING_SETUP_R_DISABLED to io_sq_offload_start() to fix this. > >> > >> Fixes: 6cae8095490ca ("io_uring: ensure that SQPOLL thread is started for exit") > >> Signed-off-by: Yang Yingliang > >> --- > >> fs/io_uring.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > I need an ack from Jens before I can take this... > > Ack, that looks like a bad merge. Fine to apply this patch, thanks. THanks, now queued up. greg k-h