Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp612973pxv; Thu, 15 Jul 2021 11:31:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLc1qbU77JrvGv+4SPYKattd6riD0FABie5ZZ2nQ2mWaKkbRBl0jMKl5t9LwogjFIccUXJ X-Received: by 2002:a92:200b:: with SMTP id j11mr3594773ile.183.1626373903178; Thu, 15 Jul 2021 11:31:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626373903; cv=none; d=google.com; s=arc-20160816; b=vCdjYs5U48Ogg4Z8AauBGZZ9Gv7szIIVZRxC+D5IoAx6RfWyCFaSgKiQSLoyasYheb IUtCGMfZljcIvdgVAgSNwmupXJSRm+nZI1l6x7nEXOAl8WFfITHxo76EutY7mb+fYa+X SAknr7bAkm2U1IVYVBJoX8rxhWr7SyMG+PoCTrVcaskpDfOJxXM6YR1CO4mom+kOvE5s p7cWY5/YJqrMnHdKbMokBgDxukZ0Gxh9tF/zzckkKtKmRm84reqckMxak6Lwfnkvk4Zf E1PbxshST51jUxcqYojmxxICV+R0ZCYsoQLQCnmQHwSNgplbeYomSM/SLE4PEBsilOfB Hv7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=TGVdwq/5bAU2MHG7qmOxbHi3C9igc19rOJuXMsOJcdg=; b=GbSD7SNNDaM4VX3lEjljU6Yo9h8TaiYBvVLCiW300ABxWLQ/DC7KRySp3Nkydyqzmy 34Ew8b8Bwl/EGgaOhHXl+nwKX/osfASTlrQM1jqudRm6vP6IV6NIzOifc2V7OgBL652v nUKQicOvugRjpLJSczVl9YT1j5T5yopmiFhq6emYjR4BmbwLpA2NhyLZ5XzCJHNNfPnz 0eOg02CJG6dxfU6jsTtFhdE2qOHEns+0Gj466B8YOUz5hwkyOUvRgwdl3am4IJrwVlPz BO0sVRs0X2KP+vpDRpQ2G2u+xcLAHcNIIlYZaws6ynh/RZdHKZ6wl+JuvCH/k73vxPCI dirw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=ZOXi3u00; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n26si7047902jam.80.2021.07.15.11.31.31; Thu, 15 Jul 2021 11:31:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=ZOXi3u00; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237928AbhGOSVJ (ORCPT + 99 others); Thu, 15 Jul 2021 14:21:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230189AbhGOSVI (ORCPT ); Thu, 15 Jul 2021 14:21:08 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCA29C06175F for ; Thu, 15 Jul 2021 11:18:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=TGVdwq/5bAU2MHG7qmOxbHi3C9igc19rOJuXMsOJcdg=; b=ZOXi3u00QNMyZFzIOik4S8eyrr hey+iuVVOQ3TY5AJojjy8eAASosdliZN0vD8Dxo2+KJjDf8BB8uf8+XJjW48NIko8Ghi3vuQPoWC1 ZDP0GmBmmcTdLxM0hGJj2x+6g7JIdmKlYZGdH2v0pgAXXrJcwIiUsXjxaMZ9q6q6mBeIW4lddwqEo MCx190oCzVzlNPSEkHPWJxxW3Mgw1yLxzBp1ucX0HHSzuZbp0nC32NivSCWSO5kzXIGYWERFETtaG 0yp/iir1czmatqe7xRKGR3HmQs33Ya9oJeyJSMYFSflCApj+/aZy+MSxg1Fjvr7nM9aW1P7sVy6jN XqM/vt/g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m45vA-003cG7-3y; Thu, 15 Jul 2021 18:17:22 +0000 Date: Thu, 15 Jul 2021 19:17:16 +0100 From: Matthew Wilcox To: Zhansaya Bagdauletkyzy Cc: akpm@linux-foundation.org, tyhicks@linux.microsoft.com, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm: KSM: fix ksm_run data type Message-ID: References: <343394260f599d940cacc37f1dcc0309239ae220.1626371112.git.zhansayabagdaulet@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <343394260f599d940cacc37f1dcc0309239ae220.1626371112.git.zhansayabagdaulet@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 16, 2021 at 12:01:01AM +0600, Zhansaya Bagdauletkyzy wrote: > +++ b/mm/ksm.c > @@ -289,7 +289,7 @@ static int ksm_nr_node_ids = 1; > #define KSM_RUN_MERGE 1 > #define KSM_RUN_UNMERGE 2 > #define KSM_RUN_OFFLINE 4 > -static unsigned long ksm_run = KSM_RUN_STOP; > +static unsigned int ksm_run = KSM_RUN_STOP; Should this be an enum instead?