Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp620902pxv; Thu, 15 Jul 2021 11:44:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx071ncXe0tNVUsQ5yBZNk3ENlJO5QIhSuy0h5RCpMy/L6gJI/R2PhRvukAEVyrr67+K5FB X-Received: by 2002:a92:7c10:: with SMTP id x16mr3592774ilc.192.1626374680710; Thu, 15 Jul 2021 11:44:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626374680; cv=none; d=google.com; s=arc-20160816; b=jSJGSo0oV//y015FlIc4+YtzuBzQF+4vdAaiOVPlPXN94o4NXPSmJCGSv5RYZXPHhM JaghqwaE+aTK/gucoNNsliZvgsZ5trH5pbtP6mG/Ko3QC/w5CUKI95oH9CcYkxBgptd5 3FAE4mpMsY+kYmrEGIpcUgbfc1K2BdpMEFKSqXCKnOcMQK/Lkfr6CqIFGSwJj09RSCaB DQdC7ALykzQFC/XqlOfDS1foewmMPRQET290QyNwTzfVNTiOj8OurkgefZwqU4+l3hu6 1Mq+XOMj7XLPfuGbc+xdlzTd7qmE+9IU3F+zHKXZeoNboCTO8FDjHty2WiPWeGiAKdhG +RXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=O0tvA7iBib/PP3biJD8ca3gMprD8Du0Q2RI/m9rYruQ=; b=EFkNsPruQ59bAQgCT2E4Yd/w124Gw5hPWYCmeKD1LNAL/E8wKEpIe90OlPmPWo8poE SxJ2l3s6QMdXtzTrbbaerm1zklcp/O26nD3cU5ji6Fw/NrwMGuNY7ne32fvd/Y8/C8rz RvFpScq4Qze7IL/uSvNb+rrQJh3muW0j3Qln7g1dwm/1esvJv6QKNT4uTPf0uTbZATCi /kCd6pi0e0TsuctiTyJ+yGUdH3XJVOAecC4tc31XvDdyrY2Zifay96/JBx6a7R1d9pCc QalfPCQPreKN1Q22gz9j5+UCurvtzCVvF5V/W7zLRy3WEmsHSzZA6JMSmgtBpVRoUVFR 2kHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=DoUHVaaE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r15si7623630jap.43.2021.07.15.11.44.27; Thu, 15 Jul 2021 11:44:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=DoUHVaaE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237206AbhGOSpp (ORCPT + 99 others); Thu, 15 Jul 2021 14:45:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:45802 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235738AbhGOSpP (ORCPT ); Thu, 15 Jul 2021 14:45:15 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 82DED613D1; Thu, 15 Jul 2021 18:42:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626374542; bh=THJPcmkfH78OpzqAj5LeSvs8Vk5FqCJ8OEAfz0IuGEg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DoUHVaaE7T1nh0E004M5H2ST+ZpPFxORkj1CRnQto235TqBgXa28ki5drkaRgsaHt iUch92D8hKmj9wqROoosrwU5Ac2+IXAH1O190GxpXq/n72JZaegit1UNyllqIZMvyy fh6Oadq2b4R26v7cEW0qhOQb/8coyw2M2Acu1/28= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Liwei Song , Tony Brelinski , Tony Nguyen , Sasha Levin Subject: [PATCH 5.4 026/122] ice: set the value of global config lock timeout longer Date: Thu, 15 Jul 2021 20:37:53 +0200 Message-Id: <20210715182455.715995230@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210715182448.393443551@linuxfoundation.org> References: <20210715182448.393443551@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Liwei Song [ Upstream commit fb3612840d4f587a0af9511a11d7989d1fa48206 ] It may need hold Global Config Lock a longer time when download DDP package file, extend the timeout value to 5000ms to ensure that download can be finished before other AQ command got time to run, this will fix the issue below when probe the device, 5000ms is a test value that work with both Backplane and BreakoutCable NVM image: ice 0000:f4:00.0: VSI 12 failed lan queue config, error ICE_ERR_CFG ice 0000:f4:00.0: Failed to delete VSI 12 in FW - error: ICE_ERR_AQ_TIMEOUT ice 0000:f4:00.0: probe failed due to setup PF switch: -12 ice: probe of 0000:f4:00.0 failed with error -12 Signed-off-by: Liwei Song Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/ice/ice_type.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ice/ice_type.h b/drivers/net/ethernet/intel/ice/ice_type.h index 6667d17a4206..0b2e657b96eb 100644 --- a/drivers/net/ethernet/intel/ice/ice_type.h +++ b/drivers/net/ethernet/intel/ice/ice_type.h @@ -48,7 +48,7 @@ enum ice_aq_res_ids { /* FW update timeout definitions are in milliseconds */ #define ICE_NVM_TIMEOUT 180000 #define ICE_CHANGE_LOCK_TIMEOUT 1000 -#define ICE_GLOBAL_CFG_LOCK_TIMEOUT 3000 +#define ICE_GLOBAL_CFG_LOCK_TIMEOUT 5000 enum ice_aq_res_access_type { ICE_RES_READ = 1, -- 2.30.2