Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp627514pxv; Thu, 15 Jul 2021 11:54:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy13bRDpRiaEuu9Nf4KGEmlat6onIxdC2i766T4EaOm0m/DaslwBes4267gAYiOg/4PEwxN X-Received: by 2002:a6b:7b44:: with SMTP id m4mr4244544iop.72.1626375291635; Thu, 15 Jul 2021 11:54:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626375291; cv=none; d=google.com; s=arc-20160816; b=q/Vg8rWir8DWpEkGyqhgKhXjpIjKDOMBqkDlHUSodpckfiMisrUzQvqbtMTZrpymPP JvPxJaUSBCOA3ARDfXBNQtP0cSbTQMdHUAU3J++rvq4Uoj/mGfmpmWoURZdMFXZzcuYh N4tIpnzI9Afk0W7k7YRs5GpGyet9oomKsgNvUmKy9KsJhk7+EBXUG76zGbfJd91UZphR x2/kZc6a6LhbBhYkjEs4doNx3paWVDxlhyRCLduDcNvBFl7iFXMwGIRnaTvkJfrVFJXg hnYUzpFgp6mNtv7ZqjMdOyBTLX+IHbfLJayDnWJtst5HNWCEPEPfdN5bHx0okH4xy6pd Xhrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=CPk0CIQxmFm9Q8IpmwliCb4CK3WsMbX+UpIY04aWJKg=; b=HJrWQgMQEilGQ2VU3E0jU0xraQlsjky/KEV41nDKA+MJ8wBynRCFZExQWv+vwAF91Y Y2gT06/Fh9SKBseTgYt9SlNP4c0x2Fx/3CPsx+XOt6yCbVy4UkXgWoRzG20dGAszMbrB xtG/Ong9SiOgt8MbL7GLWMWc+qJC4Yc5LP1wmR39658V/hQPsKbrA+4NrTjW3j2vAJBA MQuZ94FxGHfmSyCSQwsKWBd8zAfwcWyqhLH9y7faCxedD1SXhc2x5tOZG5ocOG0c/dBa jYZFM4tQzf7487fUHA/1szkvDObyyx0DMZIARwU2/hvEmyT27v/flSgmCf8937uBaSDh HL0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=fryMttX3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t11si8324623ilu.68.2021.07.15.11.54.38; Thu, 15 Jul 2021 11:54:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=fryMttX3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231390AbhGOS4t (ORCPT + 99 others); Thu, 15 Jul 2021 14:56:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:53770 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236817AbhGOSv3 (ORCPT ); Thu, 15 Jul 2021 14:51:29 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2A285613ED; Thu, 15 Jul 2021 18:48:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626374910; bh=gQvJRFM6NdQV4GzQ2npWN1NIBM9y32kxi3ccaS/EeTw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fryMttX3gHB4EY6FnNqQsVgRpfOvjxFPLce3WiwcwdexmnQVsKGlDRq5TbcG8KVSh 65uTyByTgwIsmOS50J6GfRctuHxiqke9iNn9M7YIM80qHfCYVvdXeg2kHcZ0gZ157m 2zjhilhMeuLnaP8lyRauy8hTxH15JSpyRCn9CJ20= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mikulas Patocka , Mike Snitzer , Sasha Levin Subject: [PATCH 5.10 078/215] dm writecache: commit just one block, not a full page Date: Thu, 15 Jul 2021 20:37:30 +0200 Message-Id: <20210715182613.261923973@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210715182558.381078833@linuxfoundation.org> References: <20210715182558.381078833@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mikulas Patocka [ Upstream commit 991bd8d7bc78966b4dc427b53a144f276bffcd52 ] Some architectures have pages larger than 4k and committing a full page causes needless overhead. Fix this by writing a single block when committing the superblock. Signed-off-by: Mikulas Patocka Signed-off-by: Mike Snitzer Signed-off-by: Sasha Levin --- drivers/md/dm-writecache.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/md/dm-writecache.c b/drivers/md/dm-writecache.c index 64c2980aaa54..894b58bbe56e 100644 --- a/drivers/md/dm-writecache.c +++ b/drivers/md/dm-writecache.c @@ -532,11 +532,7 @@ static void ssd_commit_superblock(struct dm_writecache *wc) region.bdev = wc->ssd_dev->bdev; region.sector = 0; - region.count = PAGE_SIZE >> SECTOR_SHIFT; - - if (unlikely(region.sector + region.count > wc->metadata_sectors)) - region.count = wc->metadata_sectors - region.sector; - + region.count = wc->block_size >> SECTOR_SHIFT; region.sector += wc->start_sector; req.bi_op = REQ_OP_WRITE; -- 2.30.2