Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp627576pxv; Thu, 15 Jul 2021 11:54:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzEaHJzNutKWrHXFcl0DTbfjaXtbKKBA/a3ZsUSDCk/yiwiQ3Ko/wQ2ZIEUzZtq0hPLB4lp X-Received: by 2002:a6b:b5c7:: with SMTP id e190mr4376606iof.31.1626375298608; Thu, 15 Jul 2021 11:54:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626375298; cv=none; d=google.com; s=arc-20160816; b=xSx0mfqUlD7gbZJiP7dZjeoUNP+95meU8P+d2UpIWOcklBpl3V+0Je1NAENjcWiccf 5dKBc3ZIlY/5uukca7Sc5nSntGP2P0sBJS1E8TCIY6IlIkU77ollFXc6NLaOi5lUFmSB Q24559jejnzwol+xU2o+v7xmArF3XKHb4p0BS88Bl4bgMI3UcHK6fgYuOUEDBI6ilQhF c7QJY91xVtSEBJBs1wmYuLHm6lSBfTcggje3Z1hOXpo/4ioeOVPBTBSpEScpzNL+buTE qq3ACQsEg78VK67I/I3mC8Ky86doUwpyc2SGfA9RL8arg0z6/Drn4ma5x7kVAB4xshqC 9hEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=g/1hiZl2Mc9IjamLf0YEwVolxGlEnQ579LkUuOycKnU=; b=bvA1TQMkQXZzvZhrcWiOPtkeFR4fuz7UcFy8gcOvHDhNA7+weNPAdn4B3byArZdRaL V//Cj+xFz5B4dh1kVjzcmMKAgPVjoqw64cXkG0wfc8jvPbPgehktJZI9O41C7M7PXEC/ wG9Cnoc1L+Aej20HLMuea6vrxpXQRcsH9sLN2IKhO6HWtDWxSlY7mmWCBJ34IOX8hGkr EhxEf38TGXn9zj3w40bRXCbqL1od42Tc2NfKbXLzeqDMGt0RjxeAzJec02HlktNwsKGg ET90lL66Le9QsWn6amPWkvlKxm2eNcSGCe65AOREya9webbqkgUgfGBkSoOeoJQdABJX m+pA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sBqtKYqQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y1si7463886jao.99.2021.07.15.11.54.45; Thu, 15 Jul 2021 11:54:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sBqtKYqQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237826AbhGOSz6 (ORCPT + 99 others); Thu, 15 Jul 2021 14:55:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:52442 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239808AbhGOSu4 (ORCPT ); Thu, 15 Jul 2021 14:50:56 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id AD1D6613D9; Thu, 15 Jul 2021 18:47:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626374875; bh=d0xJ5IqhciSCUZX4+3tX78VLP+tSPx1jaMcPTeNp7EY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sBqtKYqQxiqiNZ3d49N1SGrqYftYAO+5gVNniGdUXpkbMFR7aLEl+GfsIproPtMIq CjSz4TgIdl3rhciEGQshej1SoOhW1wgL1EECqdcF+KRNZ7qJ5y2axUy0xu8T1uG67H GYSMJwqo+CDdrQQwgEZDDnhOHzq2tBenOhR1KmKc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Liwei Song , Tony Brelinski , Tony Nguyen , Sasha Levin Subject: [PATCH 5.10 056/215] ice: set the value of global config lock timeout longer Date: Thu, 15 Jul 2021 20:37:08 +0200 Message-Id: <20210715182609.334911033@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210715182558.381078833@linuxfoundation.org> References: <20210715182558.381078833@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Liwei Song [ Upstream commit fb3612840d4f587a0af9511a11d7989d1fa48206 ] It may need hold Global Config Lock a longer time when download DDP package file, extend the timeout value to 5000ms to ensure that download can be finished before other AQ command got time to run, this will fix the issue below when probe the device, 5000ms is a test value that work with both Backplane and BreakoutCable NVM image: ice 0000:f4:00.0: VSI 12 failed lan queue config, error ICE_ERR_CFG ice 0000:f4:00.0: Failed to delete VSI 12 in FW - error: ICE_ERR_AQ_TIMEOUT ice 0000:f4:00.0: probe failed due to setup PF switch: -12 ice: probe of 0000:f4:00.0 failed with error -12 Signed-off-by: Liwei Song Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/ice/ice_type.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ice/ice_type.h b/drivers/net/ethernet/intel/ice/ice_type.h index 1bed183d96a0..ee3497d25464 100644 --- a/drivers/net/ethernet/intel/ice/ice_type.h +++ b/drivers/net/ethernet/intel/ice/ice_type.h @@ -63,7 +63,7 @@ enum ice_aq_res_ids { /* FW update timeout definitions are in milliseconds */ #define ICE_NVM_TIMEOUT 180000 #define ICE_CHANGE_LOCK_TIMEOUT 1000 -#define ICE_GLOBAL_CFG_LOCK_TIMEOUT 3000 +#define ICE_GLOBAL_CFG_LOCK_TIMEOUT 5000 enum ice_aq_res_access_type { ICE_RES_READ = 1, -- 2.30.2