Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp627739pxv; Thu, 15 Jul 2021 11:55:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlpcUbdQFD5PLO/e2/Qc7YBy7r8uQPfQL8TuabX3f6Ddl86tIeyhwgrnC+xM6/v6GF/6vW X-Received: by 2002:a02:2b21:: with SMTP id h33mr5156378jaa.31.1626375310561; Thu, 15 Jul 2021 11:55:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626375310; cv=none; d=google.com; s=arc-20160816; b=RgtTgHhW3PXCrAvS9zPFAnir2mvjYBw9eDQMVe6fOJQyubd4kcqM+ZGJ2QmfIbCngA fDT7IFyCFfAhnwwWSLaTVHjJT+HdD4T4ummp4zUNWDTuyzIpuSG547W1T90iEFhnKp6Y SPr0LX2tbhB2pnpMff0Ec7IvCghBxMx6GJlu+kOiQwTjj0t9hTz/oD7nrOOUhUdpj9ZA CHBJOtYca/iCTr04yFLpbSxv7vJBh/FBpB51Fv4mh0+FWP+IwWvjuKcG0j71WHRuqSGz 51cg1X5FmItDl0ulaVpVIh4f0j7N8vLO+BF01vvmWuz8hbVoMheHrC+ZCs8egn1BsNG9 wUjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ZPk454G6a0Xb1s8hDz3f042Au+XiHLsx6MlXT0y23J8=; b=aImHy/RcW7x15wFpn8mqa5cQ7Wru+p1Z8aEuwJdJILhKUo6OsuMfaiXjFQF/FETawH VCknsBfuqD/UhOH03fOsgYm9kGTeN1p+nLnsPzqTexYIJQnbXxQ+JyrMiQwBz3ngZerX CjVauMSMuwRESbrJSB+lZHlfXDRgwVHbFSZm/Z+G+OD5K/wGPRl0uiFtXdUhOCiKinjR g0YbSIuPx1dg7MpRVrdpMqyYTbQReg6RYyW1sIGaNKXgJMYLs7Fxt9v8yNIs4GrHqbcX TmZWXZZdQK6muhgS/5thQJfl4H1L5szhq9YbERw6ouDuyNhRShbWOS1+CF0qsgCMOA/O RjPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=pVlWVgm6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m10si9944755ilu.53.2021.07.15.11.54.58; Thu, 15 Jul 2021 11:55:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=pVlWVgm6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241624AbhGOS4O (ORCPT + 99 others); Thu, 15 Jul 2021 14:56:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:54034 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240066AbhGOSvA (ORCPT ); Thu, 15 Jul 2021 14:51:00 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 59D34613D6; Thu, 15 Jul 2021 18:48:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626374886; bh=4wq+6xr6u201ec9VCBKH650shM95NMLWgbAR6Iwvqsg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pVlWVgm68kPNGP3LvHrJ0aKZztHVfw4wRWByU3li16dNNwCXOckF0ofmJ9Gs86/m8 KX0SU/C+1ptI8s3mnWBseQB4FaYVQgSznPnzSb7UafRGz5BITvWnXsyuOHhgbfZpsu STiq8rxZVL2r2TnkYGzXKJ9T0ZC9Q+zGmR0n4sdY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Joakim Zhang , "David S. Miller" , Sasha Levin Subject: [PATCH 5.10 069/215] net: phy: realtek: add delay to fix RXC generation issue Date: Thu, 15 Jul 2021 20:37:21 +0200 Message-Id: <20210715182611.595460325@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210715182558.381078833@linuxfoundation.org> References: <20210715182558.381078833@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joakim Zhang [ Upstream commit 6813cc8cfdaf401476e1a007cec8ae338cefa573 ] PHY will delay about 11.5ms to generate RXC clock when switching from power down to normal operation. Read/write registers would also cause RXC become unstable and stop for a while during this process. Realtek engineer suggests 15ms or more delay can workaround this issue. Signed-off-by: Joakim Zhang Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/phy/realtek.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c index 575580d3ffe0..b4879306bb8a 100644 --- a/drivers/net/phy/realtek.c +++ b/drivers/net/phy/realtek.c @@ -246,6 +246,19 @@ static int rtl8211f_config_init(struct phy_device *phydev) return 0; } +static int rtl821x_resume(struct phy_device *phydev) +{ + int ret; + + ret = genphy_resume(phydev); + if (ret < 0) + return ret; + + msleep(20); + + return 0; +} + static int rtl8211e_config_init(struct phy_device *phydev) { int ret = 0, oldpage; @@ -624,7 +637,7 @@ static struct phy_driver realtek_drvs[] = { .ack_interrupt = &rtl8211f_ack_interrupt, .config_intr = &rtl8211f_config_intr, .suspend = genphy_suspend, - .resume = genphy_resume, + .resume = rtl821x_resume, .read_page = rtl821x_read_page, .write_page = rtl821x_write_page, }, { -- 2.30.2