Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp635015pxv; Thu, 15 Jul 2021 12:05:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzPz27EFxVX3GNV9HbahxWXuMJYKRAR61dHwvVpqfkO+cU1kxM4Ock6IvxyTAcOS5YXfUpH X-Received: by 2002:a5d:9958:: with SMTP id v24mr4301797ios.4.1626375904936; Thu, 15 Jul 2021 12:05:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626375904; cv=none; d=google.com; s=arc-20160816; b=tDmDr6RGUyOWrQRBLP4Kh71uVzjjQiYw40vKwv8REqbRtYdVoGj7PzUTcKnvKnXqEn qSiEZRwAYk1ET36K624CFpYczEuOM42M2TOYiotDVQsKbhTf+edr5ZTT2NLu09xusamt L6ZLLYb6iK4OzZ/ZTJmtCEfJov8poFpqh5IU7p9ZfECcVLObCuX7tmWwb4pnrsvVBiC5 Ig7kChQI13COdAr/K75HiK5bg1aquegXJxnACOJCkWIMskOn9PH48Sx6gOlmuDcYGD8A SWfUlEX0rFc6wwGsapE4VDZ7bYIccr1tv3mhY/XQ/zW1e9dRNJ8AIptN+HRtJnvg85N6 D3iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=X6cv9DIyK1Kiyb/chNbGRBHYhe30uqQP2eSFmrIqY8w=; b=rkOclo/2DmTmJ/JuJY8HVF1tPCU8/yjTLHQHcdwRwM8/sMTAIXtRJIz3C/0PF3RaIB e8ub1zhT+8zMB3B93aBsp5wCqC6IcliMvAx2uL64yAt0ApP9DoimSis25eCD2RSlMgo/ xDyS4HqnrD9+P+lgSdRRhv5l99w3UzYNr8DSPRISFnJJiqxs5vAarCPmBZBcTGjHv+v0 970x59LkSpiHLVLMKicXG2S8x21or1PH0S2I0IXTIImvE83TVIuMPBTk29RCJaO4o1By oQ7HtgdpayPfwKeNmVD0BjZz3q3SrvrupDcdI+TgZlYjr1DSfD2lDjwzEeYkmW3i2701 nOZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=1xEdB6Wt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g14si7694244jaj.31.2021.07.15.12.04.52; Thu, 15 Jul 2021 12:05:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=1xEdB6Wt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241445AbhGOTGS (ORCPT + 99 others); Thu, 15 Jul 2021 15:06:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:32802 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241608AbhGOS4N (ORCPT ); Thu, 15 Jul 2021 14:56:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B8C13613D8; Thu, 15 Jul 2021 18:53:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626375200; bh=xC4Cywdx5k8+00hFAZiH//pamxKy7ytJ3zUtH0unhlM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1xEdB6WtAkR/CFPmHRgBaW/uJj+n7FuGjUPCjP+51B/e5WuPITMIW00p/pDfjvpdV 44Va97KZAtEe7k4KPZ6Gj2seyNRIrmS4XAV2OFkqnntb82lE8haW8anRblD4fu4N5T Ut9kvJwjjZYNI+UMa8GpKRFJFKbhnMvNp6IONBAY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+af4fa391ef18efdd5f69@syzkaller.appspotmail.com, Pavel Skripkin , Hans Verkuil , Mauro Carvalho Chehab Subject: [PATCH 5.10 203/215] media: zr364xx: fix memory leak in zr364xx_start_readpipe Date: Thu, 15 Jul 2021 20:39:35 +0200 Message-Id: <20210715182635.059466207@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210715182558.381078833@linuxfoundation.org> References: <20210715182558.381078833@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pavel Skripkin commit 0a045eac8d0427b64577a24d74bb8347c905ac65 upstream. syzbot reported memory leak in zr364xx driver. The problem was in non-freed urb in case of usb_submit_urb() fail. backtrace: [] kmalloc include/linux/slab.h:561 [inline] [] usb_alloc_urb+0x66/0xe0 drivers/usb/core/urb.c:74 [] zr364xx_start_readpipe+0x78/0x130 drivers/media/usb/zr364xx/zr364xx.c:1022 [] zr364xx_board_init drivers/media/usb/zr364xx/zr364xx.c:1383 [inline] [] zr364xx_probe+0x6a3/0x851 drivers/media/usb/zr364xx/zr364xx.c:1516 [] usb_probe_interface+0x177/0x370 drivers/usb/core/driver.c:396 [] really_probe+0x159/0x500 drivers/base/dd.c:576 Fixes: ccbf035ae5de ("V4L/DVB (12278): zr364xx: implement V4L2_CAP_STREAMING") Cc: stable@vger.kernel.org Reported-by: syzbot+af4fa391ef18efdd5f69@syzkaller.appspotmail.com Signed-off-by: Pavel Skripkin Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/usb/zr364xx/zr364xx.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/media/usb/zr364xx/zr364xx.c +++ b/drivers/media/usb/zr364xx/zr364xx.c @@ -1034,6 +1034,7 @@ static int zr364xx_start_readpipe(struct DBG("submitting URB %p\n", pipe_info->stream_urb); retval = usb_submit_urb(pipe_info->stream_urb, GFP_KERNEL); if (retval) { + usb_free_urb(pipe_info->stream_urb); printk(KERN_ERR KBUILD_MODNAME ": start read pipe failed\n"); return retval; }