Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp638710pxv; Thu, 15 Jul 2021 12:10:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJykuqAfG7JyGtYKwC2S0gJR0sRd/AjO5Rl7wNoDO8gCv6fouZ+LnAzuNdBuOjCEX9EekWYk X-Received: by 2002:a17:907:1b11:: with SMTP id mp17mr7203803ejc.1.1626376207693; Thu, 15 Jul 2021 12:10:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626376207; cv=none; d=google.com; s=arc-20160816; b=wmFASHBDTYU7dKq+oyfn01jYni3OSPwHM2t+S2iLDl4yWXejvqVUnD6kmb4eHRxWLI 1H6wVNcwi4Yb1+iK+lxut9oxtea13FahO/y5Sz0VS6zytDbxF80jw4wxHVhW202niyyn tkt/ZxYaTf/ovXIn428vADl6rdluD+YmrXZ9+W+wTnAFN8VRupMvpAxgKkx/O3n1o0+K vNwB83uqfhfXSuO4Z+SMLMSi6W7HrLdgktV4qCHmcvj5iNqXO0nPxQ/bm2ZFd7iyB3/Q 9EOIv6kgT4X4cf9hctxLTfsPYuGL6D3aBo2wyEx69r7oyWZssQt0JHuZZ9DWaIYS5VJ5 A2kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=pXHH6+URcaNvDlkEPHKNag4TDRXYcchCtzzg4pVDSBk=; b=jvZfuzI22yJhO7RMZTsWBkWRvJI0XaPl64DRBFm9i+cV8cTnAzlxgeiKPGsrXEBeFk vgBxjteFUFhgjVNIaKOXPfGwzwvq2DOuCWAfZ4wK8SBpP1p7/Vnyn77uDzl4qGCam+5X yl0P2fhWK3iTN9eVIX7pu0oj0nl6JU/firWCXgv4yhw8kfGwy9UWCe/GX7kU5ildkjId 8fyNFJZWnTDHeFrT+X9nSn+Zg19zPTA3hNnFnWZ2S/Cx34QTA77MzAG1Agu31k0a91eG D4J1f6stKwCWzwdCiojQsjhUoQsZxxZ2Nk1/lBpOkCR2mlpUM2vMt0Uw3NhqEf/WruY1 IsCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hqQdAYsS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 5si7890887ejh.535.2021.07.15.12.09.43; Thu, 15 Jul 2021 12:10:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hqQdAYsS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243801AbhGOTKG (ORCPT + 99 others); Thu, 15 Jul 2021 15:10:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:34984 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242361AbhGOS7i (ORCPT ); Thu, 15 Jul 2021 14:59:38 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2CDD9613F3; Thu, 15 Jul 2021 18:56:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626375384; bh=NIpmSb6xWrkUDhVx5Xar84NSlhZVImOx3vM9UEWBHus=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hqQdAYsSTN6OX32LR8JHOzkSAxCtTZZrjwP/A7ChB0g2OV4rBA/0Ke3vaEvf1Hdqg 6RDSxdoOUkuhxqE8HPjBn6BGsrpUtENVZk1ovI1CJCuTa7w1O2YxZFgWQLIYqYatSd vlpPF/lTUnI5+HpCsFRacg+yweRnGqOBDaF1Px8w= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Liwei Song , Tony Brelinski , Tony Nguyen , Sasha Levin Subject: [PATCH 5.12 062/242] ice: set the value of global config lock timeout longer Date: Thu, 15 Jul 2021 20:37:04 +0200 Message-Id: <20210715182603.415034685@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210715182551.731989182@linuxfoundation.org> References: <20210715182551.731989182@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Liwei Song [ Upstream commit fb3612840d4f587a0af9511a11d7989d1fa48206 ] It may need hold Global Config Lock a longer time when download DDP package file, extend the timeout value to 5000ms to ensure that download can be finished before other AQ command got time to run, this will fix the issue below when probe the device, 5000ms is a test value that work with both Backplane and BreakoutCable NVM image: ice 0000:f4:00.0: VSI 12 failed lan queue config, error ICE_ERR_CFG ice 0000:f4:00.0: Failed to delete VSI 12 in FW - error: ICE_ERR_AQ_TIMEOUT ice 0000:f4:00.0: probe failed due to setup PF switch: -12 ice: probe of 0000:f4:00.0 failed with error -12 Signed-off-by: Liwei Song Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/ice/ice_type.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ice/ice_type.h b/drivers/net/ethernet/intel/ice/ice_type.h index 266036b7a49a..8a90c47e337d 100644 --- a/drivers/net/ethernet/intel/ice/ice_type.h +++ b/drivers/net/ethernet/intel/ice/ice_type.h @@ -63,7 +63,7 @@ enum ice_aq_res_ids { /* FW update timeout definitions are in milliseconds */ #define ICE_NVM_TIMEOUT 180000 #define ICE_CHANGE_LOCK_TIMEOUT 1000 -#define ICE_GLOBAL_CFG_LOCK_TIMEOUT 3000 +#define ICE_GLOBAL_CFG_LOCK_TIMEOUT 5000 enum ice_aq_res_access_type { ICE_RES_READ = 1, -- 2.30.2