Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp656741pxv; Thu, 15 Jul 2021 12:39:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwqcuNLrXo0ji0xgTO8+K7H8qkiSU5yRowyCT0bkmIahBeLJCIWwkHZsQD8wPNOz29BVAm9 X-Received: by 2002:a05:6402:4d1:: with SMTP id n17mr9035743edw.337.1626377949154; Thu, 15 Jul 2021 12:39:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626377949; cv=none; d=google.com; s=arc-20160816; b=hBqC8z4IPGc4PB/MYHrWm4LOmiUEoynp3ZGPYG/qA97ym4YpueGUZult2SGOzvzwd5 lAUtDDV3eHkeFk9sOmkDTQXdDOqvTuBjAXejo1t7GumA+wqDuxNkJiWkq4DbgV8IpvLu IuPgKJIXWJ4GoW+srqyCodkgCnfDVGop+8H7wN2GOl8MOiElWvp+6NE9dsAY3J04qe9l sRAtuzs5ssZ18oSjYrnQkmAlX/tDPip2OihXCoebbYsINhs+CD5Vr7gcLNilzCSnm8Lc Y13czyq0gg32zuSg9675xBzXWarKlhHtPwKQvCeDmMge3kevZ2eD++HpO1C2kVIAsoJz aNzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=vrtYgk9yAgqk30rygjDpHzvwjym+J2/OZDO48bsgmXo=; b=KqoMNjelm/k7IDGPtteeJMm9/56ThY+Lu4QX1Y18zfbe6czw25A82UEYbiq/Ng868U USXcCRh3IDArUSIyOlsOH4WOuEpxD7gJsvmVkcUFzIzl+wXr0u14Fl8nY1vqN975cmQc WvG1RmgAvFV5ARh3KN3tUQ3lyEpf6aQURG42sq5a7o1px6CxuByMEOM0ROULQguRzkiJ 8+gbPkmsiVW4Oh3Gmlg7HLwsvOiBhs2IU/ZjK/2on1UeDrjnJPcsqiyyXEx+DQi5Es4L Wx78XJie84ueo9HFifWUAq3oWhj45bWZAakUNVQLTuL/SrlkPx3kk19IBYE6Z869u4yK nDVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=jHrZUkSO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q18si10290028edi.368.2021.07.15.12.38.43; Thu, 15 Jul 2021 12:39:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=jHrZUkSO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244335AbhGOTd2 (ORCPT + 99 others); Thu, 15 Jul 2021 15:33:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:50730 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242654AbhGOTLF (ORCPT ); Thu, 15 Jul 2021 15:11:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 695E96127C; Thu, 15 Jul 2021 19:08:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626376091; bh=bEqreD9VTjWWjfTR+aT3nMLJCs0WPTRmFE93Xib2xwQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jHrZUkSOJnCE4qaLd0lZBNrIFCJyIBqfmB5IRwKnQ7ZQu5L5A/9RqooKZ4jhCTIef JgrXaWDC9wXkV2T7LJDRmNB35PZmcctLZTsJGaeoyZEmsihkhVmq0CUyNbt/XCj57x Q1l4GuBeqH0vDXWb+AuJHN/2piKXu8K7Mn0qcZ5s= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Yang Yingliang , Alex Elder , "David S. Miller" , Sasha Levin Subject: [PATCH 5.13 116/266] net: ipa: Add missing of_node_put() in ipa_firmware_load() Date: Thu, 15 Jul 2021 20:37:51 +0200 Message-Id: <20210715182634.367245495@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210715182613.933608881@linuxfoundation.org> References: <20210715182613.933608881@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Yingliang [ Upstream commit b244163f2c45c12053cb0291c955f892e79ed8a9 ] This node pointer is returned by of_parse_phandle() with refcount incremented in this function. of_node_put() on it before exiting this function. Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Acked-by: Alex Elder Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ipa/ipa_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c index 9915603ed10b..c4ad5f20496e 100644 --- a/drivers/net/ipa/ipa_main.c +++ b/drivers/net/ipa/ipa_main.c @@ -529,6 +529,7 @@ static int ipa_firmware_load(struct device *dev) } ret = of_address_to_resource(node, 0, &res); + of_node_put(node); if (ret) { dev_err(dev, "error %d getting \"memory-region\" resource\n", ret); -- 2.30.2