Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp660159pxv; Thu, 15 Jul 2021 12:45:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyP41h/7q/AYKqGOWFo3+7e3lDUwpBkvTfPRALMT0tPu/RB0hhpyE4EDCHCQLzGqhjg6xfV X-Received: by 2002:a17:906:9b88:: with SMTP id dd8mr7105746ejc.83.1626378342314; Thu, 15 Jul 2021 12:45:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626378342; cv=none; d=google.com; s=arc-20160816; b=zM0qvq7DzbPkFfmB9WxYXi98ZDH3UpTIf6eTJQcSFR/QYHoVJG0xJYwECRgF9VarD/ kO2HDR/B80ksq2Eas56N5M3dIgxw4Dd4x5q/6T0fUgWSj3gZClvKEWBs6XFRPwuaTY+e c3D0gSJalDqXZjKpgjCO6Z7DQhfKjD9mWgTt3LjpImnorp1voN46Uk9WmOzlcE7YgRxg Ux2wwXpBYX/UQG6Q2CbLd5srMVrt1h8zcRjidI2bXGGq+15tkHMHJFytfY6fIfTEUD81 Ik3vt1Uv/OfxcZeaNpvhW9Ze1Iov+ZVBIVOQ/YgsnqAYslgj5dI6CdajJTGoG3L60S1J 3vIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=5QHLq4l/7qCxAKBU9jlRmARuPpUIYrSuMWyb1l8JLvI=; b=DMkuCC0xxlKhqtuAxrayiYVxldJzkLcQbyi30Emt7mxwi1uRsZP1rMox1cMc/D2ybe gsQDN5jrpdBiJpzgcFNIMBvSjgspkkvmujFIRcP69AIvSa3D6H7qX+aZ1BCZb6Xw0KQ/ V7Tu8ToNvE6Ho9jUQ2nU8v4ormS/2dV9X8SjMdyt+b8q2DZMTb48UIbzHo4vU5kzCYWL ApOSREuah8K1E/RYgrhQkLBB0m6AXgrG132RZMCgpyezJRCz8gX06wNFmJY9lUvkdwWo RyTWHDMW3a9v0O1XuSsHv57gl3wQd0rXcGEEvnDDqYIYQ/6rU9Nm1ssL50nmi07VHe+l Gu8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=u7IvsSsr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ga23si8809946ejc.205.2021.07.15.12.45.19; Thu, 15 Jul 2021 12:45:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=u7IvsSsr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343507AbhGOTrP (ORCPT + 99 others); Thu, 15 Jul 2021 15:47:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:51430 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244642AbhGOTQf (ORCPT ); Thu, 15 Jul 2021 15:16:35 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 16642613DA; Thu, 15 Jul 2021 19:12:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626376360; bh=kh6xMu0riarywR/8VQzC/9VScbXvZzz5mIprlgA/my0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=u7IvsSsrm/ThKW879KyfzUVGRCeFJrcX391gGDu+OTIxIk8cSxMjxIoD/QIYvjdYm 2eypMy+qnsX6tAKW72bBzSDhJSyiFSix1Vc1f8SxgD1xSsM/HHq+eTvNdLplLPemnH glD/lwrI/ovHDK0XFMfdiETwmKY2L9wtRFXeGY7A= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jeremy Linton , Mathieu Poirier Subject: [PATCH 5.13 237/266] coresight: Propagate symlink failure Date: Thu, 15 Jul 2021 20:39:52 +0200 Message-Id: <20210715182650.691908855@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210715182613.933608881@linuxfoundation.org> References: <20210715182613.933608881@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jeremy Linton commit 51dd19a7e9f8fbbb7cd92b8a357091911eae7f78 upstream. If the symlink is unable to be created, the driver goes ahead and continues device creation. Instead lets propagate the failure, and fail the probe. Link: https://lore.kernel.org/r/20210526204042.2681700-1-jeremy.linton@arm.com Fixes: 8a7365c2d418 ("coresight: Expose device connections via sysfs") Cc: stable@vger.kernel.org Signed-off-by: Jeremy Linton Signed-off-by: Mathieu Poirier Link: https://lore.kernel.org/r/20210614175901.532683-7-mathieu.poirier@linaro.org Signed-off-by: Greg Kroah-Hartman --- drivers/hwtracing/coresight/coresight-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/hwtracing/coresight/coresight-core.c +++ b/drivers/hwtracing/coresight/coresight-core.c @@ -1392,7 +1392,7 @@ static int coresight_fixup_device_conns( } } - return 0; + return ret; } static int coresight_remove_match(struct device *dev, void *data)