Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp680384pxv; Thu, 15 Jul 2021 13:18:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzV52GJwONEAIvsrX9tqfC/yE+j3z6dsOKTo/kWA1GHxTmR/o0pXlGIrGi8u33TWMGem8j1 X-Received: by 2002:a02:9582:: with SMTP id b2mr5570039jai.131.1626380308115; Thu, 15 Jul 2021 13:18:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626380308; cv=none; d=google.com; s=arc-20160816; b=bNW1Uh/VvZF5tM4p0Zkn6NNVYo4oDSp760KInN8iQw3NBFl0peiTiX2XUamXTBGtlY bPX+4wmjYn23Us0o/WSjBt3YvuOwOovMF0ZLlAd4AIt5d5NZj6ATEwMrPGj/QjS6z/Oe r1Z7czcXSq4lb2i4ZYu7dDApdKN+xhmgStlWMKSeFX5xppMhjP0H6vd/LAf+y5oS+BMd Wc7oTasXi7mWDb+Y+Z64tqD0TqKpKXQfkeopDHbBErnhCkF0ofHStX3m7yo7iYcXqqPx Uqi9cYFhYTHzrV9kmFCmIAndExqF1Y/Z+2xoH0QIIJdT6P0zRHLWqLx8Mkq/WfQxP/C/ 7IVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=TlkC2X960t2EN/CZQ9J+R9eQf4JoaOaAVaibAmcHcE8=; b=B5UOaS4/qtGuU+0cCpVbFFjSDp8TeTBaaP0zuYANLcXThnANB9lOiHrSzT+fzb0qMq 9YOwkAC8pEQ0+P+IJlQZf6HRkB+4vQZSDjazv6euffwUX5zPwTvS30U2+lUxX4tpX9Ky AdhrUJhpb8c/VZPg3TFNplFykWgELhEzCYSCLhYhdn457pCVpol5plj//ydKN1B1Irj1 khNwGq3z01e0aGP/pZ5ZdKpTNgi5xYj4Y67/BuNj3+YNyB4ZFlIdZ4yn7plUVOpanfUa D87iDdQqLB2PY7700W1SPYbKOiIXhE08GgVOJZW+RvMDhLW83/GHIY9C5kQU0IgX/S78 XcDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FePoKYOV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y7si7719033jap.7.2021.07.15.13.18.16; Thu, 15 Jul 2021 13:18:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FePoKYOV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245450AbhGOUTf (ORCPT + 99 others); Thu, 15 Jul 2021 16:19:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:59614 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245153AbhGOUTO (ORCPT ); Thu, 15 Jul 2021 16:19:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626380179; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TlkC2X960t2EN/CZQ9J+R9eQf4JoaOaAVaibAmcHcE8=; b=FePoKYOVBcK5pQ3mrMzKnipatn3I5AYCkMPdt7AGOxnbjBOJfXqfPkvo5THW++wIUSU81m 8Cg/ukui2GIZ/pAAqaTHgWknIlMWfGyx395U23uQi8bRGOPzU3I2aWVtQmieiYnXMfidfY OXwLPRTi8VKYwThfhYtQXdoUrqCAuQA= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-465-jNYB_cd2MNekqFJvDosmpw-1; Thu, 15 Jul 2021 16:16:18 -0400 X-MC-Unique: jNYB_cd2MNekqFJvDosmpw-1 Received: by mail-qk1-f199.google.com with SMTP id u9-20020a05620a0229b02903b8eff05707so647879qkm.5 for ; Thu, 15 Jul 2021 13:16:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TlkC2X960t2EN/CZQ9J+R9eQf4JoaOaAVaibAmcHcE8=; b=CboPxT79RSUVd7IAlhELFoLcQc4X+kZUARGOZyRV7nHH0kHxL3y5qt7CmpXI5VtRGG InfZLMnbXvf2w1SA4CQt1vcT8s5kyr+eeUBmxXFdINLt/81k6c2nKYt9CEdnSO2uwBDU IKn6ZtbhJC2s+vaoLrmKjty2PeZQ42kaIvSr7vlUMUxpIiuPAq59c/rMTVvZ8orRnQqn BR/ur28nmf1AvEvc9e5murbUwWKTbrv5dEievvqDCzilGVNFymqU/j0ykwq9TvygBlHs 5uEH7q3NB/uuukflJAuPwOWPaEU5uNe1q2PKJC0cKB3wdwhk51ayzY+SSU4jAauIsA81 aS+g== X-Gm-Message-State: AOAM533jQDg6SBlrJ/32kyOemzqftkb6zkytH9wYIwOqa0AH/2RaVqQP 8OBfLxbguhDrMmI+9kKHdpSQiuBKlneUo7qEvdZG03l7lJXHAIwDbERJKJWCIOOemT7xgZ4N/IO fsMhiBdpWHsW/VweYD4XpWNChRm4IFoswCNIqlq+1Obu+cIyj76PDlzEw30TCzATeHmP8QQ44BQ == X-Received: by 2002:a05:620a:1a08:: with SMTP id bk8mr5868653qkb.158.1626380177828; Thu, 15 Jul 2021 13:16:17 -0700 (PDT) X-Received: by 2002:a05:620a:1a08:: with SMTP id bk8mr5868618qkb.158.1626380177566; Thu, 15 Jul 2021 13:16:17 -0700 (PDT) Received: from localhost.localdomain (bras-base-toroon474qw-grc-65-184-144-111-238.dsl.bell.ca. [184.144.111.238]) by smtp.gmail.com with ESMTPSA id i21sm2980326qkl.20.2021.07.15.13.16.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jul 2021 13:16:17 -0700 (PDT) From: Peter Xu To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Axel Rasmussen , Nadav Amit , Jerome Glisse , "Kirill A . Shutemov" , Jason Gunthorpe , Alistair Popple , Andrew Morton , David Hildenbrand , peterx@redhat.com, Andrea Arcangeli , Matthew Wilcox , Mike Kravetz , Tiberiu Georgescu , Hugh Dickins , Miaohe Lin , Mike Rapoport Subject: [PATCH v5 15/26] mm/hugetlb: Drop __unmap_hugepage_range definition from hugetlb.h Date: Thu, 15 Jul 2021 16:16:14 -0400 Message-Id: <20210715201614.211661-1-peterx@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210715201422.211004-1-peterx@redhat.com> References: <20210715201422.211004-1-peterx@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Drop it in the header since it's only used in hugetlb.c. Suggested-by: Mike Kravetz Signed-off-by: Peter Xu --- include/linux/hugetlb.h | 10 ---------- mm/hugetlb.c | 6 +++--- 2 files changed, 3 insertions(+), 13 deletions(-) diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h index f7ca1a3870ea..c30f39815e13 100644 --- a/include/linux/hugetlb.h +++ b/include/linux/hugetlb.h @@ -143,9 +143,6 @@ void __unmap_hugepage_range_final(struct mmu_gather *tlb, struct vm_area_struct *vma, unsigned long start, unsigned long end, struct page *ref_page); -void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma, - unsigned long start, unsigned long end, - struct page *ref_page); void hugetlb_report_meminfo(struct seq_file *); int hugetlb_report_node_meminfo(char *buf, int len, int nid); void hugetlb_show_meminfo(void); @@ -385,13 +382,6 @@ static inline void __unmap_hugepage_range_final(struct mmu_gather *tlb, BUG(); } -static inline void __unmap_hugepage_range(struct mmu_gather *tlb, - struct vm_area_struct *vma, unsigned long start, - unsigned long end, struct page *ref_page) -{ - BUG(); -} - static inline vm_fault_t hugetlb_fault(struct mm_struct *mm, struct vm_area_struct *vma, unsigned long address, unsigned int flags) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 924553aa8f78..4bdd637b0c29 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -4331,9 +4331,9 @@ int copy_hugetlb_page_range(struct mm_struct *dst, struct mm_struct *src, return ret; } -void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma, - unsigned long start, unsigned long end, - struct page *ref_page) +static void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma, + unsigned long start, unsigned long end, + struct page *ref_page) { struct mm_struct *mm = vma->vm_mm; unsigned long address; -- 2.31.1