Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp684066pxv; Thu, 15 Jul 2021 13:24:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz0P1xvu8yHjKxD6usumDwnsg/HSqo+6EDr10MXmBB7tXHtIhFF26NHD+Eb03SWJ1KEfgw+ X-Received: by 2002:a05:6638:d51:: with SMTP id d17mr5705502jak.109.1626380674434; Thu, 15 Jul 2021 13:24:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626380674; cv=none; d=google.com; s=arc-20160816; b=waURSPZ43RppCjIFnb7mfYsFYcjtQ/GvHaKlD3CFRvNvoR54HHN7zhqzZnyrgMjZRU xeXxzBh/se7pOUahuFIM5WjoG/dHIqi9Q7fVokbboinPRMiQh/5Nk6FyBh6rCDcG1obZ JWdS+9NZ58k9dJmLVf5oiqDpWP+5jkki082g1seiF+gf0GTcpAKZ7QkNTzvLl/75uwev Evgyf03b83PcSq3twfmjzK1XC382HJv7npRWCg+pc7wNs+/nB3KQ2kUd5sfuDBeJbdnj AnFpS5CUHtulryYZQj7R1iXZy7QBJBQNP7BUP1zz8xCZ8yXn0e+XBJ8ayYlT1T7x5qlN g8zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=ixur1kT6q2L39lVn6OXUbS7dWhX7OKvKjb1djFVXLmc=; b=B0/DT30J39fGJXuuULmQNmjRt17nN2YdP8uOnDAjBnIP+GvgfNHRkBvRHbdchNFXYe 03XVJ2Lx5Ad9LwQ+OMOg7c4XvGNLb94I+vXSmn3veYJH6hqUhW/dLqf7/fkgF04whiYz eP5KVAqLMvSLRrbu0E66k0SpZJMvgutNW8+ZGKEkYf3T+APYltMaHZ4eyitRo6RaK0xP FKuyhdKl7Kbzk/BqPVmma8csE09P2TCAB4r9KyOu3ojU3bw10FxJJFrzKH32msT1S/PL R+9WdVto4vztenm1H/h0nDVHFQTa2A5dxK7eQqbFzUNFj8IL5u9nI1TRFHrIY7G910pf BUnQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y13si564579ilu.34.2021.07.15.13.24.20; Thu, 15 Jul 2021 13:24:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229937AbhGOU0k (ORCPT + 99 others); Thu, 15 Jul 2021 16:26:40 -0400 Received: from mail-pl1-f169.google.com ([209.85.214.169]:38744 "EHLO mail-pl1-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229531AbhGOU0j (ORCPT ); Thu, 15 Jul 2021 16:26:39 -0400 Received: by mail-pl1-f169.google.com with SMTP id u3so4026661plf.5; Thu, 15 Jul 2021 13:23:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ixur1kT6q2L39lVn6OXUbS7dWhX7OKvKjb1djFVXLmc=; b=rsqdmI7Y2OoYqmxcLgbs1K11qAkf9BxE8/mpb65/QkE10buXZTn//bUTHfcbf2Idf9 3NkiV5aalCOIXFHrEweQew991BNOlJR6eS4hhZ/658CaS7bf5p9LLB8TtIF8NpJlRGD3 zGjJbcVPsBfBcc7pDH6OGtHEzi5g45NJ1pvhhxtNGcDhOD0wI/+fFgZIGXP4085KUHRz PZq7AaJrVrzF23H8ePiJwla83A0HQLX4CVNaGX0cDRYhJmZLg2oJ/akRG0LXXhUvudf/ qxBPFPD78iw+zJ/WR+hr/ZypfBKNKewSH/qD1E3QWfJabHULQieHzesZREtL6u/JbNWV yvKA== X-Gm-Message-State: AOAM532J/9EC3CTDjaITOGFWlwZFij64lfnB71ogCmctnn8fhdTyOM5d jcrJceE63aW7KBBOcbUJqnE= X-Received: by 2002:a17:90a:8c8f:: with SMTP id b15mr5819724pjo.201.1626380625125; Thu, 15 Jul 2021 13:23:45 -0700 (PDT) Received: from localhost ([191.96.120.37]) by smtp.gmail.com with ESMTPSA id mu9sm8471367pjb.26.2021.07.15.13.23.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Jul 2021 13:23:44 -0700 (PDT) From: Luis Chamberlain To: axboe@kernel.dk Cc: hare@suse.de, bvanassche@acm.org, ming.lei@redhat.com, hch@infradead.org, jack@suse.cz, osandov@fb.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain Subject: [RFC 0/6] block: enhance use of GENHD_FL_UP Date: Thu, 15 Jul 2021 13:23:35 -0700 Message-Id: <20210715202341.2016612-1-mcgrof@kernel.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is the second group of patches which I'd like some review on as part of the *add_disk*() error handling conversion. While converting drivers to add error handling, I noticed some were using the flag GENHD_FL_UP to see if a block device is ready, or for bringing a device down, so to call del_gendisk() safely. This first group of patches just address the few areas where the flag is used directly. Direct use of the flag GENHD_FL_UP is useful but incorrect as we can add the flag in a gendisk left half built. Instead, add a flag to actually represent the desired goal. The next group will deal with the use of the flag for del_gendisk(). Luis Chamberlain (6): genhd: update docs for GENHD_FL_UP block: add flag for add_disk() completion notation md: replace GENHD_FL_UP with GENHD_FL_DISK_ADDED on is_mddev_broken() mmc/core/block: replace GENHD_FL_UP with GENHD_FL_DISK_ADDED nvme: replace GENHD_FL_UP with GENHD_FL_DISK_ADDED fs/block_dev: replace GENHD_FL_UP with GENHD_FL_DISK_ADDED block/genhd.c | 8 ++++++++ drivers/md/md.h | 2 +- drivers/mmc/core/block.c | 2 +- drivers/nvme/host/core.c | 4 ++-- drivers/nvme/host/multipath.c | 2 +- fs/block_dev.c | 5 +++-- include/linux/genhd.h | 13 +++++++++++-- 7 files changed, 27 insertions(+), 9 deletions(-) -- 2.27.0