Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp715655pxv; Thu, 15 Jul 2021 14:16:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw1gTqtIKixFLqk+OnVWVxEPOoIfcfAyakunRQKn5CyR+sVVp+4YencDNgUX+YsBr5rjgQz X-Received: by 2002:a17:906:c7d6:: with SMTP id dc22mr7731734ejb.517.1626383770363; Thu, 15 Jul 2021 14:16:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626383770; cv=none; d=google.com; s=arc-20160816; b=a/hiFXiLz5HwKhQsidY+tTbx7QFHBkq18SOCfqbcYStggqan1JaL2KsNYeOX4rFJly TGSEfX6VYfjcQ3EbxyOxNUIq0UVxct2PvQo3AHdx4lWzk+7ewE9pcJlxkGc7NXMpbExh /+oVno52XW7smNXB0hGGMjn0WNViHvqUA09V1H0rPHu+K87qgzN/Rgcow8CsBlabElH8 2OMFpOVEfsCIFDVrl/+5CdfCSZxhVbTpaw2mqIarD0LNbM94PgalerHsBo1wga78OwsW kixfa62MVOT1UB00DZgF6coEThie5jOwfOUrkSKtKWIFAIsu5bAt9xe7woXYtZOB5+Wx jMDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=48AZ/qhOfaMXLPR834miAP/l4Tu2tDCI53TPoFvW3ZA=; b=tXVRW6vOxAtu9NId9AVl3N1zyuBMT9Hg3XtmLrnn8w+KknRp/zCbOBjoAzclGCr5Od +/F2/VBi/yeSHUsW9e5HoIeNFnrhdePffleQgJLZrJ7EuFoDPJSTm5uq9asv4UEU5DNZ MVQM8uFkVMCSs8epwmUrKmxWZ4FeaJUUPY0HWrlUrad0tYKB3x0b98YgDNCWqREg1EvB KQBD+1FJI46Ho3MX70VHF9Z5MIkueALB8D3pc7NB1Asetq3wtLvlEMOwprAtpyQ/3WKO GOi8L1VS0A5nIyXQe42aor7Rl1JOvrIT4dQOvdOUlrMlw3EVzxQDsfYMIBigNYrRC92Z VnUw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j6si8707895edv.294.2021.07.15.14.15.47; Thu, 15 Jul 2021 14:16:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231635AbhGOVC4 (ORCPT + 99 others); Thu, 15 Jul 2021 17:02:56 -0400 Received: from mail-pf1-f180.google.com ([209.85.210.180]:35694 "EHLO mail-pf1-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231268AbhGOVCh (ORCPT ); Thu, 15 Jul 2021 17:02:37 -0400 Received: by mail-pf1-f180.google.com with SMTP id d12so6714114pfj.2; Thu, 15 Jul 2021 13:59:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=48AZ/qhOfaMXLPR834miAP/l4Tu2tDCI53TPoFvW3ZA=; b=jrH9ec8peAMO9ItQfIpaaCyvRUOUxKMKaZ8KC0dt/NuIxm6DGMN1hrcZtvoE8njICC FyctYL1OQtCyIyQ1ekaFaohJ2Xk2R9HDxhDzemm80ZUj54g0PuiJ8V+5MdTE75ZGuI+K WX4AK/SORj1DAz5QPF7K1PSnyciLRihXZwCvS2xfNIx/n7lsvDcpskTzHZifEnivYskj JOA0pWvMozPJlaa7lr82iWwffTWKmve546a91+tdqypwI5zQ9ZMH/jjMhbSKOaFS7fnp GQCq3C6DW3UENekZfmANUVe7baE+tlkPfS1mba6N++fqGo3gvAedX5LHKoVtORWgu8se +70w== X-Gm-Message-State: AOAM531M9czb7ZrxZgoB1nsMMPXGhgbotqFnF731aNMhfNQIJbK5uz4B Toke2EofKdjesx1SdeywaZ0= X-Received: by 2002:a63:1a12:: with SMTP id a18mr6382582pga.269.1626382782644; Thu, 15 Jul 2021 13:59:42 -0700 (PDT) Received: from localhost ([191.96.120.37]) by smtp.gmail.com with ESMTPSA id i8sm10056563pjh.36.2021.07.15.13.59.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Jul 2021 13:59:41 -0700 (PDT) From: Luis Chamberlain To: axboe@kernel.dk Cc: hare@suse.de, bvanassche@acm.org, ming.lei@redhat.com, hch@infradead.org, jack@suse.cz, osandov@fb.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain Subject: [RFC 06/12] scsi/sr: use blk_cleanup_disk() instead of put_disk() Date: Thu, 15 Jul 2021 13:59:14 -0700 Message-Id: <20210715205920.2023980-7-mcgrof@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210715205920.2023980-1-mcgrof@kernel.org> References: <20210715205920.2023980-1-mcgrof@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The single put_disk() is useful if you know you're not doing a cleanup after add_disk(), but since we want to add support for that, just use the normal form of blk_cleanup_disk() to cleanup the queue and put the disk. Signed-off-by: Luis Chamberlain --- drivers/scsi/sr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c index 94c254e9012e..362f04a3761a 100644 --- a/drivers/scsi/sr.c +++ b/drivers/scsi/sr.c @@ -789,7 +789,7 @@ static int sr_probe(struct device *dev) clear_bit(minor, sr_index_bits); spin_unlock(&sr_index_lock); fail_put: - put_disk(disk); + blk_cleanup_disk(disk); mutex_destroy(&cd->lock); fail_free: kfree(cd); -- 2.27.0