Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp715659pxv; Thu, 15 Jul 2021 14:16:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwE8BKAZPHWUmRSrRI0lzK9m45Q681yiVfY2+iRxlGJp/YV7c6UsHqtGXp/hS2fK4ZqbfxW X-Received: by 2002:a05:6402:49a:: with SMTP id k26mr9740842edv.279.1626383770872; Thu, 15 Jul 2021 14:16:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626383770; cv=none; d=google.com; s=arc-20160816; b=sVYXpRR3i/oHxA5/ixkzLPoUZRPDpcTRnuWl+E0J9bZbiphPMN097suC2xG/o8EyRH uSZtxEKMtO1craJ57ie2jHaHjX/ZZ071bdGOHCm3gP7M2BcewkCmk4zPUI2i4yKSzHDi tghohDg6sUW86sADcBdZvYazGQC1TquhWAqWKMLZ6zMP/t29y4wMDKd4gNZmRMBNuaPE kPeUeQ1r0CyED7n/08KQlUI/3IVn/wlGC4wvGpPUagOihcv/a+lVDQtDT4IHSl/zpZun FU/PihRmFOlP+noCq4Ika1K9+busmhmT+nbOGBzXg4bcsqj8F7hJwTqWP2tVLoY9CF9k F1oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=a39bZow5r39OJmiFj2JiMLEBL8HqNlxVqiTVg5TlV8s=; b=Lu196xHcobK79Sap3y2kz+3XFjsXwC9vd4Q1OUECl24zPSqEZpFLobt7wFt+5EWnpf G/v0y//JXO/Najv/2B52uurNkkmeoUzb67tp4Z7zMeLXl9E0ZAg52dIkc1NpcBLYnkwn udgevtSwRNosgo6gS1pSt6EoebzU1SQ3vNDc8C1MSPY0lWCd/D1luVcA0DJwMzCdfRv7 83pLJfvh4uos8vbSzo3i/7AHPyjXZsLLZjOcZ4Yi5jXI+k694svSzDFIp0wn5i8NB650 sU6ldkGgcIx0qbsSgHYQkmOjLnHgcA4HP0eP2gtHwYeR4uWLLpnyt/kvxvRdtt3nmF51 w23g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h9si8440072ejk.653.2021.07.15.14.15.47; Thu, 15 Jul 2021 14:16:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231298AbhGOVCh (ORCPT + 99 others); Thu, 15 Jul 2021 17:02:37 -0400 Received: from mail-pf1-f174.google.com ([209.85.210.174]:36367 "EHLO mail-pf1-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230242AbhGOVCb (ORCPT ); Thu, 15 Jul 2021 17:02:31 -0400 Received: by mail-pf1-f174.google.com with SMTP id 21so6705729pfp.3; Thu, 15 Jul 2021 13:59:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=a39bZow5r39OJmiFj2JiMLEBL8HqNlxVqiTVg5TlV8s=; b=dFKsRfJyeUAzu6jDw49I+gJbIO8+VANQ4203xKuiEg0BRQafhKK2CDLOIoIHYdE7gG xxgsNrBOvjvRxGfYcYtqrcMn3aRZmEtA29AmAW2TYkZqz//ttJuTtS2bSZa8YDaIMnbb 50DqrvqfSTQeMuc30hzFThD/RIKBl8CjzLVU13vxJwftaEON6VA5Pug8Z23OPKTvRCga ihpXmjqmn4NJvFr399gRtGJbfIkFpgEJCbzgGee74XOD3D8RF0O4iqfcFf6xAeY3mtRs xWRDte562L0UlHLar1Vrb4aon3ODP/pSdYYvNvbJCm5n0KE1mzvJNGkQowo7pzWBBFnF 9hEw== X-Gm-Message-State: AOAM532ySpU/QkbLVP4v7sf6Eyu2KTQRtmTGMwNBPOSCn2VsRDcC1LnU sFVRE83HMqWNP8AGRJLLlEY= X-Received: by 2002:a62:6c4:0:b029:324:8262:b3aa with SMTP id 187-20020a6206c40000b02903248262b3aamr6479424pfg.25.1626382777712; Thu, 15 Jul 2021 13:59:37 -0700 (PDT) Received: from localhost ([191.96.120.37]) by smtp.gmail.com with ESMTPSA id v9sm7418946pfn.22.2021.07.15.13.59.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Jul 2021 13:59:36 -0700 (PDT) From: Luis Chamberlain To: axboe@kernel.dk Cc: hare@suse.de, bvanassche@acm.org, ming.lei@redhat.com, hch@infradead.org, jack@suse.cz, osandov@fb.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain Subject: [RFC 04/12] scsi/sd: use blk_cleanup_queue() insted of put_disk() Date: Thu, 15 Jul 2021 13:59:12 -0700 Message-Id: <20210715205920.2023980-5-mcgrof@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210715205920.2023980-1-mcgrof@kernel.org> References: <20210715205920.2023980-1-mcgrof@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The single put_disk() is useful if you know you're not doing a cleanup after add_disk(), but since we want to add support for that, just use the normal form of blk_cleanup_disk() to cleanup the queue and put the disk. Signed-off-by: Luis Chamberlain --- drivers/scsi/sd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 6d2d63629a90..6d0a82da7131 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -3510,7 +3510,7 @@ static int sd_probe(struct device *dev) out_free_index: ida_free(&sd_index_ida, index); out_put: - put_disk(gd); + blk_cleanup_disk(gd); out_free: sd_zbc_release_disk(sdkp); kfree(sdkp); -- 2.27.0