Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp770201pxv; Thu, 15 Jul 2021 15:51:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyGgg1manY/Ya+crMHshw6WFOMMcuQr2E09ScMmhaDJkRg6c7B+YRy1PmkY3we2gBTP3MZY X-Received: by 2002:a5d:8456:: with SMTP id w22mr5030361ior.63.1626389474689; Thu, 15 Jul 2021 15:51:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626389474; cv=none; d=google.com; s=arc-20160816; b=0tUDca3VSjK8+q4XBEivT5l+ssiTlb2ThtzrbiJiskM5nY38c5VchH142ktIbM6Nms HBftRH1TuxOr57RZLUqAEb0YA+/zQ43rNFE7fvr18+faJp3snJpAw4n3vMW3yaznazvd PZdYQ74vrrSivnW2gsU/mFKedg3wSBAzePcwLhMOa5XFmMy/rRMg6qcz3DrCtTjEJ4rR XDSAO3ypp8nbs7NzGqtrRF0p6hkZKci8K8iyoN4wor+/oRaWsdVvcvkqUuz9z4NP0PJk YyHm+INASHVdHSh6nsD81ZILRJdCM1kHfYABI36YhZ9WB1o+iILKFLmxHtjid3+btcul wRQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=yneawEyY6xDNaWfvtVbK7e/rjzJ7KGfPCAW0iKNpPI4=; b=LENCB+L03f3ZYCEw00uSpUlsGlbQ3sWeq52DkK6utyRIKUdJKd7RS/V+jXTla5VmBV ySa1SNkaWVYoUQr99rqgWD0Wae2x3HPbHoWDCK9VPLngA5EFl2L9vysk8iRZalg0zkqY yD4cGphC/iJTGTvOAXpylHnWyBL2eYvSH+ZtesfdbeKSxUHSQAOTZ7BEpa5BZTlRrtKX PMWwb8DXxRdcscMta2CSIaEIvGkKu3p2ZdKkAyDkPtlry7D6rnZZw5zhR7tVJ9sBvLcr MDBAralOsNO3zg0rRbWIDTVdJOcrXSZhyttcERSk65QfDC0NfFG/L7o1QCQxPYHOx5Qa 0Usg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a9si7933434ilr.103.2021.07.15.15.51.01; Thu, 15 Jul 2021 15:51:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231548AbhGOWxU (ORCPT + 99 others); Thu, 15 Jul 2021 18:53:20 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:47957 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbhGOWxT (ORCPT ); Thu, 15 Jul 2021 18:53:19 -0400 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 1AD8B60002; Thu, 15 Jul 2021 22:50:21 +0000 (UTC) From: Miquel Raynal To: Colin King , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Heiko Schocher , linux-mtd@lists.infradead.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: devices: mchp48l640: Fix memory leak on cmd Date: Fri, 16 Jul 2021 00:50:21 +0200 Message-Id: <20210715225021.65858-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210712145214.101377-1-colin.king@canonical.com> References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: b'ba356289261975ff061580ff30d1026448b9ffd2' Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2021-07-12 at 14:52:14 UTC, Colin King wrote: > From: Colin Ian King > > The allocation for cmd is not being kfree'd on the return leading to > a memory leak. Fix this by kfree'ing it. > > Addresses-Coverity: ("Resource leak") > Fixes: 88d125026753 ("mtd: devices: add support for microchip 48l640 EERAM") > Signed-off-by: Colin Ian King Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks. Miquel