Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 16 Jul 2021 01:00:28 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
Cc:     Christoph Hellwig <hch@lst.de>, Hillf Danton <hdanton@sina.com>,
        syzbot <syzbot+118992efda475c16dfb0@syzkaller.appspotmail.com>,
        axboe@kernel.dk, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] possible deadlock in loop_add
Message-ID: <20210716010028.4218b0de@xps13>
In-Reply-To: <c3d4ebd5-5679-cd81-d1de-4f5f2cbe13db@gmail.com>
References: <000000000000ec01e405c6c2cee3@google.com>
        <20210710131638.605-1-hdanton@sina.com>
        <20210712052740.GA8599@lst.de>
        <c3d4ebd5-5679-cd81-d1de-4f5f2cbe13db@gmail.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hello,

Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com> wrote on Mon, 12 Jul
2021 16:29:16 +0800:

> On 12/7/21 1:27 pm, Christoph Hellwig wrote:
> > On Sat, Jul 10, 2021 at 09:16:38PM +0800, Hillf Danton wrote:  
> >> To break the lock chain, un/register blkdev without mtd_table_mutex held.  
> > 
> > Yes, Desmond Cheong Zhi Xi sent pretty much the same patch on June 18th
> > (mtd: break circular locks in register_mtd_blktrans), but it did not get
> > picked up.
> >   
> 
> I believe Miquèl was waiting for -rc1 to apply it.

Indeed, I already applied it but did not advertise yet.

> 
> But taking a closer look, although the fix for the register path is the same, Hillf Danton's proposed patch additionally avoids inverting the lock hierarchy on the unregister path. So I believe this new patch should be more robust.

We can definitely do this in two steps if you want.

Thanks,
Miquèl