Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 10/12] ASoC: amd: add vangogh pci driver pm ops
To:     Mark Brown <broonie@kernel.org>
Cc:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        alsa-devel@alsa-project.org, Sunil-kumar.Dommati@amd.com,
        Liam Girdwood <lgirdwood@gmail.com>,
        open list <linux-kernel@vger.kernel.org>,
        Takashi Iwai <tiwai@suse.com>, Alexander.Deucher@amd.com
References: <20210707055623.27371-1-vijendar.mukunda@amd.com>
 <20210707055623.27371-11-vijendar.mukunda@amd.com>
 <ce03f4b3-874f-a286-5523-7793722a6ee7@linux.intel.com>
 <b754ef05-065d-ee7b-754f-1498f7c6cff6@amd.com>
 <38def9e9-5161-9441-c88a-43b21edfec43@amd.com>
 <20210714162339.GD4719@sirena.org.uk>
From:   "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
Message-ID: <9f32082a-2f8e-d36c-d409-12bc10e7126f@amd.com>
Date:   Fri, 16 Jul 2021 05:19:25 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
In-Reply-To: <20210714162339.GD4719@sirena.org.uk>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [10.252.93.39] (165.204.159.242) by SG3P274CA0003.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:be::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21 via Frontend Transport; Thu, 15 Jul 2021 23:31:42 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ad9bda93-7f35-494c-6a6f-08d947e8b5d5
X-MS-TrafficTypeDiagnostic: MWHPR12MB1582:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MWHPR12MB1582F33A266CA23F66B1504597129@MWHPR12MB1582.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: cttjECAdpA7Q6TsHH2jkdUqdexxuXbW7h+8+kiDL8odZ3RbKeaEqtg05hC6gAo0KPnuTIqTX3l0ZPzZkQgfN/8rLoVgBv7anImM0aXoPQG971PyKfkvLlEMGY7A/5ikFWZXCpJocLx1+In9pHQcTq4eU8iVsK4wGaoGAZ+tn9jpjT8j/rdX+MB2Mebv6c1O1ufp9ZAXCrAzZ38k5tZshfpd9Fj725ikoWBWV3IxX8os1nhRjNUxkREgCqpg/t71PJK4kqvFkEsgXANXd0ONenspbkM3Igkk1GO9vxoqNsc0TM/t3Zoo/D7MzFIALUNuTCdPxKJJevIkYtibG4s5N4j7ws2bTb4IjSVL933HwmLuKRAPF+oHaoVmOY7Y2Y/QD+0I6d6zQQfMpXOY1WNxnhXoRQR8UWGULM0Nq/uRn8Za5zybBnVlVNhMLu++mCvmd1ve4C145+/95FOdUYNnxQNYiCWxh/QO/HAJgEjpUMN6iaBvnFqv0MuqKKPYiyMU7mw8s/CIkjkU8HgeBV2GdKzwEKW2Z9VTSEjxcXA2QgZR4lVuuy7/LEgwGOfpbkgMkE1AMTVUVS2b4LakpaE5k22GFXRSohXEx9BrOKUz4lSXf0qLUnQw+YWOmr7rMm2qyfIc8Z2H+ShLkHmH1uz4ArmgyZP1AS46LXJIOJ6UQqtn+oW63AZ8VjrmVIAy7S32VwNWPOTEPr+5bF6f4/Hio1dcbUkmZ1T3mOR5rHoF5OVk=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1201MB2557.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(396003)(366004)(39860400002)(136003)(4326008)(316002)(5660300002)(54906003)(2616005)(956004)(83380400001)(53546011)(8936002)(26005)(36756003)(186003)(86362001)(16576012)(6486002)(8676002)(38100700002)(478600001)(2906002)(6666004)(66556008)(66946007)(31686004)(6916009)(31696002)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?z0X+dYLm6XSNbpi4HFRnoBqgRhpJeliu+9i7OldSg5HlDEuAHiGaOtPm?=
 =?Windows-1252?Q?SUdF2JnxNWH9a4OzniVmVnG8R6si1WZ0lFTWwI4ejimYSbet7kwv+ZgF?=
 =?Windows-1252?Q?j9JyRg8I9T6lUkpBWEhAuj1UQPt2VpHnXuaWaWV7Btw8NHLTvG8IYwb6?=
 =?Windows-1252?Q?4bzRp2UV9BE2YFlF5xe1LL6NnfO4mz5Gsqn9zgWQmqvRQ26dXrgByKTx?=
 =?Windows-1252?Q?UzoNiNXAR4ozpduddgndt5DfkqV6CfdU4C0ZXX0ZF5EvEZe/M7lAD8nI?=
 =?Windows-1252?Q?lTRhBgHsH4jhQvEfnm9/kscSHypm1xoWz/Yhult8JIIszdH6tAphcvi2?=
 =?Windows-1252?Q?dnEpT3GFmhVFONebXQDwxkkxZ7KlxdYzlLnNcXdRS3oH44aM7iZjurrb?=
 =?Windows-1252?Q?iLGvVdlwro3IzocfMDUtiWzyPyMpAEgxrzJfwTJjR6Fn4I0HbtfS4v5t?=
 =?Windows-1252?Q?qHoK1Ncl8qun/qZEzL/hkPcCB2m5hDT93JQ/T6ztmcKxh8rKxB710xvY?=
 =?Windows-1252?Q?m+F7hakfSo+33p3Od/z1dfoaJYE9bqjhmxNcrdBXm20wtst/OwrqzGtW?=
 =?Windows-1252?Q?57uzFBM2wtD78gl403dCNsYLSM97DxToZbPC2hNJYyqDWzxs7seL0UiU?=
 =?Windows-1252?Q?F8pHlKwk52diE8nZZ0ql9TLfL1/x2Grs+vaqjaTDDOFW3V7/pR1RkrRe?=
 =?Windows-1252?Q?7HakMb1SFTO+AoboKA1z/sCegr1sNALZLHQpLMGiuD54GXVHuvTi3nyF?=
 =?Windows-1252?Q?vEdk4/EXKUBccbnsQ23yM1ReOqE+hBchhse/r0bMR8Iwa8QGWi6Y/+No?=
 =?Windows-1252?Q?w+Oj4lZYty9/ETlxJI/8Z/NNIPXS5BhY1qvLS8Ww2E/0nyPX6rw3U2Wv?=
 =?Windows-1252?Q?gME/+0D+uREhaC4bfUj5+wFZMbnBqTkqMumMn12Q8sKQwayQX4s+zrR0?=
 =?Windows-1252?Q?njDknVaWOpNFuvsOeI8Y19utBVP2SEjTf9JEGuCw0atoeJiSk1Tks65t?=
 =?Windows-1252?Q?T4LtokudPDB5XbUMfWsd+rijePDDeDfnA0889kjr04DiLcrbhEApwqDp?=
 =?Windows-1252?Q?/MeS2D3mcZfeXB0IWhzFUMW1Y3x+xdN4zgfz7s4qnTwznYsM5hshuq7G?=
 =?Windows-1252?Q?u5uvlCE6lPX1FAI9jmM8iPa8HCAT6vanmfH6JOHBAVD9B/Dq6yvoCu5c?=
 =?Windows-1252?Q?Rv+4raKXG2R9CzwxRSMHOUHUPrF4JjfhIdTVFDop2aOHvwdnrxSJEr4/?=
 =?Windows-1252?Q?EO0aUrBT2pBkWoGgexliT2zbYm/LdapMj0NJFZTI5X8iLQWpaVZ7hmf1?=
 =?Windows-1252?Q?bqPSxFt+irvS2MDuk6jH6xpxI1M3ngOCGi8iPwsU1nJxlyiHs4MuWnnK?=
 =?Windows-1252?Q?odyfFdhTY+T28WZqWjliwDvYfuVak1dvkPiVCAUTrnKfo6s4UuhiaN3A?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad9bda93-7f35-494c-6a6f-08d947e8b5d5
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1201MB2557.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2021 23:31:46.3360
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xsVyh2n5q1L81KfOx2wt/EF0VQyVYi6d2vWX5+2Nn7ki4uF0baK8HNor/j8fSyB7QyrzyuNMl5pQvIIR3JSENw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1582
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/14/21 9:53 PM, Mark Brown wrote:
> On Tue, Jul 13, 2021 at 12:06:38PM +0530, Mukunda,Vijendar wrote:
>> On 7/8/21 5:11 PM, Mukunda,Vijendar wrote:
>>> On 7/7/21 10:04 PM, Pierre-Louis Bossart wrote:
> 
>>>>> +static const struct dev_pm_ops acp5x_pm = {
>>>>> +	.runtime_suspend = snd_acp5x_suspend,
>>>>> +	.runtime_resume =  snd_acp5x_resume,
>>>>> +	.resume =	snd_acp5x_resume,
> 
>>>> use SET_SYSTEM_SLEEP_PM_OPS and SET_RUNTIME_PM_OPS?
> 
>> suspend and resume callbacks implementation is same for runtime pm ops
>> and system level pm ops in ACP PCI driver i.e in suspend callback acp
>> de-init sequence will be invoked and in resume callback acp init
>> sequence will be invoked.
> 
>> As per our understanding if we safeguard code with CONFIG_PM_SLEEP
>> macro, then runtime pm ops won't work.
> 
> That's not what Pierre is suggesting though?
> 
>> Do we need to duplicate the same code as mentioned below?
> 
>> static const struct dev_pm_ops acp5x_pm = {
>>         SET_RUNTIME_PM_OPS(snd_acp5x_runtime_suspend,
>>                            snd_acp5x_runtime_resume, NULL)
>>         SET_SYSTEM_SLEEP_PM_OPS(snd_acp5x_suspend, snd_acp5x_resume)
>> };
> 
> Using the SET_ macros doesn't require that you duplicate the functions,
> it literally just means changing the way the ops are assigned.  
> 
 Will make the changes and post the new version.