Date: Sun, 19 Nov 2006 15:21:42 -0800 (PST)
From: Linus Torvalds <torvalds@osdl.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
cc: Chuck Ebbert <76306.1226@compuserve.com>,
       linux-kernel <linux-kernel@vger.kernel.org>,
       Andrew Morton <akpm@osdl.org>
Subject: Re: [patch] PM: suspend/resume debugging should depend on 
 SOFTWARE_SUSPEND
In-Reply-To: <200611192225.52074.rjw@sisk.pl>
Message-ID: <Pine.LNX.4.64.0611191518170.3692@woody.osdl.org>
References: <200611190320_MC3-1-D21B-111C@compuserve.com> <200611191955.23782.rjw@sisk.pl>
 <Pine.LNX.4.64.0611191153200.3692@woody.osdl.org> <200611192225.52074.rjw@sisk.pl>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1092
Lines: 28


On Sun, 19 Nov 2006, Rafael J. Wysocki wrote:
> > concept works anywhere that has a CMOS chip, so if somebody were to spend 
> > a few minutes testing it on x86-64 and others, it would work elsewhere 
> > too..
> 
> I can do that if someone gives me the code.

Well, I actually _think_ it works almost as-is on x86-64 too, but the 
magic is all in that small inline asm thing in <linux/resume-trace.h>.

The ".long" in that inline asm probably needs to be a ".quad" - see gow 
"generate_resume_trace()" uses it.

Also the "show_file_hash()" right now has a "tracedata += 6", and it 
should probably be "tracedata += 2 + sizeof(void *)" instead.

IOW, it really should be very easy to get to work on x86-64, I just 
haven't had the energy or inclination, since the only devices I've 
personally used it on have been regular 32-bit ones..

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/