Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.112.34 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.112.34; helo=mail.nvidia.com;
Subject: Re: [PATCH 4/4] Revert "mm/page_alloc: make should_fail_alloc_page()
 static"
To:     Jesper Dangaard Brouer <jbrouer@redhat.com>,
        Mel Gorman <mgorman@techsingularity.net>,
        Andrew Morton <akpm@linux-foundation.org>, <acme@kernel.org>,
        Jiri Olsa <jolsa@redhat.com>
CC:     <brouer@redhat.com>,
        Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>,
        Zhang Qiang <Qiang.Zhang@windriver.com>,
        Yanfei Xu <yanfei.xu@windriver.com>,
        Chuck Lever <chuck.lever@oracle.com>,
        Matteo Croce <mcroce@microsoft.com>,
        Linux-MM <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>, bpf <bpf@vger.kernel.org>
References: <20210713152100.10381-1-mgorman@techsingularity.net>
 <20210713152100.10381-5-mgorman@techsingularity.net>
 <fb642720-b651-e93f-4656-7042493efba8@nvidia.com>
 <5db9011e-9b52-b415-70b6-c7ee1b01436b@redhat.com>
From:   John Hubbard <jhubbard@nvidia.com>
Message-ID: <90251cd2-7c4c-9d2f-668f-c2168da7ac9c@nvidia.com>
Date:   Thu, 15 Jul 2021 17:04:43 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <5db9011e-9b52-b415-70b6-c7ee1b01436b@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jul 2021 00:04:44.0297
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: fc20e589-3f3e-4954-d8f5-08d947ed5100
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT027.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1592
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

...
>> LD      vmlinux
>> BTFIDS  vmlinux
>> FAILED elf_update(WRITE): no error
> 
> This elf_update(WRITE) error is new to me.
> 
>> make: *** [Makefile:1176: vmlinux] Error 255
>> make: *** Deleting file 'vmlinux'
> 
> It is annoying that vmlinux is deleted in this case, because I usually give Jiri the output from 
> 'resolve_btfids -v' on vmlinux.
> 
>   $ ./tools/bpf/resolve_btfids/resolve_btfids -v vmlinux.failed
> 
> You can do:
> $ git diff
> diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
> index 3b261b0f74f0..02dec10a7d75 100755
> --- a/scripts/link-vmlinux.sh
> +++ b/scripts/link-vmlinux.sh
> @@ -302,7 +302,8 @@ cleanup()
>          rm -f .tmp_symversions.lds
>          rm -f .tmp_vmlinux*
>          rm -f System.map
> -       rm -f vmlinux
> +       # rm -f vmlinux
> +       mv vmlinux vmlinux.failed
>          rm -f vmlinux.o
>   }
> 
> 
>>
>>
>> ...and un-setting CONFIG_DEBUG_INFO_BTF makes that disappear. Maybe someone
>> who is understands the BTFIDS build step can shed some light on that; I'm
>> not there yet. :)
> 
> I'm just a user/consume of output from the BTFIDS build step, I think Jiri Olsa own the tool 
> resolve_btfids, and ACME pahole.  I've hit a number of issues in the past that Jiri and ACME help 
> resolve quickly.
> The most efficient solution I've found was to upgrade pahole to a newer version.
> 
> What version of pahole does your build system have?
> 
> What is your GCC version?
> 

Just a quick answer first on the versions: this is an up to date Arch Linux system:

gcc: 11.1.0
pahole: 1.21

I'll try to get the other step done later this evening.

thanks,
-- 
John Hubbard
NVIDIA