Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp841881pxv; Thu, 15 Jul 2021 17:37:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz/9ERvzoae1jQ3HngMNDZYBLejNSd51EIxMVisK+iV6VSJeHcs/nT6NL2wiqvq4BN93+jC X-Received: by 2002:a05:6402:2919:: with SMTP id ee25mr11159819edb.222.1626395864723; Thu, 15 Jul 2021 17:37:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626395864; cv=none; d=google.com; s=arc-20160816; b=M98xFiZ+5mKQfyUEUkAQquVrNk1zGIcYhVMrfWrQj0XaDvT/hTvvDVqAN7W6NEVKyH jDi+EjTWh6n1ik37j2rzKlWGJrfn1gYKFGDCL7lpK2XfIPxPI0cXhLy1ndPAi00zseuz i0GowF9Y1BWOgBkwwdQXyU05lmGCtnEi8t9vCBKv8YWpaOUmuVZhZuPj9bbSfCmE/BYH 2PzvFMhTkzufTycFFUXK8ChoCH37LBjukysXHDvcd36EAyV2QVBGyyplvYgay8tqQ8Fo HD1f+JvpyX20Q5zsqDDU8osSWBFC3hBGBcwWHM44HEIj1zZs/Vh4605dxsnvn19iyG0A qLRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:references:in-reply-to :mail-reply-to:reply-to:organization:subject:cc:to:from:date :content-transfer-encoding:mime-version:sender:dkim-signature; bh=Hg4UHJ6k0BkePlXHMCIMP/orYnASJUN8pewnaW0YCJU=; b=wLxgFVLeu7XhczBzuZeKbay9A92Fu1/hsin39bVO7EEzz11gtK7z2ZhmVriwvs3rg2 a4iI8Wsx1JaVd2I35y7f59yoHHFFcCOU1VxWKInuNmRbpeIgmyOHctO40q8H8QPh3+w9 OXgs/YzDs6/udG2ZII/AHeFxy7PpKMj31yonBvTVrzMd6gb685vros9ah/QL8yh9NuXV 7d5W7IhZJZQkKeEYfVZb87sTsO3dx6pqyMv40ZqS7r+V1wWcP961Uz0pq075M/2XVw6i zpueu+Hib3FIOce26rlgEAyhoF3ADm5p/Z0hQ4dxP2wZ2jD0uZZSoOdYisfUv7PR/4ji hvHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=jHxlXl5c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i11si11520241edb.418.2021.07.15.17.37.09; Thu, 15 Jul 2021 17:37:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=jHxlXl5c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230317AbhGPAip (ORCPT + 99 others); Thu, 15 Jul 2021 20:38:45 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:32876 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229583AbhGPAip (ORCPT ); Thu, 15 Jul 2021 20:38:45 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1626395751; h=Message-ID: References: In-Reply-To: Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=Hg4UHJ6k0BkePlXHMCIMP/orYnASJUN8pewnaW0YCJU=; b=jHxlXl5caTcF/uKMOHPyzLf5SQMc4Iq4cFfx5lPaatvEtmsshV6YRBxeJi02aLDPWo47iuCk HJnKcBHhWhKr4fB4IHFBhPyQfbnQ54Jij6bIVYwdVYEqG4O+oKkBJ9kJUBU72mMxImz7ADef dtpSjeBCOYqbYAlRapkVCdbLfkk= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-east-1.postgun.com with SMTP id 60f0d45d17c2b4047d6e6a5c (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 16 Jul 2021 00:35:41 GMT Sender: bbhatt=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 5917BC43217; Fri, 16 Jul 2021 00:35:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: bbhatt) by smtp.codeaurora.org (Postfix) with ESMTPSA id F1763C433D3; Fri, 16 Jul 2021 00:35:38 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Thu, 15 Jul 2021 17:35:38 -0700 From: Bhaumik Bhatt To: Hemant Kumar , Paul Davey Cc: Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, hemantk=codeaurora.org@codeaurora.org Subject: Re: [PATCH v3 2/2] bus: mhi: Fix MHI DMA structure endianness Organization: Qualcomm Innovation Center, Inc. Reply-To: bbhatt@codeaurora.org Mail-Reply-To: bbhatt@codeaurora.org In-Reply-To: <1625104371.10055.21.camel@codeaurora.org> References: <20210629035357.11091-1-paul.davey@alliedtelesis.co.nz> <20210629035357.11091-3-paul.davey@alliedtelesis.co.nz> <1625104371.10055.21.camel@codeaurora.org> Message-ID: X-Sender: bbhatt@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, On 2021-06-30 06:52 PM, Hemant Kumar wrote: > Hi Paul, > On Tue, 2021-06-29 at 15:53 +1200, Paul Davey wrote: >> The MHI driver does not work on big endian architectures.  The >> controller never transitions into mission mode.  This appears to be >> due >> to the modem device expecting the various contexts and transfer rings >> to >> have fields in little endian order in memory, but the driver >> constructs >> them in native endianness. >> >> Fix MHI event, channel and command contexts and TRE handling macros >> to >> use explicit conversion to little endian.  Mark fields in relevant >> structures as little endian to document this requirement. >> >> Signed-off-by: Paul Davey >> --- >> Removed Tested-by as patch has changed somewhat from v2. > Bhaumik is going to help testing V2 on x86 platform. Change looks good > to me. Will ack it once testing is done. >>  [..] >> > > Thanks, > Hemant Just following up on this one. I have been seeing problems with my setup and will try to get to this test next week. Thanks, Bhaumik --- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project