Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] pinctrl: single: Fix error return code in
 pcs_parse_bits_in_pinctrl_entry()
To:     "weiyongjun (A)" <weiyongjun1@huawei.com>,
        Tony Lindgren <tony@atomide.com>,
        Haojian Zhuang <haojian.zhuang@linaro.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Manjunathappa Prakash <prakash.pm@ti.com>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-omap <linux-omap@vger.kernel.org>,
        linux-gpio <linux-gpio@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <20210715064206.3193-1-thunder.leizhen@huawei.com>
 <55d02087-e2c7-9a0c-e20e-ff6f106703a3@huawei.com>
From:   "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
Message-ID: <ab9e3a1a-551c-92e5-06cc-45b1081243e3@huawei.com>
Date:   Fri, 16 Jul 2021 09:17:02 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <55d02087-e2c7-9a0c-e20e-ff6f106703a3@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2021/7/15 19:49, weiyongjun (A) wrote:
>> Fix to return -ENOTSUPP instead of 0 when PCS_HAS_PINCONF is true, which
>> is the same as that returned in pcs_parse_pinconf().
>>
>> In addition, I found the value of pcs->flags is not overwritten in
>> pcs_parse_bits_in_pinctrl_entry() and its subfunctions, so moving this
>> check to the beginning of the function eliminates unnecessary rollback
>> operations.
>>
>> Fixes: 4e7e8017a80e ("pinctrl: pinctrl-single: enhance to configure multiple pins of different modules")
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>> ---
>>   drivers/pinctrl/pinctrl-single.c | 21 ++++++++-------------
>>   1 file changed, 8 insertions(+), 13 deletions(-)
>>
>>
>>       npins_in_row = pcs->width / pcs->bits_per_pin;
>>         vals = devm_kzalloc(pcs->dev,
>> @@ -1212,29 +1217,19 @@ static int pcs_parse_bits_in_pinctrl_entry(struct pcs_device *pcs,
>>           goto free_pins;
>>       }
>>   -    gsel = pinctrl_generic_add_group(pcs->pctl, np->name, pins, found, pcs);
>> -    if (gsel < 0) {
>> -        res = gsel;
>> +    res = pinctrl_generic_add_group(pcs->pctl, np->name, pins, found, pcs);
>> +    if (res < 0)
>>           goto free_function;
>> -    }
> 
> 
> This change cause 'gsel' not set.

The local variable 'gsel' is no longer needed. I have deleted it.

> 
> Do not mix this cleanup with bugfix.

Yes, it might be clearer.

> 
> 
> 
> .
>