Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp898574pxv; Thu, 15 Jul 2021 19:19:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwuvpmHdaxKNqYO1kfvppIy4PH0LdCHNt576T9yS7pNtbR6/sJtH3mVN1w8L2tf8I4CJmQH X-Received: by 2002:a05:6402:501:: with SMTP id m1mr11354598edv.163.1626401947506; Thu, 15 Jul 2021 19:19:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626401947; cv=none; d=google.com; s=arc-20160816; b=hvlfHWfSn/yjkfITaq33Cn7rVGmDRClYYJR80Rpe6Asy8NoLPPsZ8DVMP3ICOYWgMY nK1P0cGgUVh+LNxHvkoWUDb771EzwSgqvgj6TaxVV4cbZl31MDxOXoi+mSmwGTTw4AKU zlc2rW1jfCsF7kN9mw48TT3Tg4UpaZQAHjIvb/lNbahfrSumewAjVlGintFd5/zjMkRa Hfqa1W9S0KifL4rdB3zcNtg0M9nDA9qEyRA3+o3+SXh//AlUlfKwuYCFfzEJID3FEhpn SdJOUTAb6JkzPLZjOf0VkTQ7cbHxjfwtqMUWpVZ4xSRzIezq2fDW+ghy60oueOjSROce yVYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=7GTfH8fCEHAUZ3BetrG+wDQa3jsM8/zy40SCzAZxl8Y=; b=yM5SpdAmr1aHmdnFnaCXx9bo/FdFaI+5H2pVaBM9dGgzPXV5U99dj4Ao7HLwaYBhfR xPgt7jFlMD07pXZEY2RCMMDKHTVc5XJ+oKw5b5n+og2UaIL/og/EH8rXN7/YVgtOSZDk /Bk9yhJhBePD7gH3Y29GvwEd/jtaWIAqloed+2fDOBGlCQMZTgSgQwwWcx0ZQLI8QYlr 5GG22xnRpkKHz6b02TuVgMfD2x4FkqUEUrkdH2OcApppq1US8PSerbCEAeYuW+tpJrF9 YrxVs51svCjPO6r/gnDxX0JVOzqSSeJ/9JuFbYfC9v4EMo/s0x/BA7ewm7VTL6+xHPtJ 12bg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=K2s6uQSx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qh5si9240102ejb.72.2021.07.15.19.18.44; Thu, 15 Jul 2021 19:19:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=K2s6uQSx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233181AbhGPCTg (ORCPT + 99 others); Thu, 15 Jul 2021 22:19:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:21223 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233114AbhGPCTe (ORCPT ); Thu, 15 Jul 2021 22:19:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626401799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7GTfH8fCEHAUZ3BetrG+wDQa3jsM8/zy40SCzAZxl8Y=; b=K2s6uQSxVma3z0kWZna3CEcfpObFIEmhha+5R+xmHxzn7GfOr3Q9y9sz78TcI5gzrqcW8m a3ZfWYpDdXP7FcSHvZr/joi256DTBtqsGnuxNHg5yRMJoDJfV9cxdDhmOsDQ8d/YCtjFnb qAyUcog5B8kIWclmtetdc2VlLb/1ZJY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-148-IjJ6mpBJOyyOqKMMbKbcqA-1; Thu, 15 Jul 2021 22:16:36 -0400 X-MC-Unique: IjJ6mpBJOyyOqKMMbKbcqA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0AB191084F4B; Fri, 16 Jul 2021 02:16:34 +0000 (UTC) Received: from T590 (ovpn-13-153.pek2.redhat.com [10.72.13.153]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C198A60BF1; Fri, 16 Jul 2021 02:16:24 +0000 (UTC) Date: Fri, 16 Jul 2021 10:16:18 +0800 From: Ming Lei To: Oleksandr Natalenko Cc: linux-kernel@vger.kernel.org, Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-nvme@lists.infradead.org, David Jeffery , Laurence Oberman , Paolo Valente , Jan Kara , Sasha Levin , Greg Kroah-Hartman , Keith Busch Subject: Re: New warning in nvme_setup_discard Message-ID: References: <4729812.CpyZKHjjVO@natalenko.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4729812.CpyZKHjjVO@natalenko.name> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 15, 2021 at 03:56:38PM +0200, Oleksandr Natalenko wrote: > Hello. > > After a v5.13.2 massive update I encountered this: > > ``` > [19231.556665] ------------[ cut here ]------------ > [19231.556674] WARNING: CPU: 20 PID: 502 at drivers/nvme/host/core.c:850 > nvme_setup_discard+0x188/0x1f0 > ... > [19231.556776] CPU: 20 PID: 502 Comm: kworker/20:1H Not tainted 5.13.2 #1 > [19231.556780] Hardware name: ASUS System Product Name/Pro WS X570-ACE, BIOS > 3601 05/26/2021 > [19231.556784] Workqueue: kblockd blk_mq_run_work_fn > [19231.556789] RIP: 0010:nvme_setup_discard+0x188/0x1f0 > [19231.556794] Code: 49 8b 44 24 10 4c 8b 90 40 0b 00 00 4c 2b 15 8f 09 d8 00 > 49 c1 fa 06 49 c1 e2 0c 4c 03 15 90 09 d8 00 4d 89 d0 e9 b9 fe ff ff <0f> 0b b8 > 00 00 00 80 49 01 c2 72 52 48 c7 c0 00 00 00 80 48 2b 05 > [19231.556798] RSP: 0018:ffffaed2416efc00 EFLAGS: 00010287 > [19231.556802] RAX: ffff8e67fb580000 RBX: ffff8e640bbe5240 RCX: 0000000000000020 > [19231.556805] RDX: ffff8e67fb580000 RSI: 000000000000001f RDI: 0000000000000000 > [19231.556808] RBP: ffff8e640bbe5388 R08: ffff8e677b580000 R09: 0000000008abb800 > [19231.556811] R10: ffff8e677b580000 R11: 0000000000000400 R12: ffff8e6405999c00 > [19231.556814] R13: 000000000000001f R14: ffff8e6405693000 R15: ffff8e640bbaf800 > [19231.556816] FS: 0000000000000000(0000) GS:ffff8e6b0ef00000(0000) knlGS: > 0000000000000000 > [19231.556819] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [19231.556822] CR2: ffff888c76ece000 CR3: 000000047a184000 CR4: 0000000000350ee0 > [19231.556825] Call Trace: > [19231.556830] nvme_setup_cmd+0x2d0/0x670 > [19231.556834] nvme_queue_rq+0x79/0xc90 > [19231.556837] ? __sbitmap_get_word+0x30/0x80 > [19231.556842] ? sbitmap_get+0x85/0x180 > [19231.556846] blk_mq_dispatch_rq_list+0x15c/0x810 > [19231.556851] ? list_sort+0x21d/0x2f0 > [19231.556856] __blk_mq_do_dispatch_sched+0x196/0x320 > [19231.556860] __blk_mq_sched_dispatch_requests+0x14d/0x190 > [19231.556864] blk_mq_sched_dispatch_requests+0x2f/0x60 > [19231.556867] blk_mq_run_work_fn+0x43/0xc0 > [19231.556871] process_one_work+0x24e/0x430 > [19231.556876] worker_thread+0x54/0x4d0 > [19231.556880] ? process_one_work+0x430/0x430 > [19231.556883] kthread+0x1b3/0x1e0 > [19231.556886] ? __kthread_init_worker+0x50/0x50 > [19231.556889] ret_from_fork+0x22/0x30 > [19231.556895] ---[ end trace d9abdf019a56b4c7 ]--- > [19231.556906] blk_update_request: I/O error, dev nvme1n1, sector 632935424 op > 0x3:(DISCARD) flags 0x0 phys_seg 31 prio class 0 > ``` > > or, in code: > > ``` > 850 if (WARN_ON_ONCE(n != segments)) { What is 'n' and 'segments'? thanks, Ming