Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 16 Jul 2021 03:49:31 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     "Darrick J. Wong" <djwong@kernel.org>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v14 128/138] iomap: Support multi-page folios in
 invalidatepage
Message-ID: <YPDzu5Upm85z1tDN@casper.infradead.org>
References: <20210715033704.692967-1-willy@infradead.org>
 <20210715033704.692967-129-willy@infradead.org>
 <20210715221018.GT22357@magnolia>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210715221018.GT22357@magnolia>
Precedence: bulk

On Thu, Jul 15, 2021 at 03:10:18PM -0700, Darrick J. Wong wrote:
> On Thu, Jul 15, 2021 at 04:36:54AM +0100, Matthew Wilcox (Oracle) wrote:
> > If we're punching a hole in a multi-page folio, we need to remove the
> > per-page iomap data as the folio is about to be split and each page will
> > need its own.  This means that writepage can now come across a page with
> > no iop allocated, so remove the assertion that there is already one,
> > and just create one (with the uptodate bits set) if there isn't one.
> > 
> > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> 
> Lol, Andreas already did the bottom half of the change for you.

Heh, yes, I copy-and-pasted it from this patch ;-)  Thanks for
merging it!