Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Clark Wang <xiaoning.wang@nxp.com>
To:     miquel.raynal@bootlin.com, conor.culhane@silvaco.com,
        alexandre.belloni@bootlin.com
Cc:     linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
        xiaoning.wang@nxp.com
Subject: [PATCH V2 4/5] i3c: master: svc: set ODSTOP to let I2C device see the STOP signal
Date:   Fri, 16 Jul 2021 15:37:22 +0800
Message-Id: <20210716073723.3490180-5-xiaoning.wang@nxp.com>
In-Reply-To: <20210716073723.3490180-1-xiaoning.wang@nxp.com>
References: <20210716073723.3490180-1-xiaoning.wang@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from localhost.localdomain (119.31.174.71) by SG2PR02CA0005.apcprd02.prod.outlook.com (2603:1096:3:17::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21 via Frontend Transport; Fri, 16 Jul 2021 07:36:20 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 92cc5143-a929-48b4-bad6-08d9482c689f
X-MS-TrafficTypeDiagnostic: AM6PR04MB4759:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <AM6PR04MB47590B9759AC39D432B98864F3119@AM6PR04MB4759.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1148;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: yGYzIIBwoM46dvNBM7xBpcSFsjRQywWW+ZrnqTRbr7Wk7M7Ub1Bc6huZhV4R5W2TJH47FhRDjAGTE7AL8o+Hc/4FqV+9i4x70hSX1wnW0UWwIDrnFQHQLzm3y/yNWQmt2YjXbEm7O6BF0+V60LLor3X5EHK7LZBaUkUKU421aDbXzbOthkJh2hr4ZxobQP9y4cc+tSWqIGJq5M0bjnXNV7gszqIqnYZE79h9Wy2r9BBfkBe8S7IMMMv6ie10+xnAD4kMs9xrsUyJcAMW3l/RnKsCNM4wCvwSJfRusK9y4L3JECEB8cbbhKR4KqJKeRSGBBo7lbaLx6Ji0bjKtqk1ED82cYbSlElm2ISXS6zxNfzO8OLfj5VyNH/uhB3L5gLFpck/mTKXlDXIiFn4jccLXJDOdmXUsZ3bB7DxPkgRZi3pzd8Y/ex/Kqm80XjU9WFFY06Ls0NktoF7ABjlS6qOq5jI2VbkcU0xEsFmeTWFSJ3uE+smj1btbioQK2Eg74eWGlqvezUSkLUa/VQU90m0FShSTYYSghr8P6j6rvqtaEnYXQ+hW7mmqljTHvWIPLYmEl7oBkPChNoh7Q9JJs7gykFTyhyHBwXzJZVmgU7NjboQb/7buW0td1d+hoMuOO+URjf1IctGK23uv1c2pRHvdEZMIWToKlSHOVvP9mYKeE40SMhL82rX4QTsA+2IlXHsfDUhohmOKYa47ccPjgk7sg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB5623.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(366004)(136003)(39860400002)(376002)(396003)(2906002)(478600001)(2616005)(26005)(956004)(38100700002)(83380400001)(38350700002)(6512007)(4326008)(86362001)(52116002)(66946007)(5660300002)(6506007)(36756003)(316002)(186003)(1076003)(8936002)(66556008)(66476007)(8676002)(6486002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WGxlZgSKCy4/9HkobHkgvvFnKVu+03W3NXC0PcmqNFib2w/DRsuecle1fTCc?=
 =?us-ascii?Q?JOfdQVDW9PojwFu8FAwFNZYu6K8UY6HrVepJO6a6w4EUt7DWRFIl3g1WZ06L?=
 =?us-ascii?Q?a2HUDa2MfxQYA5IrjZvey4jdMC1R5Uc/ubV98FgOn9Zo9hEIWvtljZCJnAAM?=
 =?us-ascii?Q?XyMH2/GxvngONMdU6m+FLHWgd+xfBHs+D12QvXZ0RcrQuEqneP/r4K4577LX?=
 =?us-ascii?Q?b51lIniZJP6ozlbNpRoJJ+92uaqUd6lawkjaoy4nA0pU7FWwoThYEtRXE+ND?=
 =?us-ascii?Q?jHnaJIp3iei+FUIMR5vxBk9kohbzOt6Bw6StsHWr1phh2JZOI7AJa9Q8UKDP?=
 =?us-ascii?Q?Y3RdrRAYT8Rur7eOUd7drJ6QyLlQH6Pr4BbaF0feXuljxLruqJ0GMh1oJk6b?=
 =?us-ascii?Q?hwVzcYxmsytMtZ5mvdSVRnS2Uh5MV4xPBBmJNiZN/9FdQVld6aCnCnAmRqaC?=
 =?us-ascii?Q?rERbGN4ClZ5rKBp/KWCl7y0viVmdbS2cbCLsKkTvGDzbuwUFQlPkVx5OhxLU?=
 =?us-ascii?Q?+tmamBlDDkhSov5JD2ZnigzHf/0So8jN9ELS6OEAI8t+XxcTRTuUgCkF1x6c?=
 =?us-ascii?Q?0KwAZJ8EHxQPFx91wIrgOS0VXmeNztcZtCvEcHztC4xN+Fbyzi5LvDYfjqUH?=
 =?us-ascii?Q?2q9Flm0o0d7ZSBND8RfA8bxLefwdtRdQdTiGooDiSaGNkxhQxqwwBaxu4Rap?=
 =?us-ascii?Q?NOKxiAzbJR7BE8VWmGokVXhxM5FJp5o/B1eFN6vWFmiX717uTXoMK0dBhxnf?=
 =?us-ascii?Q?LOLmgWvR3jBvHVQzHiWEVemRPedRHpUiCmAsT32VYjqLIai91iWDOQX8+jvM?=
 =?us-ascii?Q?zddF6u9b7M35hpGCcAfhMd9lMK3aSPdeBOEf+zhbwrCCXgoOs1BaVz+1e0JK?=
 =?us-ascii?Q?JKm/Py2rHhqUkv9eqnRk9Vt7q9IzFq50kD7TtrO/6Aw7eRnqK1no9mXltpk2?=
 =?us-ascii?Q?rm8vRpe4OyHGpB+b9y0Dga/4oGmbAfBmQiSiaZbjsJnlAsyToi7NBzrG3vQt?=
 =?us-ascii?Q?lUaug/TCDcyD8aeBQH02hF1R6yWd5QB41O/N35M8Hjn2JHdkI7UIjIQFkO6/?=
 =?us-ascii?Q?hiQNfCrTc8pJsIi7oCaVoACYWJdwE0IjFG3YuJDDYL0hXZbXcsIvt7QfYi7v?=
 =?us-ascii?Q?fp5AUo9K9UlymUtTDonF9i6U1/g+m1kZaFxEY3zWB1gIRqYoGZpKpAUVMSKQ?=
 =?us-ascii?Q?RfEdo7ejv5J69b6w3CwPTUnIRxCP86S34EkEh3CDJ6ZDmFqhzuW0NH8jHY6b?=
 =?us-ascii?Q?rkBCaqpgz0e8J4eVexmWoJ8h7PD8slBSrxwnHsg+PAeO6dJLgsPqlQJ2pX0V?=
 =?us-ascii?Q?ups5ZPeIn50qrcjIC/iARfSc?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 92cc5143-a929-48b4-bad6-08d9482c689f
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB5623.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jul 2021 07:36:22.2754
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4RWMX7I2/Ba9FiCbZ6ZN6lmEPlHKj2PvGjl+aOt0vbB4orizArGoxDasrFyBq0cYJqn3QStelneZEOwvWzVQ4w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4759
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

If using I2C/I3C mixed mode, need to set ODSTOP. Otherwise, the I2C
devices cannot see the stop signal. It may cause message sending errors.

Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
V2: No change.
---
 drivers/i3c/master/svc-i3c-master.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index 91358cc5ca07..5677b5b31a86 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -449,7 +449,7 @@ static int svc_i3c_master_bus_init(struct i3c_master_controller *m)
 	struct i3c_device_info info = {};
 	unsigned long fclk_rate, fclk_period_ns;
 	unsigned int high_period_ns, od_low_period_ns;
-	u32 ppbaud, pplow, odhpp, odbaud, i2cbaud, reg;
+	u32 ppbaud, pplow, odhpp, odbaud, odstop, i2cbaud, reg;
 	int ret;
 
 	/* Timings derivation */
@@ -479,6 +479,7 @@ static int svc_i3c_master_bus_init(struct i3c_master_controller *m)
 	switch (bus->mode) {
 	case I3C_BUS_MODE_PURE:
 		i2cbaud = 0;
+		odstop = 0;
 		break;
 	case I3C_BUS_MODE_MIXED_FAST:
 	case I3C_BUS_MODE_MIXED_LIMITED:
@@ -487,6 +488,7 @@ static int svc_i3c_master_bus_init(struct i3c_master_controller *m)
 		 * between the high and low period does not really matter.
 		 */
 		i2cbaud = DIV_ROUND_UP(1000, od_low_period_ns) - 2;
+		odstop = 1;
 		break;
 	case I3C_BUS_MODE_MIXED_SLOW:
 		/*
@@ -494,6 +496,7 @@ static int svc_i3c_master_bus_init(struct i3c_master_controller *m)
 		 * constraints as the FM+ mode.
 		 */
 		i2cbaud = DIV_ROUND_UP(2500, od_low_period_ns) - 2;
+		odstop = 1;
 		break;
 	default:
 		return -EINVAL;
@@ -502,7 +505,7 @@ static int svc_i3c_master_bus_init(struct i3c_master_controller *m)
 	reg = SVC_I3C_MCONFIG_MASTER_EN |
 	      SVC_I3C_MCONFIG_DISTO(0) |
 	      SVC_I3C_MCONFIG_HKEEP(0) |
-	      SVC_I3C_MCONFIG_ODSTOP(0) |
+	      SVC_I3C_MCONFIG_ODSTOP(odstop) |
 	      SVC_I3C_MCONFIG_PPBAUD(ppbaud) |
 	      SVC_I3C_MCONFIG_PPLOW(pplow) |
 	      SVC_I3C_MCONFIG_ODBAUD(odbaud) |
-- 
2.25.1