Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 16 Jul 2021 10:35:47 +0200
From:   Samuel Thibault <samuel.thibault@ens-lyon.org>
To:     Colin King <colin.king@canonical.com>
Cc:     array@sonata.ens-lyon.org, initializers@sonata.ens-lyon.org,
        Chris Brannon <chris@the-brannons.com>,
        Kirk Reiser <kirk@reisers.ca>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        speakup@linux-speakup.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] speakup: use C99 syntax for array initializers
Message-ID: <20210716083547.sm5uzd2wsklb65f5@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
        Colin King <colin.king@canonical.com>, array@sonata.ens-lyon.org,
        initializers@sonata.ens-lyon.org,
        Chris Brannon <chris@the-brannons.com>,
        Kirk Reiser <kirk@reisers.ca>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        speakup@linux-speakup.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20210715163122.62220-1-colin.king@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210715163122.62220-1-colin.king@canonical.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
Precedence: bulk

Colin King, le jeu. 15 juil. 2021 17:31:22 +0100, a ecrit:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The older obsolete array initializer syntax is currently being used
> for some of the array elements. Fix this by using the preferred C99
> array initializers syntax.
> 
> Fixes: 5b5140bf5182 ("speakup: Separate out translations for bright colors names")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> ---
>  drivers/accessibility/speakup/i18n.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/accessibility/speakup/i18n.c b/drivers/accessibility/speakup/i18n.c
> index bc7b47d1876f..d62079b1661f 100644
> --- a/drivers/accessibility/speakup/i18n.c
> +++ b/drivers/accessibility/speakup/i18n.c
> @@ -90,13 +90,13 @@ static char *speakup_default_msgs[MSG_LAST_INDEX] = {
>  	[MSG_COLOR_YELLOW] = "yellow",
>  	[MSG_COLOR_WHITE] = "white",
>  	[MSG_COLOR_GREY] = "grey",
> -	[MSG_COLOR_BRIGHTBLUE] "bright blue",
> -	[MSG_COLOR_BRIGHTGREEN] "bright green",
> -	[MSG_COLOR_BRIGHTCYAN] "bright cyan",
> -	[MSG_COLOR_BRIGHTRED] "bright red",
> -	[MSG_COLOR_BRIGHTMAGENTA] "bright magenta",
> -	[MSG_COLOR_BRIGHTYELLOW] "bright yellow",
> -	[MSG_COLOR_BRIGHTWHITE] "bright white",
> +	[MSG_COLOR_BRIGHTBLUE] = "bright blue",
> +	[MSG_COLOR_BRIGHTGREEN] = "bright green",
> +	[MSG_COLOR_BRIGHTCYAN] = "bright cyan",
> +	[MSG_COLOR_BRIGHTRED] = "bright red",
> +	[MSG_COLOR_BRIGHTMAGENTA] = "bright magenta",
> +	[MSG_COLOR_BRIGHTYELLOW] = "bright yellow",
> +	[MSG_COLOR_BRIGHTWHITE] = "bright white",
>  
>  	/* Names of key states. */
>  	[MSG_STATE_DOUBLE] = "double",
> -- 
> 2.31.1
>