Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Clark Wang <xiaoning.wang@nxp.com>
To:     miquel.raynal@bootlin.com, conor.culhane@silvaco.com,
        alexandre.belloni@bootlin.com
Cc:     linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
        xiaoning.wang@nxp.com
Subject: [PATCH V3 4/5] i3c: master: svc: set ODSTOP to let I2C device see the STOP signal
Date:   Fri, 16 Jul 2021 16:53:16 +0800
Message-Id: <20210716085317.3572224-5-xiaoning.wang@nxp.com>
In-Reply-To: <20210716085317.3572224-1-xiaoning.wang@nxp.com>
References: <20210716085317.3572224-1-xiaoning.wang@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from localhost.localdomain (119.31.174.71) by SG2PR04CA0158.apcprd04.prod.outlook.com (2603:1096:4::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21 via Frontend Transport; Fri, 16 Jul 2021 08:52:13 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 790100e4-c39f-4a60-1cce-08d948370279
X-MS-TrafficTypeDiagnostic: AM7PR04MB7142:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <AM7PR04MB71426982F432ACD338FCFADCF3119@AM7PR04MB7142.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1148;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: eB3AjaBsSU/tfbypnivETYcs6BwoKWE3euNIPQHdHA2zhbU7DUJCnDKuY1+ZEpq2ZmIqSCrGm6Kp80FbQWGRrdthT3/8x/7ord2vRTUnBHuUxbnBumdwFxqri4h9eAKHM3jhJbVO4wPXmyOb4g1YfyGpPS3hAqjvn1wHfUnD4sYNiTYuLeJCMphhbU9ULCY3yztdb9+NfeR6mKosahGHROuq5okfsWofXfSUDGttnndLiK+bGyimgR0n5WyEwzEdNdzlEWo7PkURcq7e0fiNbVbObkOoBqwuJ8T79J5A0iFcrNf6q0n3bxQRhpqY6jX5QLL0HfNqxY5CC7cnf9rN6/3UDLvdWkVgMCLeMSX1Xy2rgWQlCZ5Yz4WavAByQpn+LBhIL2DIdiPKqXlEbMtysl4x/B5Ow7pQ9lSFWYzxQfFccrPrw6Pw8DtnYExfvR8j89jGqaZMH0hidQpKqAWj3uT1knbLtsgAZPbZrAMGQid16tUwwexsB/7405Tekp9iwuO2y3Mxow4O2o2dBqtYcZ6pze7wzV+ZW5Z0Ogv7joI2aEckSqfOwCDwlEw+y/J/XNK7ki3uEGQaQbUVy/ugtwibwa7mKasgB+7TmzeX4cu5nX4Bqjj0jtBmCWl1+2a3YhT+w8FSfxhXDmSQzITr9WW0z2EBSjZjy5P6gzDx6dlUuuVvTsn/MCL79ndIAoIyi/1EPTaIFqiP33JNfEaJtQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB5623.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(346002)(39850400004)(136003)(366004)(376002)(36756003)(478600001)(5660300002)(8936002)(316002)(66556008)(66476007)(8676002)(4326008)(86362001)(6512007)(1076003)(66946007)(26005)(2616005)(956004)(6506007)(52116002)(2906002)(6486002)(186003)(83380400001)(38350700002)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?E/50bgkW/darEW98A1e8lClM6L9Z5rn91vgK02eFQkSDBFnp0nGkdYSwrJTA?=
 =?us-ascii?Q?3oAnyO+os3hKN6FQwXFiPiynrRH7OzNFaUuL78yF8jbPPnL2MZp/wpmNplLq?=
 =?us-ascii?Q?7B85zIPyWNqjifXX0DENhW9hybU4MMDnln3S+x7Ro+aFQ85YTr4emZB6yKvY?=
 =?us-ascii?Q?b2RjdaYYITiEwP5q083vgNMEfiGrBogKO31AT8IHYFrt1ODCAF0MWYsDzUrC?=
 =?us-ascii?Q?+g5MEx9I9SLQRZtBHirPRsXr+9NGRqb+yCsLKcsVPjz4XVy7/cnySr19oroT?=
 =?us-ascii?Q?mmqniIjevVpT3q4X7E/nyQOvfgY/wKE6ibR9l/0OK8uI8SyiziwzjYHWdn0M?=
 =?us-ascii?Q?tpaAbQe7aHT4v6vT2g/WCdHtjxjka3YX5EqHERn18DU8FdwUv3tLghu0Ib66?=
 =?us-ascii?Q?uzyzyLYXarc3GTq7idVSXXqE42+4cbBqqIDFlmK1UIdZmcwyXGdYfiF9lCDO?=
 =?us-ascii?Q?wHS8x4XJsaLcsVeIkLXkg1Jf7bzhUaI/NZGQA2nHLPWdYrlpV0WzvIuwey1M?=
 =?us-ascii?Q?HNOxsn0TIkJtLhhAsk4ionqGcgfiSTKPAIo0aeKFrU7QqueS/HAScQZHGvWr?=
 =?us-ascii?Q?R5eb5cUarWvu58FMb7do3IbeVtiurhJdKkb27SHzGrvQHUyp32nimaq97KBU?=
 =?us-ascii?Q?CNwaVtkFiBac3LvsCAAdu+PaqmHDA+Ci+TAes9TUfva8herzYe3CCjxpHCZg?=
 =?us-ascii?Q?uQA53bx2RDfFlSYa3wnAimCjhlmBf3rNzQ2YPBlBnw5m+XwO2D8Sl7EZGa+R?=
 =?us-ascii?Q?hsKgMRMQs6VVJsdKKkCFrf2BVo4ziXHUwfrFotBt3yiafy6c1Z4ez1ZnWcF9?=
 =?us-ascii?Q?e8UXwJpEcKM2C80CsGeQG4ZaIlGrseg3NKzEOT7N9xi17OrHtPpKYziT1WzI?=
 =?us-ascii?Q?5dnVfX8RQhWORWTf8clfGz+QEJPptaqi27YEsu+TYUwmsvlPuKBEza2JdY7F?=
 =?us-ascii?Q?+vnIqsJcEMNOGg2DTeIz73ebugA5f4E+Soy7hfWkxdZiifX17jpltXMxdhjK?=
 =?us-ascii?Q?ABevmoQeIGzu7yzg/jRGa+sNW4xyLqsm4gH3VHhDQc5hijKlLGv0PnyAO8Ro?=
 =?us-ascii?Q?btby6eOcH9TcwhOG+Dfr/KowoWHZ1jP5foUz7F0LD2v21wpjjf5V7ZmiEvLq?=
 =?us-ascii?Q?5Tr9YlOe0dL1i7ypFcc5t333QIEUtxLxjyjCZ6390l5J/5DsjfsjZ6k9lUh+?=
 =?us-ascii?Q?IIFm3WFVglUJcUQxBKnTkaxv36xFOqfoeNrhZi9mRdlg4GdHl7t2RjyHmP7f?=
 =?us-ascii?Q?gpaYEn2DIaF98PXxWfq2FD+iKkXiceM58WAY2CxqQV5iZajll2tMgxaZuBRU?=
 =?us-ascii?Q?ukD0fgCWOfDry10cNPUtUDQO?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 790100e4-c39f-4a60-1cce-08d948370279
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB5623.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jul 2021 08:52:15.3307
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TYBRZVzaO4Enol+cksOBuJ7XxOAn+gClKWf+QvgCTGXiRr4/2u0Tx7QTqculdesFnBF7h0M50/IwYJVZaiRnEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7142
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

If using I2C/I3C mixed mode, need to set ODSTOP. Otherwise, the I2C
devices cannot see the stop signal. It may cause message sending errors.

Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
V2/V3: No change.
---
 drivers/i3c/master/svc-i3c-master.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index 91358cc5ca07..5677b5b31a86 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -449,7 +449,7 @@ static int svc_i3c_master_bus_init(struct i3c_master_controller *m)
 	struct i3c_device_info info = {};
 	unsigned long fclk_rate, fclk_period_ns;
 	unsigned int high_period_ns, od_low_period_ns;
-	u32 ppbaud, pplow, odhpp, odbaud, i2cbaud, reg;
+	u32 ppbaud, pplow, odhpp, odbaud, odstop, i2cbaud, reg;
 	int ret;
 
 	/* Timings derivation */
@@ -479,6 +479,7 @@ static int svc_i3c_master_bus_init(struct i3c_master_controller *m)
 	switch (bus->mode) {
 	case I3C_BUS_MODE_PURE:
 		i2cbaud = 0;
+		odstop = 0;
 		break;
 	case I3C_BUS_MODE_MIXED_FAST:
 	case I3C_BUS_MODE_MIXED_LIMITED:
@@ -487,6 +488,7 @@ static int svc_i3c_master_bus_init(struct i3c_master_controller *m)
 		 * between the high and low period does not really matter.
 		 */
 		i2cbaud = DIV_ROUND_UP(1000, od_low_period_ns) - 2;
+		odstop = 1;
 		break;
 	case I3C_BUS_MODE_MIXED_SLOW:
 		/*
@@ -494,6 +496,7 @@ static int svc_i3c_master_bus_init(struct i3c_master_controller *m)
 		 * constraints as the FM+ mode.
 		 */
 		i2cbaud = DIV_ROUND_UP(2500, od_low_period_ns) - 2;
+		odstop = 1;
 		break;
 	default:
 		return -EINVAL;
@@ -502,7 +505,7 @@ static int svc_i3c_master_bus_init(struct i3c_master_controller *m)
 	reg = SVC_I3C_MCONFIG_MASTER_EN |
 	      SVC_I3C_MCONFIG_DISTO(0) |
 	      SVC_I3C_MCONFIG_HKEEP(0) |
-	      SVC_I3C_MCONFIG_ODSTOP(0) |
+	      SVC_I3C_MCONFIG_ODSTOP(odstop) |
 	      SVC_I3C_MCONFIG_PPBAUD(ppbaud) |
 	      SVC_I3C_MCONFIG_PPLOW(pplow) |
 	      SVC_I3C_MCONFIG_ODBAUD(odbaud) |
-- 
2.25.1