Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp1134704pxv; Fri, 16 Jul 2021 02:22:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz7Z83TuOvBAad9CMT7iRN59lUSH8H4uq78lTUyXrgkIrmSRMhC6zELXguq39ovutLmFbe7 X-Received: by 2002:a05:6638:1383:: with SMTP id w3mr8171337jad.32.1626427339068; Fri, 16 Jul 2021 02:22:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626427339; cv=none; d=google.com; s=arc-20160816; b=DqmEu10AH2blMOC9hPTFH/IiZu/Ipx+ziT4U5+kCn2hluOIpSDr5minJCjSjVQcHlp 39PcbwCPeED+iNUfn1P/dZRnM4kZ3lsMNCvmttMdWOjMiJ6TsIHWa3pvzFOw35kOCtgY ltx40RwEXp6oiY/R/Qdo7ieW/KDBL5amRbPtCjoFDQ9aRZlK2gowFPGU0cQhdwkME3o9 lHHGJDJNjzW9n1RPt7IdurMwHS7cDbGdgrz8+tZk3iqhkPtlFePbbuKyR991Cbjj0u7Z WX1koMlAG1mKMkSwFXvciVbOALxVYi4li7LGi6a7+HWK/0todpEAK7dbzQBCui4XgP4k lUzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=K8jKAtfsD8Dso/Nb/D2+fe50ZjKqaNK5zqUd9Ii1CJA=; b=OeZJHgIXkI0J4u2I8N+sbH96v/nD82QGj7GIT3fNTgLuSIEhY8I+SMV78+VKZJBZRb 8Bc3RmWvDkOWdzo1eT0tkhdsv7cvsZkOTecQYexfURtZgiFdGEt9XCh1SHMxNtwOWVBi Agt+U2CfJq+dNdj2K991YoPEf6RD97mYegquI17ZzE8LiLpMJWx0fa7oH0pIJ4Uk7HqV fJtoZKJTp1w8fBtx5Q9tXcRhEQwGRad5KNlU3sqYrI99RK1z1ajr0xB9yrpZzdJMAVVK odVCvmuPCYcyVo3jjFTRYcpcpyoh2Z24wVcwpWauIPGydVSLN0E6qL0ILT42aKSySGfp /FFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vbLCXbCl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s5si9642921ilq.98.2021.07.16.02.22.05; Fri, 16 Jul 2021 02:22:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vbLCXbCl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232908AbhGPJXN (ORCPT + 99 others); Fri, 16 Jul 2021 05:23:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232690AbhGPJXN (ORCPT ); Fri, 16 Jul 2021 05:23:13 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C017AC06175F for ; Fri, 16 Jul 2021 02:20:18 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id v5so11298213wrt.3 for ; Fri, 16 Jul 2021 02:20:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=K8jKAtfsD8Dso/Nb/D2+fe50ZjKqaNK5zqUd9Ii1CJA=; b=vbLCXbClAuFvWqGMXq4nOWCmDMtxtqzY42Ia2T/WkLVc14A6QzUxJG1PXEi/A9wwXc DLFXDG4kjVNShZ/qXsnFLmOoL9YLOLmwbRrExVjLkPkT60ILIQ81EV/nVuVxxc2EdWwB QoXSyylx+IDYnwDxaX4mQRTKdvHmyF7xURiI/Ccwh/IHmmUQbLg3VXNBKKRzZA9nAoIS iFBeJ270be5ML5NDWSefXHbsNK9MgY4izQnq/1IWDv0svU4fXx/PH762+FkAjNkVL67i 5Hr53XvYiqcZEr0hHaLh/cgBnJEfCtpTeMKQyI3xo+O7W9O6kx4NfSDH6Ab/OY48isZ1 Q1lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=K8jKAtfsD8Dso/Nb/D2+fe50ZjKqaNK5zqUd9Ii1CJA=; b=U1aSq4XTzKd/35jEJHN+1+hG3xexzxoMJQ8IG7qie8jTtVHY9j1QWKm8loBikoMkKq nINEPijiiMFGUvnHAtnDeii6PwObcmXrUsDH8NAVtQYT3SkBYRVaIhEcIEungDUY+3Zs hOqk20IlYaaqPE0Hgzxe4s5qMtxiRRuF6F0gtMLACLhYWHaA4zGHwkSoBHByIALzKu/M iuHSnB9GgJ6qTfPsyKLToA5IHNkBshNFuVDg/x5ZvYeCaWirfcaTkfbfp4xrq/F7tnqJ HGa6E0u7XVc1EtAaf9bZTbYb63HONLxddMfpxDqIX0tbfwz1PJpaT/bQwdXwHUdvhMYb ICwg== X-Gm-Message-State: AOAM530GoXEwG9PRBxZ9KKbKQJMQ1uFfVaFTOATHeS7/NTSF8AkGUlb9 pc876SvDZRtPcR7sXrlcJJ0ESQ== X-Received: by 2002:a05:6000:18c2:: with SMTP id w2mr10908600wrq.282.1626427217381; Fri, 16 Jul 2021 02:20:17 -0700 (PDT) Received: from google.com ([31.124.24.141]) by smtp.gmail.com with ESMTPSA id h15sm9117073wrq.88.2021.07.16.02.20.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jul 2021 02:20:16 -0700 (PDT) Date: Fri, 16 Jul 2021 10:20:15 +0100 From: Lee Jones To: Matthias Schiffer Cc: Linus Walleij , Bartosz Golaszewski , Andrew Lunn , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/7] TQMx86: TQMx110EB and TQMxE40x MFD/GPIO support Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 02 Jul 2021, Matthias Schiffer wrote: > Updated patch series: > > - A number of new patches (more hardware support and a few fixes) > - Patches 1-3 have gained Fixes tags > - Patch 2 depends on 1, so maybe we can push the GPIO patch through the > MFD tree to keep them together? > - The change in patch 7 was somewhat controversial. I've added a > warning, but it is the last patch of the series, so it doesn't affect > the rest of the series if it is rejected. > > > Matthias Schiffer (7): > gpio: tqmx86: really make IRQ optional > mfd: tqmx86: clear GPIO IRQ resource when no IRQ is set > mfd: tqmx86: remove incorrect TQMx90UC board ID > mfd: tqmx86: fix typo in "platform" > mfd: tqmx86: add support for TQMx110EB and TQMxE40x > mfd: tqmx86: add support for TQ-Systems DMI IDs > mfd: tqmx86: assume 24MHz LPC clock for unknown boards > > drivers/gpio/gpio-tqmx86.c | 6 ++--- > drivers/mfd/tqmx86.c | 48 ++++++++++++++++++++++++++++++-------- > 2 files changed, 41 insertions(+), 13 deletions(-) Patches look good. Could you please collect up Andrew's acks, remove the suggested Fixes: lines and resubmit please? I'll quickly apply them once resent (probably Monday - if you get them out today). -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog