Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 16 Jul 2021 15:17:22 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     laurentiu.tudor@nxp.com
Cc:     heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org,
        rafael@kernel.org, linux-acpi@vger.kernel.org,
        linux-kernel@vger.kernel.org, jon@solid-run.com
Subject: Re: [PATCH] software node: balance refcount for managed sw nodes
Message-ID: <YPF40t5bhgTFM2wK@smile.fi.intel.com>
References: <20210716101602.1891-1-laurentiu.tudor@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210716101602.1891-1-laurentiu.tudor@nxp.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Fri, Jul 16, 2021 at 01:16:02PM +0300, laurentiu.tudor@nxp.com wrote:
> From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> 
> software_node_notify(), on KOBJ_REMOVE drops the refcount twice on managed
> software nodes, thus leading to underflow errors. Balance the refcount by
> bumping it in the device_create_managed_software_node() function.
> 
> The error [1] was encountered after adding a .shutdown() op to our
> fsl-mc-bus driver.

Looking into the history of adding ->shutdown() to dwc3 driver (it got reverted
later on), I can tell that probably something is wrong in the ->shutdown()
method itself.

-- 
With Best Regards,
Andy Shevchenko