Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Oleksandr Natalenko <oleksandr@natalenko.name>
To:     Ming Lei <ming.lei@redhat.com>
Cc:     linux-kernel@vger.kernel.org, Jens Axboe <axboe@fb.com>,
        Christoph Hellwig <hch@lst.de>,
        Sagi Grimberg <sagi@grimberg.me>,
        linux-nvme@lists.infradead.org,
        David Jeffery <djeffery@redhat.com>,
        Laurence Oberman <loberman@redhat.com>,
        Paolo Valente <paolo.valente@linaro.org>,
        Jan Kara <jack@suse.cz>, Sasha Levin <sashal@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Keith Busch <kbusch@kernel.org>
Subject: Re: New warning in nvme_setup_discard
Date:   Fri, 16 Jul 2021 14:56:22 +0200
Message-ID: <1687461.6WkTYu5mUM@natalenko.name>
In-Reply-To: <YPFicCW90Jse4oms@T590>
References: <4729812.CpyZKHjjVO@natalenko.name> <2455133.St5lIfLNcX@natalenko.name> <YPFicCW90Jse4oms@T590>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On p=C3=A1tek 16. =C4=8Dervence 2021 12:41:52 CEST Ming Lei wrote:
> > Do I understand correctly that this will be something like:
> >=20
> > Fixes: 2705dfb209 ("block: fix discard request merge")
> >=20
> > ?
> >=20
> > Because as the bisection progresses, I've bumped into this commit only.
> > Without it the issue is not reproducible, at least so far.
>=20
> It could be.
>=20
> So can you just test v5.14-rc1?

Doing it right now, but I've got another issue. Why BFQ is not listed here:

```
/sys/class/block/nvme0n1/queue/scheduler:[mq-deadline] kyber none
/sys/class/block/nvme1n1/queue/scheduler:[mq-deadline] kyber none
```

?

It is a built-in, FWIW:

```
$ modinfo bfq
name:           bfq
filename:       (builtin)
description:    MQ Budget Fair Queueing I/O Scheduler
license:        GPL
file:           block/bfq
author:         Paolo Valente
alias:          bfq-iosched
```

So far the issue is not reproducible with your patch + 5.13.2 as well as 5.=
14-
rc1 (but I don't have BFQ either with v5.14-rc1).

=2D-=20
Oleksandr Natalenko (post-factum)