Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 16 Jul 2021 17:18:37 +0300
From:   Pavel Skripkin <paskripkin@gmail.com>
To:     Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc:     linux-kernel@vger.kernel.org, rostedt@goodmis.org,
        syzkaller-bugs@googlegroups.com, tglx@linutronix.de,
        syzbot <syzbot+e68c89a9510c159d9684@syzkaller.appspotmail.com>
Subject: Re: [syzbot] UBSAN: shift-out-of-bounds in profile_init
Message-ID: <20210716171837.69bcc1b6@gmail.com>
In-Reply-To: <949a12a0-a0a6-0574-4e87-4ed196ff6d78@i-love.sakura.ne.jp>
References: <000000000000610af005c714c1d1@google.com>
        <20210716152440.368d4250@gmail.com>
        <949a12a0-a0a6-0574-4e87-4ed196ff6d78@i-love.sakura.ne.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 16 Jul 2021 23:10:25 +0900
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> wrote:

> On 2021/07/16 21:24, Pavel Skripkin wrote:
> > But this function can be called not only from sysfs and I can't
> > understand will my patch break something or not. And, I think, error
> > message is needed somewhere here to inform callers about wrong shift
> > value.
> > 
> > 
> > Thoughts?
> 
> Subsequent profiling_store() attempts will return -EEXIST if
> profile_setup() once set prof_on to non-zero value. Therefore,
> if you try to return -EINVAL when profile_setup() returns 0,
> you need to make sure that prof_on is set to non-zero value
> only if prof_shift is valid.
> 
> But, the userspace might not be aware of the value of MAX_PROF_SHIFT
> because it is an architecture dependent value, and par might become
> negative value because get_option() accepts negative value.
> Therefore, it might be better to
> 
> +		par = clamp(par, 0, MAX_PROF_SHIFT - 1);
> 
> than
> 
> +		if (par < 0 || par >= MAX_PROF_SHIFT)
> +			return 0;
> 
> .
> 

Yes, this sounds much better, thank you. I will send reworked patch to
syzbot. Do you mind if I add 

Suggested-by: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>

tag to final patch?


With regards,
Pavel Skripkin