Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Tejun Heo <htejun@gmail.com>
Date:   Fri, 16 Jul 2021 06:14:29 -1000
From:   Tejun Heo <tj@kernel.org>
To:     Yang Yingliang <yangyingliang@huawei.com>
Cc:     linux-kernel@vger.kernel.org, jiangshanlai@gmail.com,
        xuqiang36@huawei.com, paskripkin@gmail.com
Subject: Re: [PATCH v3] workqueue: fix UAF in pwq_unbound_release_workfn()
Message-ID: <YPGwZVsE0AmkpziS@mtj.duckdns.org>
References: <20210714091934.3124170-1-yangyingliang@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210714091934.3124170-1-yangyingliang@huawei.com>
Precedence: bulk

On Wed, Jul 14, 2021 at 05:19:33PM +0800, Yang Yingliang wrote:
> If apply_wqattrs_prepare() fails, the new pwq are not linked, it doesn't
> hold any reference to the 'wq', 'wq' is invalid to access in the worker,
> so add check pwq if linked to fix this.
> 
> Fixes: 2d5f0764b526 ("workqueue: split apply_workqueue_attrs() into 3 stages")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Suggested-by: Lai Jiangshan <jiangshanlai@gmail.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

Applied to wq/for-5.14-fixes.

Thanks.

-- 
tejun