Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210702191044.988401-1-atish.patra@wdc.com>
In-Reply-To: <20210702191044.988401-1-atish.patra@wdc.com>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Fri, 16 Jul 2021 18:18:43 +0200
Message-ID: <CAMj1kXFVj8RFxy5Ujio7Ah6=HFOhNtHVWiCiPKzzQUF4ahY=xw@mail.gmail.com>
Subject: Re: [PATCH] efi/libstub: Fix the efi_load_initrd function description
To:     Atish Patra <atish.patra@wdc.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Arvind Sankar <nivedita@alum.mit.edu>,
        linux-efi <linux-efi@vger.kernel.org>,
        Will Deacon <will@kernel.org>,
        Heinrich Schuchardt <xypron.glpk@gmx.de>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 2 Jul 2021 at 21:10, Atish Patra <atish.patra@wdc.com> wrote:
>
> The soft_limit and hard_limit in the function efi_load_initrd describes
> the preferred and max address of initrd loading location respectively.
> However, the description wrongly describes it as the size of the
> allocated memory.
>
> Fix the function description.
>
> Signed-off-by: Atish Patra <atish.patra@wdc.com>

Now queued up, thanks.

> ---
>  drivers/firmware/efi/libstub/efi-stub-helper.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/efi/libstub/efi-stub-helper.c b/drivers/firmware/efi/libstub/efi-stub-helper.c
> index aa8da0a49829..ae87dded989d 100644
> --- a/drivers/firmware/efi/libstub/efi-stub-helper.c
> +++ b/drivers/firmware/efi/libstub/efi-stub-helper.c
> @@ -630,8 +630,8 @@ efi_status_t efi_load_initrd_cmdline(efi_loaded_image_t *image,
>   * @image:     EFI loaded image protocol
>   * @load_addr: pointer to loaded initrd
>   * @load_size: size of loaded initrd
> - * @soft_limit:        preferred size of allocated memory for loading the initrd
> - * @hard_limit:        minimum size of allocated memory
> + * @soft_limit:        preferred address for loading the initrd
> + * @hard_limit:        upper limit address for loading the initrd
>   *
>   * Return:     status code
>   */
> --
> 2.31.1
>